Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8321519: Typo in exception message #17016

Closed
wants to merge 1 commit into from

Conversation

djelinski
Copy link
Member

@djelinski djelinski commented Dec 7, 2023

This PR fixes a typo in exception message printed when jdk.readPollers or jdk.writePollers is not a power of two.

While at it, I searched the code for other instances of vale, and corrected them as well.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17016/head:pull/17016
$ git checkout pull/17016

Update a local copy of the PR:
$ git checkout pull/17016
$ git pull https://git.openjdk.org/jdk.git pull/17016/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17016

View PR using the GUI difftool:
$ git pr show -t 17016

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17016.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 7, 2023

👋 Welcome back djelinski! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 7, 2023

@djelinski The following labels will be automatically applied to this pull request:

  • client
  • hotspot-runtime
  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-runtime hotspot-runtime-dev@openjdk.org nio nio-dev@openjdk.org client client-libs-dev@openjdk.org labels Dec 7, 2023
@djelinski djelinski changed the title Fix vale->value 8321519 Dec 7, 2023
@openjdk openjdk bot changed the title 8321519 8321519: Typo in exception message Dec 7, 2023
@djelinski djelinski marked this pull request as ready for review December 7, 2023 10:13
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 7, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 7, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 7, 2023

@djelinski This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8321519: Typo in exception message

Reviewed-by: jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 7, 2023
@djelinski
Copy link
Member Author

Thanks for the review. Given that it's a trivial change, I'm going to integrate it now.

/integrate

@openjdk
Copy link

openjdk bot commented Dec 7, 2023

Going to push as commit ead4fb1.
Since your change was applied there have been 5 commits pushed to the master branch:

  • b5933b1: 8320805: JFR: Create view for deprecated methods
  • 29d7a22: 8321270: Virtual Thread.yield consumes parking permit
  • 0b0fa47: 8319925: CSS.BackgroundImage incorrectly uses double-checked locking
  • 0048f1d: 8263256: Test java/net/Inet6Address/serialize/Inet6AddressSerializationTest.java fails due to dynamic reconfigurations of network interface during test
  • 49fff01: 8211238: @deprecated JFR event

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 7, 2023
@openjdk openjdk bot closed this Dec 7, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 7, 2023
@openjdk
Copy link

openjdk bot commented Dec 7, 2023

@djelinski Pushed as commit ead4fb1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@djelinski djelinski deleted the value-typo branch December 7, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated nio nio-dev@openjdk.org
2 participants