8321892: Typo in log message logged by src/hotspot/share/nmt/virtualMemoryTracker.cpp

[stevenschlansker]

Discovered while deep in an InternalError debugging session...

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8321892: Typo in log message logged by src/hotspot/share/nmt/virtualMemoryTracker.cpp (Bug - P4)

Reviewers

• David Holmes (@dholmes-ora - Reviewer)
• Afshin Zafari (@afshin-zafari - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17021/head:pull/17021
$ git checkout pull/17021

Update a local copy of the PR:
$ git checkout pull/17021
$ git pull https://git.openjdk.org/jdk.git pull/17021/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17021

View PR using the GUI difftool:
$ git pr show -t 17021

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17021.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

Hi @stevenschlansker, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user stevenschlansker" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[openjdk]

@stevenschlansker To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels

• build
• client
• compiler
• core-libs
• graal
• hotspot
• hotspot-compiler
• hotspot-gc
• hotspot-jfr
• hotspot-runtime
• i18n
• ide-support
• javadoc
• jdk
• jmx
• kulla
• net
• nio
• security
• serviceability
• shenandoah

[stevenschlansker]

/signed
/label hotspot

[openjdk]

@stevenschlansker
The hotspot label was successfully added.

[bridgekeeper]

Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

[jaikiran]

Hello Steven, I've created a JDK issue to track this change https://bugs.openjdk.org/browse/JDK-8321892. Please update the title of this PR to 8321892: Typo in log message logged by src/hotspot/share/nmt/virtualMemoryTracker.cpp so that it then triggers the official review process.

[mlbridge]

Webrevs

• 00: Full (4636040a)

[dholmes-ora]

Looks fine and trivial (only 1 review needed).

Thanks

[openjdk]

@stevenschlansker This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8321892: Typo in log message logged by src/hotspot/share/nmt/virtualMemoryTracker.cpp

Reviewed-by: dholmes, azafari

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 78 new commits pushed to the master branch:

• 6311dab: 8322018: Test java/lang/String/CompactString/MaxSizeUTF16String.java fails with -Xcomp
• bdebf19: 8322175: test/langtools/tools/javac/classreader/BadMethodParameter.java doesn't compile
• 20de541: 8322040: Missing array bounds check in ClassReader.parameter
• b31454e: 8322098: os::Linux::print_system_memory_info enhance the THP output with /sys/kernel/mm/transparent_hugepage/hpage_pmd_size
• 0be0775: 8320397: RISC-V: Avoid passing t0 as temp register to MacroAssembler:: cmpxchg_obj_header/cmpxchgptr
• 6dfb812: 8321823: Remove redundant PhaseGVN transform_no_reclaim
• a7dde57: 8322057: Memory leaks in creating jfr symbol array
• 692be57: 8322065: Initial nroff manpage generation for JDK 23
• d02bc87: 8309981: Remove expired flags in JDK 23
• 8b24851: 8321480: ISO 4217 Amendment 176 Update
• ... and 68 more: https://git.openjdk.org/jdk/compare/519ecd352a66633589f160db7390647d90e36b99...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dholmes-ora, @afshin-zafari) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[afshin-zafari]

Thanks for fixing it.

[stevenschlansker]

/integrate

[openjdk]

@stevenschlansker
Your change (at version 4636040) is now ready to be sponsored by a Committer.

[jaikiran]

/sponsor

[openjdk]

Going to push as commit 34351b7.
Since your change was applied there have been 82 commits pushed to the master branch:

• b061b66: 8322041: JDK 22 RDP1 L10n resource files update
• dcdcd48: 8321479: java -D-D crashes
• 87ef733: 8321958: @param/@return descriptions of ZoneRules#isDaylightSavings() are incorrect
• 05f7f0a: 8321288: [JVMCI] HotSpotJVMCIRuntime doesn't clean up WeakReferences in resolvedJavaTypes
• 6311dab: 8322018: Test java/lang/String/CompactString/MaxSizeUTF16String.java fails with -Xcomp
• bdebf19: 8322175: test/langtools/tools/javac/classreader/BadMethodParameter.java doesn't compile
• 20de541: 8322040: Missing array bounds check in ClassReader.parameter
• b31454e: 8322098: os::Linux::print_system_memory_info enhance the THP output with /sys/kernel/mm/transparent_hugepage/hpage_pmd_size
• 0be0775: 8320397: RISC-V: Avoid passing t0 as temp register to MacroAssembler:: cmpxchg_obj_header/cmpxchgptr
• 6dfb812: 8321823: Remove redundant PhaseGVN transform_no_reclaim
• ... and 72 more: https://git.openjdk.org/jdk/compare/519ecd352a66633589f160db7390647d90e36b99...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jaikiran @stevenschlansker Pushed as commit 34351b7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.