8307246 : Printing: banded raster path doesn't account for device offset values #17030

vtstydev · 2023-12-08T05:52:46Z

More correct way to take in consideration nonzero PHYSICALOFFSETX, PHYSICALOFFSETY of device for banded-raster printing loop. Only on Windows platform under certain conditions real device prints shifted image on paper.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8307246: Printing: banded raster path doesn't account for device offset values (Bug - P4)

Reviewers

Phil Race (@prrace - Reviewer)
Prasanta Sadhukhan (@prsadhuk - Reviewer)
Alexey Ivanov (@aivanov-jdk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17030/head:pull/17030
$ git checkout pull/17030

Update a local copy of the PR:
$ git checkout pull/17030
$ git pull https://git.openjdk.org/jdk.git pull/17030/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17030

View PR using the GUI difftool:
$ git pr show -t 17030

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17030.diff

Webrev

Link to Webrev Comment

…SICALOFFSETY of device for banded-raster printing loop

bridgekeeper · 2023-12-08T05:53:54Z

👋 Welcome back vtstydev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2023-12-08T05:54:26Z

@vtstydev The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2023-12-08T08:48:56Z

Webrevs

prrace · 2023-12-08T21:54:35Z

This is going to require manual verification. Likely we'll need to test all possible page orientations too - did you try that ?

prrace · 2023-12-08T21:55:31Z

The PR title needs to change to match the bug.
Actually the bug summary is awful, so I'll fix that first then the PR needs to change to match what I've done there.

vtstydev · 2023-12-11T05:32:20Z

This is going to require manual verification. Likely we'll need to test all possible page orientations too - did you try that ?

I printed some documents, that renders with banded-raster printing loop, both orientations on Windows and Linux. They were printed well.

openjdk · 2023-12-11T11:39:10Z

@vtstydev Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

bridgekeeper · 2024-01-08T19:51:18Z

@vtstydev This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

vtstydev · 2024-01-22T05:37:15Z

@prrace The system is about to close this PR. Is there a chance for your time to be taken for it?

prrace · 2024-01-23T00:42:34Z

This is going to require manual verification. Likely we'll need to test all possible page orientations too - did you try that ?

I printed some documents, that renders with banded-raster printing loop, both orientations on Windows and Linux. They were printed well.

I was hoping (!) you would write a test. In fact there needs to be one.
Comparison of opaque vs translucent in all orientations.
And clearly it needs to be a manual test, that means user instructions are needed.
It should use PassFailJFrame
The test probably also needs to display the print dialog, so the user can agree on which printer to use.

I've not done those last 3 things but here's a test which starts with what you had in the bug report.
It needs to be updated to be a proper jtreg test.

mport java.awt.BasicStroke;
import java.awt.Color;
import java.awt.Graphics;
import java.awt.Graphics2D;
import java.awt.Rectangle;
import java.awt.Stroke;
import java.awt.print.Book;
import java.awt.print.Pageable;
import java.awt.print.PageFormat;
import static java.awt.print.PageFormat.;
import java.awt.print.Paper;
import java.awt.print.Printable;
import static java.awt.print.Printable.;
import java.awt.print.PrinterException;
import java.awt.print.PrinterJob;
import javax.print.attribute.HashPrintRequestAttributeSet;
import javax.print.attribute.PrintRequestAttributeSet;
import javax.print.attribute.standard.Sides;

public class AlphaPrintingOffsets implements Printable {

private static final Color OPAQUE_COLOR = Color.black;
private static final Color ALPHA_COLOR = new Color(0, 0, 0, 200);
private static AlphaPrintingOffsets opaque = new AlphaPrintingOffsets(OPAQUE_COLOR);
private static AlphaPrintingOffsets alpha = new AlphaPrintingOffsets(ALPHA_COLOR);

private Color color;

public AlphaPrintingOffsets(Color c) {
     color = c;
}

private static String getOrientStr(int orient) {
    switch (orient) {
        case PORTRAIT: return "PORTRAIT";
        case LANDSCAPE: return "LANDSCAPE";
        case REVERSE_LANDSCAPE: return "REVERSE_LANDSCAPE";
        default : return "BAD Orientation";
    }
}

@Override
public int print(Graphics graphics, PageFormat pageFormat, int pageIndex)
                 throws PrinterException {

    Graphics2D g2d = (Graphics2D)graphics;
    g2d.setColor(OPAQUE_COLOR);

    Stroke oldstroke = g2d.getStroke();
    g2d.setStroke(new BasicStroke(10));
    g2d.translate(15, 0);
    g2d.drawLine(0, 0 ,0, 300); //LEFT margin line
    g2d.translate(-15, 0);
    g2d.translate(0, -15);

    Paper paper = pageFormat.getPaper();
    int orient = pageFormat.getOrientation();
    int iw = (int)paper.getImageableWidth();
    int ih = (int)paper.getImageableHeight();
    int bm = orient == PORTRAIT ? ih : iw; //BOTTOM margin line
    g2d.drawLine(0, bm, 300, bm);
    g2d.translate(0, 15);
    g2d.setStroke(oldstroke);

    String msg = "Orient= " + getOrientStr(orient);
    msg += " Color="+ (color.getAlpha() != 255 ? " ALPHA" : " OPAQUE");
    g2d.drawString(msg, 300, 300);
    g2d.setColor(color);
    g2d.fill(new Rectangle(0, 0, 200, 200));

    return PAGE_EXISTS;
}

public static void main(String[] argv) {
    test(PORTRAIT);
    test(LANDSCAPE);
    test(REVERSE_LANDSCAPE);

}

static void test(int orient) {

    PrinterJob printJob = PrinterJob.getPrinterJob();
    PageFormat pageFormat = printJob.defaultPage();
    Paper paper = pageFormat.getPaper();
    paper.setImageableArea(0,0,paper.getWidth(),paper.getHeight());
    pageFormat.setOrientation(orient);
    pageFormat.setPaper(paper);

    Book book = new Book();
    book.append(opaque, pageFormat);
    book.append(alpha, pageFormat);
    printJob.setPageable(book);

    PrintRequestAttributeSet aset = new HashPrintRequestAttributeSet();
    aset.add(Sides.ONE_SIDED);
    try {
        printJob.print(aset);
    } catch (PrinterException e) {
        e.printStackTrace();
    }
}

}

openjdk · 2024-01-25T10:58:41Z

@vtstydev Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

prrace

Very close (!) I see just a couple of minor things I need you to fix.

prrace · 2024-01-26T20:28:52Z

test/jdk/java/awt/print/PrinterJob/ImagePrinting/AlphaPrintingOffsets.java

@@ -0,0 +1,199 @@
+/*
+ * Copyright (c) 2007, 2022, Oracle and/or its affiliates. All rights reserved.


I guess you copied the header including "2007, 2022," from some other file.
This is a new test so it should just be "2024,"

prrace · 2024-01-26T20:31:45Z

test/jdk/java/awt/print/PrinterJob/ImagePrinting/AlphaPrintingOffsets.java

+import javax.print.attribute.PrintRequestAttributeSet;
+import javax.print.attribute.standard.Sides;
+import javax.swing.*;
+import java.awt.*;


We don't use wildcard imports - the example I pasted had none !
So please explicitly list all imports and we "sort" these. generally alphabetically at least for the same module.
So the order of the packages should be
java.awt
java.awt.event
java.awt.print
javax.print
javax.swing

prrace

LGTM

@prsadhuk please be the required 2nd reviewer.

openjdk · 2024-01-29T17:25:37Z

@vtstydev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8307246: Printing: banded raster path doesn't account for device offset values

Reviewed-by: prr, psadhukhan, aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 739 new commits pushed to the master branch:

b366492: 8326152: Bad copyright header in test/jdk/java/util/zip/DeflaterDictionaryTests.java
9451677: 8326100: DeflaterDictionaryTests should use Deflater.getBytesWritten instead of Deflater.getTotalOut
d422811: 8324630: C1: Canonicalizer::do_LookupSwitch doesn't break the loop when the successor is found
3742bc6: 8323795: jcmd Compiler.codecache should print total size of code cache
099b744: 8326117: ProblemList serviceability/jvmti/vthread/SuspendWithInterruptLock/SuspendWithInterruptLock.java#default in Xcomp mode
39627bc: 6510914: JScrollBar.getMinimumSize() breaks the contract of JComponent.setMinimumSize()
7004c27: 8303972: (zipfs) Make test/jdk/jdk/nio/zipfs/TestLocOffsetFromZip64EF.java independent of the zip command line
c2d9fa2: 8326000: Remove obsolete comments for class sun.security.ssl.SunJSSE
f50df10: 8299023: TestPLABResize.java and TestPLABPromotion.java are failing intermittently
cf13086: 8317697: refactor-encapsulate x86 VM_Version::CpuidInfo
... and 729 more: https://git.openjdk.org/jdk/compare/3c6459e1de9e75898a1b32a95acf684050fbe1af...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@prrace, @prsadhuk, @aivanov-jdk) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

prsadhuk · 2024-01-30T04:32:50Z

src/java.desktop/share/classes/sun/print/RasterPrinterJob.java

@@ -2418,12 +2419,12 @@ protected int printPage(Pageable document, int pageIndex)
                         * We also need to translate by the adjusted amount
                         * so that printing appears in the correct place.
                         */
-                        int bandX = deviceLeft - deviceAddressableX;
+                        int bandX = deviceLeft;
                        if (bandX < 0) {
                            bandGraphics.translate(bandX/xScale,0);


Did we test this path where another translate is being done on the same object after it is done in l2399?

This snippet works when application sets negative start point of imageable area of paper.
I have tested it using
paper.setImageableArea(-50, -50, paper.getWidth(), paper.getHeight())
LANDSCAPE oriented and REVERSE_LANDSCAPE oriented images printed with transparency aren't the same as the corresponded images printed with opacity. They are shifted in the opposite direction.

I suggest nobody tested printing with negative start point before. It's strange when start point is situated in the negative area in my opinion. Is there a sense to assume it may be used in such way?

prsadhuk · 2024-01-30T04:33:30Z

src/java.desktop/share/classes/sun/print/RasterPrinterJob.java

@@ -2396,6 +2396,7 @@ protected int printPage(Pageable document, int pageIndex)
                     * the page on the next iteration of the loop.
                     */
                    bandGraphics.setTransform(uniformTransform);
+                    bandGraphics.translate(-deviceAddressableX,deviceAddressableY);


a is needed between 2 arguments as per coding guidelines..

prsadhuk · 2024-01-30T04:35:02Z

test/jdk/java/awt/print/PrinterJob/ImagePrinting/AlphaPrintingOffsets.java

+        } else {
+            System.out.println("Printer not configured or available."
+                    + " Test cannot continue.");
+            PassFailJFrame.forcePass();


I guess it is now being preferred to throw jtreg.SkippedException instead of forcePass for printers not available scenarios?!

PrintGlyphVectorTest, ClippedImages use PassFailJFrame.forcePass();
I guided these samples.
If you want I to to use throw istead. ok.

I guess those are old tests which need to be migrated to the new SkippedException semantics...
java/awt/print/PrinterJob/PageRangesDlgTest.java is relatively newer migrated test..and since it is mentioned in the test that it needs physical printer to reproduce and PDF printer will not do, then no point making it pass if physical printer is not present, that is my opinion

prsadhuk · 2024-01-30T04:44:31Z

Only on Windows platform under certain conditions real device prints shifted image on paper.

Also, if it affects only windows platform, will it not be more advisable to do in WPrinterJob class instead of RasterPrinterJob?

prrace · 2024-02-04T13:34:47Z

Revert the changes to the test which limit the pages printed out.
The test MUST print all orientations and MUST always print both opaque and alpha
95% of the point of this test is to ensure consistency across all cases and if it doesn't test them it is mostly pointless.

vtstydev · 2024-02-05T05:47:56Z

Revert the changes to the test which limit the pages printed out.
The test MUST print all orientations and MUST always print both opaque and alpha
95% of the point of this test is to ensure consistency across all cases and if it doesn't test them it is mostly pointless.

@prrace
May I revert everything in the test that @prsadhuk requested here:
#17030 (comment)
or you prefer that I change only how acting test by default?

prrace · 2024-02-09T03:21:44Z

Revert the changes to the test which limit the pages printed out.
The test MUST print all orientations and MUST always print both opaque and alpha
95% of the point of this test is to ensure consistency across all cases and if it doesn't test them it is mostly pointless.

@prrace May I revert everything in the test that @prsadhuk requested here: #17030 (comment) or you prefer that I change only how acting test by default?

I mean by default, when run by a testing framework, the test should print all those pages.
This is a manual test. It will be run rarely so when it does get run it ought to be thorough.
Manual doesn't mean someone typing "java AlphaPrintingOffsets", it means when jtreg is told to run the "@key manual" tests.
Any test options would only come in to play only if a developer wants to run the test directly by hand and chooses them.
FWIW I doubt they'll be useful but no harm leaving them but I'm also fine with complete reversion.

PS those options also complicate the instructions to the user !

vtstydev · 2024-02-09T09:47:25Z

@prrace I would like to backport this path to jdk8. May I ask you to add labels into JBS ?

prrace · 2024-02-11T19:40:32Z

test/jdk/java/awt/print/PrinterJob/ImagePrinting/AlphaPrintingOffsets.java

+import javax.print.attribute.standard.Sides;
+import javax.swing.JFrame;
+import jtreg.SkippedException;
+


Sorry about this but the test should FAIL if there is no printer.
SkippedException is appropriate if there were no way to filter printer tests which REQUIRE a printer to do anything useful but there IS, and it is "@key printer".

aivanov-jdk · 2024-02-12T19:42:24Z

test/jdk/java/awt/print/PrinterJob/ImagePrinting/AlphaPrintingOffsets.java

+import static java.awt.print.PageFormat.LANDSCAPE;
+import static java.awt.print.PageFormat.PORTRAIT;
+import static java.awt.print.PageFormat.REVERSE_LANDSCAPE;


Static imports always go after regular ones.

// other imports import javax.swing.JFrame; import static java.awt.print.PageFormat.LANDSCAPE; import static java.awt.print.PageFormat.PORTRAIT; import static java.awt.print.PageFormat.REVERSE_LANDSCAPE;

aivanov-jdk · 2024-02-12T19:47:43Z

test/jdk/java/awt/print/PrinterJob/ImagePrinting/AlphaPrintingOffsets.java

+public class AlphaPrintingOffsets {
+    private static final String INSTRUCTIONS =
+                    "Tested bug occurs only on-paper printing so you mustn't use PDF printer\n\n" +
+                    "1.Java print dialog should appear.\n" +


Suggested change

"1.Java print dialog should appear.\n" +

"1. Java print dialog should appear.\n" +

aivanov-jdk · 2024-02-12T19:50:56Z

test/jdk/java/awt/print/PrinterJob/ImagePrinting/AlphaPrintingOffsets.java

+                    "3. Please check the page margin rectangle are properly drawn and visible on all sides on all pages.\n" +
+                    "If so, press PASS, else press FAIL.\n\n" +
+                    "Also you may run this test in paper-saving mode. Due to tested bug affects pages printed with transparency in LANDSCAPE and REVERSE_LANDSCAPE orientations " +
+                    "there is an option to print only 2 pages affected. To do it pass PaperSavingMode parameter.";


These lines are longer than 80-column limit, they're longer than 120-column.

You can also reduce the indentation of the string, usually such lines are indented by 8 spaces, so that the opening quote would align with ‘s’ in static keyword.

aivanov-jdk · 2024-02-12T20:02:21Z

test/jdk/java/awt/print/PrinterJob/ImagePrinting/AlphaPrintingOffsets.java

+    }
+}
+
+class CustomPrintable implements Printable {


I suggest making CustomPrintable a static nested class in AlphaPrintingOffsets.

It avoids conflicts when you mark a folder as test sources in an IDE; if another test has a top-level class with the same name, CustomPrintable, compilation of test sources fails because of duplicate class.

It does not affect jtreg though, so it's just a suggestion.

There are many tests in test/jdk/java/awt/print/PrinterJob/ where side classes are not nested. I am badly familiar with nuances of project. You know better how it be more convenient. I will do it if you insist.

This is exactly the reason why I find it inconvenient. Therefore I'd rather not add add another test case which could make it worse.

Yet there are no strict rules that prescribe one way over the other. I'm not insisting.

aivanov-jdk · 2024-02-12T20:02:58Z

test/jdk/java/awt/print/PrinterJob/ImagePrinting/AlphaPrintingOffsets.java

+    private static final int THICKNESS = 10;
+    private static final int MARGIN = 15;
+    private static final int SMALL_RECTANGLE_SIZE = 5;
+    private int alphaValue;


Suggested change

private int alphaValue;

private final int alphaValue;

The value of alphaValue doesn't change after it's set in the constructor.

aivanov-jdk · 2024-02-12T20:05:12Z

src/java.desktop/share/classes/sun/print/RasterPrinterJob.java

The copyright year should be updated to 2024?

aivanov-jdk

The copyright must contain two years at most, you modify the second one to be the current year. With the three years, it will break the build because of incorrect copyright header.

aivanov-jdk · 2024-02-13T14:34:09Z

src/java.desktop/share/classes/sun/print/RasterPrinterJob.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 1998, 2023, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 1998, 2023, 2024, Oracle and/or its affiliates. All rights reserved.


Suggested change

* Copyright (c) 1998, 2023, 2024, Oracle and/or its affiliates. All rights reserved.

* Copyright (c) 1998, 2024, Oracle and/or its affiliates. All rights reserved.

aivanov-jdk · 2024-02-13T14:37:22Z

test/jdk/java/awt/print/PrinterJob/ImagePrinting/AlphaPrintingOffsets.java

+            "Tested bug occurs only on-paper printing " +
+                    "so you mustn't use PDF printer\n\n" +
+                    "1. Java print dialog should appear.\n" +


Suggested change

"Tested bug occurs only on-paper printing " +

"so you mustn't use PDF printer\n\n" +

"1. Java print dialog should appear.\n" +

"Tested bug occurs only on-paper printing " +

"so you mustn't use PDF printer\n\n" +

"1. Java print dialog should appear.\n" +

Alternatively, reduce the indentation of all the lines with the instructions.

aivanov-jdk · 2024-02-13T14:40:19Z

test/jdk/java/awt/print/PrinterJob/ImagePrinting/AlphaPrintingOffsets.java

-            System.out.println("Test failed : Printer not configured or available.");
-            throw new RuntimeException("Test failed : Printer not configured or available.");
+            System.out.println("Test failed : " +
+                    "Printer not configured or available.");
+            throw new RuntimeException("Test failed : " +
+                    "Printer not configured or available.");


I'd rather keep those unmodified, the string is not so long, and wrapping it doesn't improve readability.

In my opinion, println is redundant, the runtime exception conveys it.

aivanov-jdk · 2024-02-13T14:42:53Z

test/jdk/java/awt/print/PrinterJob/ImagePrinting/AlphaPrintingOffsets.java

+        }
+        else {


Suggested change

}

else {

} else {

This is the Java style and you follow this style in other places.

aivanov-jdk · 2024-02-13T14:43:54Z

test/jdk/java/awt/print/PrinterJob/ImagePrinting/AlphaPrintingOffsets.java

+            PassFailJFrame.builder().instructions(instructionsHeader + INSTRUCTIONS)
+                    .rows(15).testUI(() -> createTestUI()).build().awaitAndCheck();


Suggested change

PassFailJFrame.builder().instructions(instructionsHeader + INSTRUCTIONS)

.rows(15).testUI(() -> createTestUI()).build().awaitAndCheck();

PassFailJFrame.builder()

.instructions(instructionsHeader + INSTRUCTIONS)

.rows(15)

.testUI(() -> createTestUI())

.build()

.awaitAndCheck();

What do you think? Is it easier to read?

prrace · 2024-02-13T18:36:00Z

Looks like we are down to a few formatting things. Hopefully we can get this closed out very soon.

prsadhuk · 2024-02-19T06:02:10Z

@vtstydev guess you can do "\integrate" for us to "sponsor"

aivanov-jdk · 2024-02-19T09:14:31Z

guess you can do "\integrate" for us to "sponsor"

Or rather, @vtstydev, issue the /integrate command to integrate the fix. Someone will then use the /sponsor command to complete the integration. Refer to Working with Pull Requests, in particular item 10 “Integrate your change”.

vtstydev · 2024-02-19T12:28:07Z

/integrate

openjdk · 2024-02-19T12:28:27Z

@vtstydev
Your change (at version e124a2d) is now ready to be sponsored by a Committer.

aivanov-jdk · 2024-02-19T13:13:34Z

/sponsor

openjdk · 2024-02-19T13:15:16Z

Going to push as commit 56c5084.
Since your change was applied there have been 741 commits pushed to the master branch:

aeb6d8c: 8326170: Parallel: Remove unused enum CollectionType in ParallelScavengeHeap
dc17c26: 8325116: Amend jdk.ContainerConfiguration by swap related value
b366492: 8326152: Bad copyright header in test/jdk/java/util/zip/DeflaterDictionaryTests.java
9451677: 8326100: DeflaterDictionaryTests should use Deflater.getBytesWritten instead of Deflater.getTotalOut
d422811: 8324630: C1: Canonicalizer::do_LookupSwitch doesn't break the loop when the successor is found
3742bc6: 8323795: jcmd Compiler.codecache should print total size of code cache
099b744: 8326117: ProblemList serviceability/jvmti/vthread/SuspendWithInterruptLock/SuspendWithInterruptLock.java#default in Xcomp mode
39627bc: 6510914: JScrollBar.getMinimumSize() breaks the contract of JComponent.setMinimumSize()
7004c27: 8303972: (zipfs) Make test/jdk/jdk/nio/zipfs/TestLocOffsetFromZip64EF.java independent of the zip command line
c2d9fa2: 8326000: Remove obsolete comments for class sun.security.ssl.SunJSSE
... and 731 more: https://git.openjdk.org/jdk/compare/3c6459e1de9e75898a1b32a95acf684050fbe1af...master

Your commit was automatically rebased without conflicts.

openjdk · 2024-02-19T13:15:23Z

@aivanov-jdk @vtstydev Pushed as commit 56c5084.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

More correct way to take in consideration nonzero PHYSICALOFFSETX,PHY…

347dd4d

…SICALOFFSETY of device for banded-raster printing loop

openjdk bot added the client client-libs-dev@openjdk.org label Dec 8, 2023

vtstydev changed the title ~~Update for sun.print.RasterPrinterJob in banded-raster printing loop~~ JDK-8307246 : Update for sun.print.RasterPrinterJob in banded-raster printing loop Dec 8, 2023

openjdk bot added the rfr Pull request is ready for review label Dec 8, 2023

vtstydev changed the title ~~JDK-8307246 : Update for sun.print.RasterPrinterJob in banded-raster printing loop~~ 8307246 : Update for sun.print.RasterPrinterJob in banded-raster printing loop Dec 8, 2023

vtstydev changed the title ~~8307246 : Update for sun.print.RasterPrinterJob in banded-raster printing loop~~ 8307246 : Printing: banded raster path doesn't account for device offset values Dec 11, 2023

vtstydev force-pushed the Bugfix branch from 80623ee to 347dd4d Compare December 11, 2023 07:01

Merge branch 'openjdk:master' into Bugfix

220a283

openjdk bot removed the rfr Pull request is ready for review label Jan 25, 2024

Add test for comparing offsets of images

62168fb

vtstydev force-pushed the Bugfix branch from 58b8429 to 62168fb Compare January 25, 2024 10:58

openjdk bot added the rfr Pull request is ready for review label Jan 25, 2024

prrace reviewed Jan 26, 2024

View reviewed changes

Fix header and imports section in AlphaPrintingOffsets

57659d3

prrace approved these changes Jan 29, 2024

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Jan 29, 2024

prsadhuk reviewed Jan 30, 2024

View reviewed changes

Done requested fixes 3

514b03f

prrace reviewed Feb 11, 2024

View reviewed changes

Done requested fixes 4

47b2222

aivanov-jdk reviewed Feb 12, 2024

View reviewed changes

Done requested fixes 5

018b228

aivanov-jdk suggested changes Feb 13, 2024

View reviewed changes

prrace approved these changes Feb 13, 2024

View reviewed changes

Done requested fixes 6

e124a2d

aivanov-jdk approved these changes Feb 14, 2024

View reviewed changes

prrace approved these changes Feb 14, 2024

View reviewed changes

prsadhuk approved these changes Feb 19, 2024

View reviewed changes

openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 19, 2024

openjdk bot added the integrated Pull request has been integrated label Feb 19, 2024

openjdk bot closed this Feb 19, 2024

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 19, 2024

vtstydev deleted the Bugfix branch February 19, 2024 13:38

		@@ -0,0 +1,199 @@
		/*
		* Copyright (c) 2007, 2022, Oracle and/or its affiliates. All rights reserved.

	"1.Java print dialog should appear.\n" +
	"1. Java print dialog should appear.\n" +

	* Copyright (c) 1998, 2023, 2024, Oracle and/or its affiliates. All rights reserved.
	* Copyright (c) 1998, 2024, Oracle and/or its affiliates. All rights reserved.

		PassFailJFrame.builder().instructions(instructionsHeader + INSTRUCTIONS)
		.rows(15).testUI(() -> createTestUI()).build().awaitAndCheck();

8307246 : Printing: banded raster path doesn't account for device offset values #17030

8307246 : Printing: banded raster path doesn't account for device offset values #17030

Conversation

vtstydev commented Dec 8, 2023 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

Webrev

bridgekeeper bot commented Dec 8, 2023

openjdk bot commented Dec 8, 2023

mlbridge bot commented Dec 8, 2023 • edited Loading

Webrevs

prrace commented Dec 8, 2023

prrace commented Dec 8, 2023

vtstydev commented Dec 11, 2023

openjdk bot commented Dec 11, 2023

bridgekeeper bot commented Jan 8, 2024

vtstydev commented Jan 22, 2024

prrace commented Jan 23, 2024

openjdk bot commented Jan 25, 2024

prrace left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

prrace left a comment

Choose a reason for hiding this comment

openjdk bot commented Jan 29, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

prsadhuk commented Jan 30, 2024

prrace commented Feb 4, 2024

vtstydev commented Feb 5, 2024 • edited Loading

prrace commented Feb 9, 2024 • edited Loading

vtstydev commented Feb 9, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aivanov-jdk left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

prrace commented Feb 13, 2024

prsadhuk commented Feb 19, 2024

aivanov-jdk commented Feb 19, 2024

vtstydev commented Feb 19, 2024

openjdk bot commented Feb 19, 2024

aivanov-jdk commented Feb 19, 2024

openjdk bot commented Feb 19, 2024

openjdk bot commented Feb 19, 2024

vtstydev commented Dec 8, 2023 •

edited by openjdk bot

Loading

mlbridge bot commented Dec 8, 2023 •

edited

Loading

openjdk bot commented Jan 29, 2024 •

edited

Loading

vtstydev commented Feb 5, 2024 •

edited

Loading

prrace commented Feb 9, 2024 •

edited

Loading

aivanov-jdk left a comment •

edited

Loading