8187634: keystore.getCertificateAlias(cert) returns original alias, inconsistent with fix of JDK-6483657

[wangweij]

The alias in the keystore is mapEntry.getKey(). entry.getAlias() is the original friendly name, which is still useful when overwriting or removing an entry.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8187634: keystore.getCertificateAlias(cert) returns original alias, inconsistent with fix of JDK-6483657 (Bug - P4)

Reviewers

• Sean Mullan (@seanjmullan - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17037/head:pull/17037
$ git checkout pull/17037

Update a local copy of the PR:
$ git checkout pull/17037
$ git pull https://git.openjdk.org/jdk.git pull/17037/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17037

View PR using the GUI difftool:
$ git pr show -t 17037

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17037.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back weijun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@wangweij The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (85d3ed8e)

[openjdk]

@wangweij This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8187634: keystore.getCertificateAlias(cert) returns original alias, inconsistent with fix of JDK-6483657

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 125 new commits pushed to the master branch:

• 14dab31: 8322377: Parallel: Remove unused arg in adjust_promo_for_pause_time and adjust_eden_for_pause_time
• 5fcac7c: 8322364: Parallel: Remove unused SizePolicyTrueValues enum members
• 2f917bf: 8322417: Console read line with zero out should zero out when throwing exception
• 7db69e6: 8322513: Build failure with minimal
• f7dc257: 8322321: Add man page doc for -XX:+VerifySharedSpaces
• 97db670: 8321688: Build on linux with GCC 7.5.0 fails after 8319577
• 51be857: 8322166: Files.isReadable/isWritable/isExecutable expensive when file does not exist
• 0f8e4e0: 8311218: fatal error: stuck in JvmtiVTMSTransitionDisabler::VTMS_transition_disable
• 6313223: 8315856: RISC-V: Use Zacas extension for cmpxchg
• 3bc5679: 8322309: Fix an inconsistancy in spacing style in spec.gmk.template
• ... and 115 more: https://git.openjdk.org/jdk/compare/c42535f1110d60d1472080ad4fcadb8acbeb4c4b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[wangweij]

/integrate

[openjdk]

Going to push as commit 424c58f.
Since your change was applied there have been 125 commits pushed to the master branch:

• 14dab31: 8322377: Parallel: Remove unused arg in adjust_promo_for_pause_time and adjust_eden_for_pause_time
• 5fcac7c: 8322364: Parallel: Remove unused SizePolicyTrueValues enum members
• 2f917bf: 8322417: Console read line with zero out should zero out when throwing exception
• 7db69e6: 8322513: Build failure with minimal
• f7dc257: 8322321: Add man page doc for -XX:+VerifySharedSpaces
• 97db670: 8321688: Build on linux with GCC 7.5.0 fails after 8319577
• 51be857: 8322166: Files.isReadable/isWritable/isExecutable expensive when file does not exist
• 0f8e4e0: 8311218: fatal error: stuck in JvmtiVTMSTransitionDisabler::VTMS_transition_disable
• 6313223: 8315856: RISC-V: Use Zacas extension for cmpxchg
• 3bc5679: 8322309: Fix an inconsistancy in spacing style in spec.gmk.template
• ... and 115 more: https://git.openjdk.org/jdk/compare/c42535f1110d60d1472080ad4fcadb8acbeb4c4b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@wangweij Pushed as commit 424c58f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.