Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8321631: Fix comments in access.hpp #17042

Closed
wants to merge 1 commit into from

Conversation

lgxbslgx
Copy link
Member

@lgxbslgx lgxbslgx commented Dec 9, 2023

Hi all,

This trivial patch fixes the comments about atomic_xchg and atomic_xchg_at in access.hpp.
And it removes the unnecessary content about INSTANTIATE_HPP_ACCESS
which has been aleready removed in JDK-8230808.

Thanks for the review.

Best Regards,
-- Guoxiong


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8321631: Fix comments in access.hpp (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17042/head:pull/17042
$ git checkout pull/17042

Update a local copy of the PR:
$ git checkout pull/17042
$ git pull https://git.openjdk.org/jdk.git pull/17042/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17042

View PR using the GUI difftool:
$ git pr show -t 17042

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17042.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 9, 2023

👋 Welcome back gli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title JDK-8321631 8321631: Fix comments in access.hpp Dec 9, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 9, 2023
@openjdk
Copy link

openjdk bot commented Dec 9, 2023

@lgxbslgx The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Dec 9, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 9, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 9, 2023

@lgxbslgx This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8321631: Fix comments in access.hpp

Reviewed-by: eosterlund, stefank

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 3c6459e: 8321641: ClassFile ModuleAttribute.ModuleAttributeBuilder::moduleVersion spec contains a copy-paste error
  • 92fd490: 8321176: [Screencast] make a second attempt on screencast failure
  • d13302f: 8321387: SegmentAllocator:allocateFrom(AddressLayout, MemorySegment) does not throw stated UnsupportedOperationException

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 9, 2023
@lgxbslgx
Copy link
Member Author

@fisk @stefank Thanks for the reviews. Integrating.

/integrate

@openjdk
Copy link

openjdk bot commented Dec 12, 2023

Going to push as commit 973bcda.
Since your change was applied there have been 8 commits pushed to the master branch:

  • 6359b4e: 8318217: RISC-V: C2 VectorizedHashCode
  • ce4b257: 8320886: Unsafe_SetMemory0 is not guarded
  • b270f30: 8318629: G1: Refine code a bit in G1RemSetTrackingPolicy::update_at_allocate
  • 486594d: 8316657: Support whitebox testing in microbenchmarks
  • ce8399f: 8321582: yield .class not parsed correctly.
  • 3c6459e: 8321641: ClassFile ModuleAttribute.ModuleAttributeBuilder::moduleVersion spec contains a copy-paste error
  • 92fd490: 8321176: [Screencast] make a second attempt on screencast failure
  • d13302f: 8321387: SegmentAllocator:allocateFrom(AddressLayout, MemorySegment) does not throw stated UnsupportedOperationException

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 12, 2023
@openjdk openjdk bot closed this Dec 12, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 12, 2023
@openjdk
Copy link

openjdk bot commented Dec 12, 2023

@lgxbslgx Pushed as commit 973bcda.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@lgxbslgx lgxbslgx deleted the JDK-8321631 branch December 12, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants