8321713: Harmonize executeTestJvm with create[Limited]TestJavaProcessBuilder

[stefank]

JDK-8315097: 'Rename createJavaProcessBuilder' changed the name of the ProcessTools helper functions used to create ProcessBuilders used to spawn new java test processes.

We now have createTestJavaProcessBuilder and createLimitedTestJavaProcess. The former prepends jvm options from jtreg, while the latter doesn't.

With these functions it is common to see the following pattern in tests:

ProcessBuilder pb = ProcessTools.createTestJavaProcessBuilder(...);
OutputAnalyzer output = executeProcess(pb);

We have a couple of thin wrapper in ProcessTools that does exactly this, so that the code can be written as a one-liner:

OutputAnalyzer output = ProcessTools.executeTestJvm();

I propose that we name this functions using the same naming scheme we used for createTestJavaProcessBuilder and createLimitedTestJavaProcessBuilder. That is, we change executeTestJvm to executeTestJava and add a new executeLimitedTestJava function.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8321713: Harmonize executeTestJvm with create[Limited]TestJavaProcessBuilder (Enhancement - P4)

Reviewers

• Leo Korinth (@lkorinth - Reviewer)
• Leonid Mesnik (@lmesnik - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17049/head:pull/17049
$ git checkout pull/17049

Update a local copy of the PR:
$ git checkout pull/17049
$ git pull https://git.openjdk.org/jdk.git pull/17049/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17049

View PR using the GUI difftool:
$ git pr show -t 17049

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17049.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back stefank! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@stefank The following labels will be automatically applied to this pull request:

• core-libs
• hotspot
• i18n
• security
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 04: Full - Incremental (755d925d)
• 03: Full - Incremental (486dc6d5)
• 02: Full - Incremental (5d488f42)
• 01: Full - Incremental (ad072e06)
• 00: Full (080caef5)

[lkorinth]

Looks good to me.

[openjdk]

@stefank This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8321713: Harmonize executeTestJvm with create[Limited]TestJavaProcessBuilder

Reviewed-by: lkorinth, lmesnik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[stefank]

Thanks for the reviews!

[stefank]

/integrate

[openjdk]

Going to push as commit cbe329b.
Since your change was applied there has been 1 commit pushed to the master branch:

• 06dd735: 8322766: Micro bench SSLHandshake should use default algorithms

Your commit was automatically rebased without conflicts.

[openjdk]

@stefank Pushed as commit cbe329b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.