8257912: Convert enum iteration to use range-based for loops #1707
@iklam This change now passes all automated pre-integration checks.
ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.
After integration, the commit message for the final commit will be:
At the time when this comment was updated there had been 4 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the
➡️ To integrate this PR with the above commit message to the
I like the change very much.
Did you consider leaving the convenience symbol "vmSymbolsIterator" as is and then using it in the loop, so instead of:
we would have:
which would be more concise (but less self-documenting I guess) and more similar to:
Hi Gerard, thanks for the review.
which is probably less readable, because you have to find out what
I think the following pattern is easier to read. It will also make the iteration of different enum types more consistent. Iteration of any enum type E can be done the same way with EnumRange<E>. You don't need to invent a new ERange type.
Note that the
You can also initialize a non-default range with
@iklam Since your change was applied there have been 4 commits pushed to the
Your commit was automatically rebased without conflicts.
Pushed as commit 80dac5a.
💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.