Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8321825: Remove runtime/CompressedOops/CompressedClassPointers.java from the ProblemList #17075

Closed
wants to merge 1 commit into from

Conversation

dholmes-ora
Copy link
Member

@dholmes-ora dholmes-ora commented Dec 12, 2023

Please review this trivial update.

runtime/CompressedOops/CompressedClassPointers.java was added to the ProblemList against JDK-8317610 but that bug was closed as a duplicate of JDK-8318485 which is now resolved. The ProblemList entry needs to be removed and if the test continues to fail then a new issue filed.

Testing:

  • local testing of test (passed)
  • tiers 1-3 passed

Thanks


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8321825: Remove runtime/CompressedOops/CompressedClassPointers.java from the ProblemList (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17075/head:pull/17075
$ git checkout pull/17075

Update a local copy of the PR:
$ git checkout pull/17075
$ git pull https://git.openjdk.org/jdk.git pull/17075/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17075

View PR using the GUI difftool:
$ git pr show -t 17075

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17075.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 12, 2023

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 12, 2023
@openjdk
Copy link

openjdk bot commented Dec 12, 2023

@dholmes-ora To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@jaikiran
Copy link
Member

/label add hotspot-runtime

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Dec 12, 2023
@openjdk
Copy link

openjdk bot commented Dec 12, 2023

@jaikiran
The hotspot-runtime label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Dec 12, 2023

Webrevs

Copy link
Member

@calvinccheung calvinccheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial.

@openjdk
Copy link

openjdk bot commented Dec 12, 2023

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8321825: Remove runtime/CompressedOops/CompressedClassPointers.java from the ProblemList

Reviewed-by: ccheung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

  • a3447ec: 8321827: Remove unnecessary suppress warnings annotations from the printing processor
  • b25ed57: 8270269: Desktop.browse method fails if earlier CoInitialize call as COINIT_MULTITHREADED
  • df4ed7e: 8321739: Source launcher fails with "Not a directory" error
  • 5718039: 8321542: C2: Missing ChaCha20 stub for x86_32 leads to crashes
  • c516852: 8321889: JavaDoc method references with wrong (nested) type
  • 7d90396: 8321422: Test gc/g1/pinnedobjs/TestPinnedObjectTypes.java times out after completion
  • 6f48240: 8321729: Remove 'orb' field in RMIConnector
  • e1fd663: 8311306: Test com/sun/management/ThreadMXBean/ThreadCpuTimeArray.java failed: out of expected range
  • d5214a4: 8321814: G1: Remove unused G1RemSetScanState::_collection_set_iter_state
  • 2611a49: 8321287: Remove unused enum style in Prefetch
  • ... and 3 more: https://git.openjdk.org/jdk/compare/ce4b257fa539d35a7d14bba2d5d3342093d714e1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 12, 2023
@dholmes-ora
Copy link
Member Author

Thanks for adding the label @jaikiran ! I didn't notice this was an "orphan".

Thanks for the review @calvinccheung

/integrate

@openjdk
Copy link

openjdk bot commented Dec 12, 2023

Going to push as commit 3d9d353.
Since your change was applied there have been 19 commits pushed to the master branch:

  • 1b621f5: 8321474: TestAutoCreateSharedArchiveUpgrade.java should be updated with JDK 21
  • 5463c9c: 8321557: Move SOURCE line verification for OracleJDK out of OpenJDK
  • ac07355: 8320200: Use Elements predicates for record constructors to improve print output
  • 4fb5c12: 8321180: Condition for non-latin1 string size too large exception is off by one
  • d5a96e3: 8321621: Update JCov version to 3.0.16
  • aadf368: 6230751: [Fmt-Ch] Recursive MessageFormats in ChoiceFormats ignore indicated subformats
  • a3447ec: 8321827: Remove unnecessary suppress warnings annotations from the printing processor
  • b25ed57: 8270269: Desktop.browse method fails if earlier CoInitialize call as COINIT_MULTITHREADED
  • df4ed7e: 8321739: Source launcher fails with "Not a directory" error
  • 5718039: 8321542: C2: Missing ChaCha20 stub for x86_32 leads to crashes
  • ... and 9 more: https://git.openjdk.org/jdk/compare/ce4b257fa539d35a7d14bba2d5d3342093d714e1...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 12, 2023
@openjdk openjdk bot closed this Dec 12, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 12, 2023
@openjdk
Copy link

openjdk bot commented Dec 12, 2023

@dholmes-ora Pushed as commit 3d9d353.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dholmes-ora dholmes-ora deleted the 8321825-pl branch December 12, 2023 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants