Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8321739: Source launcher fails with "Not a directory" error #17076

Conversation

sormuras
Copy link
Member

@sormuras sormuras commented Dec 12, 2023

Please review this change to allow files sharing names with packages when using the Java source launcher.

The now used !Files.exists() returns a boolean value on Unix-based file systems instead of throwing an exception as Files.notExists() does when one or more elements of the tested path are files (and not directories), in addition of the the last element.

Tested: tier1


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8321739: Source launcher fails with "Not a directory" error (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17076/head:pull/17076
$ git checkout pull/17076

Update a local copy of the PR:
$ git checkout pull/17076
$ git pull https://git.openjdk.org/jdk.git pull/17076/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17076

View PR using the GUI difftool:
$ git pr show -t 17076

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17076.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 12, 2023

👋 Welcome back cstein! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 12, 2023

@sormuras The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the compiler compiler-dev@openjdk.org label Dec 12, 2023
@sormuras sormuras marked this pull request as ready for review December 12, 2023 15:14
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 12, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 12, 2023

Webrevs

Copy link
Contributor

@lahodaj lahodaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@openjdk
Copy link

openjdk bot commented Dec 12, 2023

@sormuras This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8321739: Source launcher fails with "Not a directory" error

Reviewed-by: jlahoda

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 5718039: 8321542: C2: Missing ChaCha20 stub for x86_32 leads to crashes
  • c516852: 8321889: JavaDoc method references with wrong (nested) type
  • 7d90396: 8321422: Test gc/g1/pinnedobjs/TestPinnedObjectTypes.java times out after completion
  • 6f48240: 8321729: Remove 'orb' field in RMIConnector
  • e1fd663: 8311306: Test com/sun/management/ThreadMXBean/ThreadCpuTimeArray.java failed: out of expected range
  • d5214a4: 8321814: G1: Remove unused G1RemSetScanState::_collection_set_iter_state
  • 2611a49: 8321287: Remove unused enum style in Prefetch

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 12, 2023
@sormuras
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 12, 2023

Going to push as commit df4ed7e.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 5718039: 8321542: C2: Missing ChaCha20 stub for x86_32 leads to crashes
  • c516852: 8321889: JavaDoc method references with wrong (nested) type
  • 7d90396: 8321422: Test gc/g1/pinnedobjs/TestPinnedObjectTypes.java times out after completion
  • 6f48240: 8321729: Remove 'orb' field in RMIConnector
  • e1fd663: 8311306: Test com/sun/management/ThreadMXBean/ThreadCpuTimeArray.java failed: out of expected range
  • d5214a4: 8321814: G1: Remove unused G1RemSetScanState::_collection_set_iter_state
  • 2611a49: 8321287: Remove unused enum style in Prefetch

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 12, 2023
@openjdk openjdk bot closed this Dec 12, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 12, 2023
@openjdk
Copy link

openjdk bot commented Dec 12, 2023

@sormuras Pushed as commit df4ed7e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sormuras
Copy link
Member Author

/backport jdk22

@openjdk
Copy link

openjdk bot commented Dec 12, 2023

@sormuras the backport was successfully created on the branch backport-sormuras-df4ed7ef in my personal fork of openjdk/jdk22. To create a pull request with this backport targeting openjdk/jdk22:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit df4ed7ef from the openjdk/jdk repository.

The commit being backported was authored by Christian Stein on 12 Dec 2023 and was reviewed by Jan Lahoda.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk22:

$ git fetch https://github.com/openjdk-bots/jdk22.git backport-sormuras-df4ed7ef:backport-sormuras-df4ed7ef
$ git checkout backport-sormuras-df4ed7ef
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk22.git backport-sormuras-df4ed7ef

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler compiler-dev@openjdk.org integrated Pull request has been integrated
2 participants