8321820: TestLoadNIdeal fails on 32-bit because -XX:+UseCompressedOops is not recognized

[dlunde]

This changeset fixes an issue where TestLoadNIdeal.java fails on 32-bit, where -XX:+UseCompressedOops is not available.

Changes:

• Only run the test on 64-bit platforms.

Testing

windows-x64, linux-x64, linux-aarch64, macosx-x64, macosx-aarch64:

• tier1, HotSpot parts of tier2 and tier3

linux-x86 (32-bit)

• tier1

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8321820: TestLoadNIdeal fails on 32-bit because -XX:+UseCompressedOops is not recognized (Bug - P4)

Reviewers

• Roberto Castañeda Lozano (@robcasloz - Reviewer)
• Christian Hagedorn (@chhagedorn - Reviewer)
• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17083/head:pull/17083
$ git checkout pull/17083

Update a local copy of the PR:
$ git checkout pull/17083
$ git pull https://git.openjdk.org/jdk.git pull/17083/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17083

View PR using the GUI difftool:
$ git pr show -t 17083

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17083.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dlunde! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dlunde The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (5f6c5e17)

[robcasloz]

Looks good.

[openjdk]

@dlunde This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8321820: TestLoadNIdeal fails on 32-bit because -XX:+UseCompressedOops is not recognized

Reviewed-by: rcastanedalo, chagedorn, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 34 new commits pushed to the master branch:

• ddbbd36: 8320279: Link issues in java.xml module-info.java
• c8ad7b7: 8321974: Crash in ciKlass::is_subtype_of because TypeAryPtr::_klass is not initialized
• cf94854: 8321565: [REDO] Heap dump does not contain virtual Thread stack references
• 7ece9e9: 8321400: java/foreign/TestStubAllocFailure.java fails with code cache exhaustion
• 9320ef9: 8321973: Parallel: Remove unused methods in AdaptiveSizePolicy
• 2a565ff: 8321808: G1: Use unsigned type for non-negative G1 flags
• 493b5bd: 8293622: Cleanup use of G1ConcRefinementThreads
• f573f6d: 8321515: ARM32: Move method resolution information out of the cpCache properly
• 8a0a6f8: 8321279: Implement hashCode() in Heap-X-Buffer.java.template
• 3d9d353: 8321825: Remove runtime/CompressedOops/CompressedClassPointers.java from the ProblemList
• ... and 24 more: https://git.openjdk.org/jdk/compare/92fd490f22f690ff7698182658363b7035bcc3bf...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@robcasloz, @chhagedorn, @shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[chhagedorn]

Looks good and trivial.

[dlunde]

Thanks for the reviews. Please sponsor!

/integrate

[openjdk]

@dlunde
Your change (at version 5f6c5e1) is now ready to be sponsored by a Committer.

[chhagedorn]

/sponsor

[openjdk]

Going to push as commit d632d74.
Since your change was applied there have been 34 commits pushed to the master branch:

• ddbbd36: 8320279: Link issues in java.xml module-info.java
• c8ad7b7: 8321974: Crash in ciKlass::is_subtype_of because TypeAryPtr::_klass is not initialized
• cf94854: 8321565: [REDO] Heap dump does not contain virtual Thread stack references
• 7ece9e9: 8321400: java/foreign/TestStubAllocFailure.java fails with code cache exhaustion
• 9320ef9: 8321973: Parallel: Remove unused methods in AdaptiveSizePolicy
• 2a565ff: 8321808: G1: Use unsigned type for non-negative G1 flags
• 493b5bd: 8293622: Cleanup use of G1ConcRefinementThreads
• f573f6d: 8321515: ARM32: Move method resolution information out of the cpCache properly
• 8a0a6f8: 8321279: Implement hashCode() in Heap-X-Buffer.java.template
• 3d9d353: 8321825: Remove runtime/CompressedOops/CompressedClassPointers.java from the ProblemList
• ... and 24 more: https://git.openjdk.org/jdk/compare/92fd490f22f690ff7698182658363b7035bcc3bf...master

Your commit was automatically rebased without conflicts.

[openjdk]

@chhagedorn @dlunde Pushed as commit d632d74.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.