8322057: Memory leaks in creating jfr symbol array

[zhengyu123]

A small fix to avoid memory leak when temporary c string is allocated in c heap.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8322057: Memory leaks in creating jfr symbol array (Bug - P3)

Reviewers

• Markus Grönlund (@mgronlun - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17099/head:pull/17099
$ git checkout pull/17099

Update a local copy of the PR:
$ git checkout pull/17099
$ git pull https://git.openjdk.org/jdk.git pull/17099/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17099

View PR using the GUI difftool:
$ git pr show -t 17099

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17099.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@zhengyu123 The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (70927730)

[mgronlun]

Thank you, Zhengyu!

[openjdk]

@zhengyu123 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322057: Memory leaks in creating jfr symbol array

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

• fde5b16: 8321514: UTF16 string gets constructed incorrectly from codepoints if CompactStrings is not enabled
• 45a9ade: 8202598: keytool -certreq output contains inconsistent line separators
• 62b7c5e: 8319647: Few java/lang/System/LoggerFinder/modules tests ignore vm flags
• 69014cd: 8320682: [AArch64] C1 compilation fails with "Field too big for insn"
• 5a97dbf: 8322034: Parallel: Remove unused methods in PSAdaptiveSizePolicy
• 2838a91: 8288989: Make tests not depend on the source code
• d2ba3b1: 8312150: Remove -Xnoagent option
• d632d74: 8321820: TestLoadNIdeal fails on 32-bit because -XX:+UseCompressedOops is not recognized
• ddbbd36: 8320279: Link issues in java.xml module-info.java
• c8ad7b7: 8321974: Crash in ciKlass::is_subtype_of because TypeAryPtr::_klass is not initialized

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[zhengyu123]

Thanks for the review, @mgronlun

[zhengyu123]

/integrate

[openjdk]

Going to push as commit a7dde57.
Since your change was applied there have been 14 commits pushed to the master branch:

• 692be57: 8322065: Initial nroff manpage generation for JDK 23
• d02bc87: 8309981: Remove expired flags in JDK 23
• 8b24851: 8321480: ISO 4217 Amendment 176 Update
• c328f95: 8296787: Unify debug printing format of X.509 cert serial numbers
• fde5b16: 8321514: UTF16 string gets constructed incorrectly from codepoints if CompactStrings is not enabled
• 45a9ade: 8202598: keytool -certreq output contains inconsistent line separators
• 62b7c5e: 8319647: Few java/lang/System/LoggerFinder/modules tests ignore vm flags
• 69014cd: 8320682: [AArch64] C1 compilation fails with "Field too big for insn"
• 5a97dbf: 8322034: Parallel: Remove unused methods in PSAdaptiveSizePolicy
• 2838a91: 8288989: Make tests not depend on the source code
• ... and 4 more: https://git.openjdk.org/jdk/compare/cf948548c390c42ca63525d41a9d63ff31349c3a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@zhengyu123 Pushed as commit a7dde57.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.