Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8257924: Use full path when running external executable from jpackage #1710

Closed
wants to merge 1 commit into from

Conversation

sashamatveev
Copy link
Member

@sashamatveev sashamatveev commented Dec 9, 2020

Changed all external executables to run via full path to avoid potential issues.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8257924: Use full path when running external executable from jpackage

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1710/head:pull/1710
$ git checkout pull/1710

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 9, 2020

👋 Welcome back almatvee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 9, 2020
@openjdk
Copy link

openjdk bot commented Dec 9, 2020

@sashamatveev The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Dec 9, 2020
@mlbridge
Copy link

mlbridge bot commented Dec 9, 2020

Webrevs

Copy link

@andyherrick andyherrick left a comment

as long as your sure these are always in /usr/bin this is fine.
If there is any chance of them being somewhere else instead we need a findTool type mechanism

@alexeysemenyukoracle
Copy link
Member

alexeysemenyukoracle commented Dec 9, 2020

What if users would like to use not the default tools with jpackage?

@sashamatveev
Copy link
Member Author

sashamatveev commented Dec 9, 2020

I did not found any information if it is possible for these tools to locate somewhere else. These tools a part of macOS, so I do not think that it is possible to use some non-default tools and I am not aware that such substitute tools even exist.

@openjdk
Copy link

openjdk bot commented Dec 10, 2020

@sashamatveev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257924: Use full path when running external executable from jpackage

Reviewed-by: herrick, asemenyuk

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 28 new commits pushed to the master branch:

  • 1ce2a36: 8257539: tools/jpackage/windows/WinL10nTest.java unpack.bat failed with Exit code: 1618
  • 53e537c: 8255387: Japanese characters were printed upside down on AIX
  • 0a3e446: 8257993: vmTestbase/nsk/jvmti/RedefineClasses/StressRedefine/TestDescription.java crash intermittently
  • 46c9a86: 8245956: JavaCompiler still uses File API instead of Path API in a specific case
  • baf4c1a: 8257917: [JVMCI] crash when materializing boxed values under -Xcomp
  • fd5f6e2: 8257986: [JVMCI] ProblemList 2 reprofile JVMCI tests
  • 30de320: 6882207: Convert javap to use diamond operator internally
  • d33a689: 8256867: Classes with empty PermittedSubclasses attribute cannot be extended
  • e6b4c4d: 8238781: [macos] jpackage tests failed due to "hdiutil: convert failed" in various ways
  • b977a7b: 8257989: Error in gtest os_page_size_for_region_unaligned after 8257588
  • ... and 18 more: https://git.openjdk.java.net/jdk/compare/b29f9cd7b073a8c5e514efda91aaf7115400a97f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 10, 2020
@sashamatveev
Copy link
Member Author

sashamatveev commented Dec 10, 2020

/integrate

@openjdk openjdk bot closed this Dec 10, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 10, 2020
@openjdk
Copy link

openjdk bot commented Dec 10, 2020

@sashamatveev Since your change was applied there have been 28 commits pushed to the master branch:

  • 1ce2a36: 8257539: tools/jpackage/windows/WinL10nTest.java unpack.bat failed with Exit code: 1618
  • 53e537c: 8255387: Japanese characters were printed upside down on AIX
  • 0a3e446: 8257993: vmTestbase/nsk/jvmti/RedefineClasses/StressRedefine/TestDescription.java crash intermittently
  • 46c9a86: 8245956: JavaCompiler still uses File API instead of Path API in a specific case
  • baf4c1a: 8257917: [JVMCI] crash when materializing boxed values under -Xcomp
  • fd5f6e2: 8257986: [JVMCI] ProblemList 2 reprofile JVMCI tests
  • 30de320: 6882207: Convert javap to use diamond operator internally
  • d33a689: 8256867: Classes with empty PermittedSubclasses attribute cannot be extended
  • e6b4c4d: 8238781: [macos] jpackage tests failed due to "hdiutil: convert failed" in various ways
  • b977a7b: 8257989: Error in gtest os_page_size_for_region_unaligned after 8257588
  • ... and 18 more: https://git.openjdk.java.net/jdk/compare/b29f9cd7b073a8c5e514efda91aaf7115400a97f...master

Your commit was automatically rebased without conflicts.

Pushed as commit eb1c8a1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants