8321479: java -D-D crashes

[calvinccheung]

A simple fix just removing an assert.
Also added a jtreg test.

Passed tier1 testing.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8321479: java -D-D crashes (Bug - P3)

Reviewers

• David Holmes (@dholmes-ora - Reviewer)
• Ioi Lam (@iklam - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17115/head:pull/17115
$ git checkout pull/17115

Update a local copy of the PR:
$ git checkout pull/17115
$ git pull https://git.openjdk.org/jdk.git pull/17115/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17115

View PR using the GUI difftool:
$ git pr show -t 17115

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17115.diff

Webrev

Link to Webrev Comment

[calvinccheung]

/label add hotspot-runtime

[bridgekeeper]

👋 Welcome back ccheung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@calvinccheung
The hotspot-runtime label was successfully added.

[mlbridge]

Webrevs

• 00: Full (df25bcfa)

[dholmes-ora]

Looks good.

Thanks

[openjdk]

@calvinccheung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8321479: java -D-D crashes

Reviewed-by: dholmes, iklam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 50 new commits pushed to the master branch:

• 87ef733: 8321958: @param/@return descriptions of ZoneRules#isDaylightSavings() are incorrect
• 05f7f0a: 8321288: [JVMCI] HotSpotJVMCIRuntime doesn't clean up WeakReferences in resolvedJavaTypes
• 6311dab: 8322018: Test java/lang/String/CompactString/MaxSizeUTF16String.java fails with -Xcomp
• bdebf19: 8322175: test/langtools/tools/javac/classreader/BadMethodParameter.java doesn't compile
• 20de541: 8322040: Missing array bounds check in ClassReader.parameter
• b31454e: 8322098: os::Linux::print_system_memory_info enhance the THP output with /sys/kernel/mm/transparent_hugepage/hpage_pmd_size
• 0be0775: 8320397: RISC-V: Avoid passing t0 as temp register to MacroAssembler:: cmpxchg_obj_header/cmpxchgptr
• 6dfb812: 8321823: Remove redundant PhaseGVN transform_no_reclaim
• a7dde57: 8322057: Memory leaks in creating jfr symbol array
• 692be57: 8322065: Initial nroff manpage generation for JDK 23
• ... and 40 more: https://git.openjdk.org/jdk/compare/ce4b257fa539d35a7d14bba2d5d3342093d714e1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[iklam]

LGTM

[calvinccheung]

Thanks @dholmes-ora @iklam for the reviews.

/integrate

[openjdk]

Going to push as commit dcdcd48.
Since your change was applied there have been 50 commits pushed to the master branch:

• 87ef733: 8321958: @param/@return descriptions of ZoneRules#isDaylightSavings() are incorrect
• 05f7f0a: 8321288: [JVMCI] HotSpotJVMCIRuntime doesn't clean up WeakReferences in resolvedJavaTypes
• 6311dab: 8322018: Test java/lang/String/CompactString/MaxSizeUTF16String.java fails with -Xcomp
• bdebf19: 8322175: test/langtools/tools/javac/classreader/BadMethodParameter.java doesn't compile
• 20de541: 8322040: Missing array bounds check in ClassReader.parameter
• b31454e: 8322098: os::Linux::print_system_memory_info enhance the THP output with /sys/kernel/mm/transparent_hugepage/hpage_pmd_size
• 0be0775: 8320397: RISC-V: Avoid passing t0 as temp register to MacroAssembler:: cmpxchg_obj_header/cmpxchgptr
• 6dfb812: 8321823: Remove redundant PhaseGVN transform_no_reclaim
• a7dde57: 8322057: Memory leaks in creating jfr symbol array
• 692be57: 8322065: Initial nroff manpage generation for JDK 23
• ... and 40 more: https://git.openjdk.org/jdk/compare/ce4b257fa539d35a7d14bba2d5d3342093d714e1...master

Your commit was automatically rebased without conflicts.

[openjdk]

@calvinccheung Pushed as commit dcdcd48.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[calvinccheung]

/backport jdk22

[openjdk]

@calvinccheung the backport was successfully created on the branch backport-calvinccheung-dcdcd48d in my personal fork of openjdk/jdk22. To create a pull request with this backport targeting openjdk/jdk22:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit dcdcd48d from the openjdk/jdk repository.

The commit being backported was authored by Calvin Cheung on 15 Dec 2023 and was reviewed by David Holmes and Ioi Lam.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk22:

$ git fetch https://github.com/openjdk-bots/jdk22.git backport-calvinccheung-dcdcd48d:backport-calvinccheung-dcdcd48d
$ git checkout backport-calvinccheung-dcdcd48d
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk22.git backport-calvinccheung-dcdcd48d

⚠️ @calvinccheung You are not yet a collaborator in my fork openjdk-bots/jdk22. An invite will be sent out and you need to accept it before you can proceed.