8322154: RISC-V: JDK-8315743 missed change in MacroAssembler::load_reserved

[zifeihan]

The fix for https://bugs.openjdk.org/browse/JDK-8315743 touches MacroAssembler::load_reserved replacing t0 with dst. But it missed change for the third case (that is uint32) of the switch in this assember function. We should also replace t0 used in zero_extend with dst. @robehn can you help confirm this?

• Run tier1 tests on qemu 8.1.50 with UseRVV (release)

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8322154: RISC-V: JDK-8315743 missed change in MacroAssembler::load_reserved (Bug - P3)

Reviewers

• Fei Yang (@RealFYang - Reviewer)
• Robbin Ehn (@robehn - Reviewer)
• Ludovic Henry (@luhenry - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17117/head:pull/17117
$ git checkout pull/17117

Update a local copy of the PR:
$ git checkout pull/17117
$ git pull https://git.openjdk.org/jdk.git pull/17117/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17117

View PR using the GUI difftool:
$ git pr show -t 17117

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17117.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back gcao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@zifeihan The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (42141182)

[RealFYang]

Good catch! I think we should also fix this for JDK-22.

[openjdk]

@zifeihan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322154: RISC-V: JDK-8315743 missed change in MacroAssembler::load_reserved

Reviewed-by: fyang, rehn, luhenry

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• 20de541: 8322040: Missing array bounds check in ClassReader.parameter
• b31454e: 8322098: os::Linux::print_system_memory_info enhance the THP output with /sys/kernel/mm/transparent_hugepage/hpage_pmd_size
• 0be0775: 8320397: RISC-V: Avoid passing t0 as temp register to MacroAssembler:: cmpxchg_obj_header/cmpxchgptr

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang, @robehn, @luhenry) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[robehn]

Good catch, thank you!

[zifeihan]

Thanks all for the review.
/integrate

[openjdk]

@zifeihan
Your change (at version 4214118) is now ready to be sponsored by a Committer.

[robehn]

I notice some of RV PRs goes a bit fast. Note https://openjdk.org/guide/ -> "Allow enough time for review".
Hence I can sponsor, but not now.

[robehn]

/sponsor

[openjdk]

Going to push as commit 59073fa.
Since your change was applied there have been 29 commits pushed to the master branch:

• 808a039: 8321815: Shenandoah: gc state should be synchronized to java threads only once per safepoint
• 459957f: 8322062: com/sun/jdi/JdwpAllowTest.java does not performs negative testing with prefix length
• b98d13f: 8259637: java.io.File.getCanonicalPath() returns different values for same path
• 4f3de09: 8321940: Improve CDSHeapVerifier in handling of interned strings
• 1fde8b8: 8321933: TestCDSVMCrash.java spawns two processes
• 66aeb89: 8315462: [REDO] runtime/NMT/SummarySanityCheck.java failed with "Total committed (MMMMMM) did not match the summarized committed (NNNNNN)"
• a5122d7: 8314029: Add file name parameter to Compiler.perfmap
• c0a3b76: 8316197: Make tracing of inline cache available in unified logging
• 7e1d26d: 8322287: Parallel: Remove unused arg in adjust_eden_for_pause_time and adjust_eden_for_minor_pause_time
• 5584ba3: 8322097: Serial: Refactor CardTableRS::find_first_clean_card
• ... and 19 more: https://git.openjdk.org/jdk/compare/6dfb8120c270a76fcba5a5c3c9ad91da3282d5fa...master

Your commit was automatically rebased without conflicts.

[openjdk]

@robehn @zifeihan Pushed as commit 59073fa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.