Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8257910: [JVMCI] Set exception_seen accordingly in the runtime. #1713

Closed

Conversation

mur47x111
Copy link
Contributor

@mur47x111 mur47x111 commented Dec 9, 2020

Update exception_seen flag in the MDO when no exception handler is found for caller during deoptimization, or when exception is thrown in the runtime.

Plus, -Xlog:exceptions=info code and AbortVMOnException are adjusted in C1 runtime and jvmci runtime to be consistent with C2, i.e., before JvmtiExport::can_post_on_exceptions deoptimization and fast continuation when compiled handler is found.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8257910: [JVMCI] Set exception_seen accordingly in the runtime.

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1713/head:pull/1713
$ git checkout pull/1713

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 9, 2020

👋 Welcome back yzheng! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 9, 2020
@openjdk
Copy link

openjdk bot commented Dec 9, 2020

@mur47x111 The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Dec 9, 2020
@mlbridge
Copy link

mlbridge bot commented Dec 9, 2020

Webrevs

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Unfortunately it missed JDK16 fork but because it is P3 bug it can be fixed there without approval for now (RDP1 phase).
Please, create PR based on https://github.com/openjdk/jdk16 (create your fork for it) and I will approve it. After push the fix will be auto-forwarded into JDK 17 (current https://github.com/openjdk/jdk)

@mur47x111
Copy link
Contributor Author

Thanks @vnkozlov ! Created openjdk/jdk16#2 and took the opportunity to squash commits.

@mur47x111 mur47x111 closed this Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org rfr Pull request is ready for review
2 participants