8322278: Generational ZGC: Adjust the comment of ZHeuristics::use_per_cpu_shared_small_pages

[lgxbslgx]

Hi all,

This trivial patch fixes the method ZHeuristics::use_per_cpu_shared_small_pages to meet its comment.

Thanks for the review.

Best Regards,
-- Guoxiong

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8322278: Generational ZGC: Adjust the comment of ZHeuristics::use_per_cpu_shared_small_pages (Enhancement - P5)

Reviewers

• Erik Österlund (@fisk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17138/head:pull/17138
$ git checkout pull/17138

Update a local copy of the PR:
$ git checkout pull/17138
$ git pull https://git.openjdk.org/jdk.git pull/17138/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17138

View PR using the GUI difftool:
$ git pr show -t 17138

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17138.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back gli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lgxbslgx The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (4106fbcc)
• 00: Full (85486e9d)

[kimbarrett]

This looks okay to me, but I don't really know this part of ZGC. So don't count me
as a reviewer.

[fisk]

Looks good.

[openjdk]

@lgxbslgx This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322278: Generational ZGC: Adjust the comment of ZHeuristics::use_per_cpu_shared_small_pages

Reviewed-by: eosterlund

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 60 new commits pushed to the master branch:

• 518ec97: 8322747: StringTable should be AllStatic
• 32d80e2: 8322772: Clean up code after JDK-8322417
• 19147f3: 8318158: RISC-V: implement roundD/roundF intrinsics
• 2a59243: 8322734: A redundant return in method padWithLen
• 4fc6b0f: 8068958: Timestamp.from(Instant) should throw when conversion is not possible
• 28c82bf: 8322661: Build broken due to missing jvmtiExport.hpp after JDK-8320139
• 7263e25: 8322490: cleanup CastNode construction
• f695ca5: 8321151: JDK-8294427 breaks Windows L&F on all older Windows versions
• 93fedc1: 8321802: (zipfs) Add validation of incorrect LOC signature in ZipFileSystem
• 1230853: 8322163: runtime/Unsafe/InternalErrorTest.java fails on Alpine after JDK-8320886
• ... and 50 more: https://git.openjdk.org/jdk/compare/34351b7a7950a3b563748f40f2619374f62f9b16...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[lgxbslgx]

@fisk @kimbarrett Thanks for your reviews. Do you think this patch is trivial? If not, I will wait for another review.

[fisk]

It looks trivial; ship it!

[lgxbslgx]

/integrate

[openjdk]

Going to push as commit 679f526.
Since your change was applied there have been 187 commits pushed to the master branch:

• 2e472fe: 8322294: Cleanup NativePostCallNop
• 88dafe5: 8314629: Generational ZGC: Clearing All SoftReferences log line lacks GCId
• 8d94799: 8322828: Parallel: Rename ParallelCompactData::_region_start
• 9847086: 8323499: Remove unused methods in space.hpp
• 4086176: 8322987: Remove gc/stress/gclocker/TestGCLocker* since they always fail with OOME
• 88378ed: 8277869: Maven POMs are using HTTP links where HTTPS is available
• 8569227: 8322589: Add Ideal transformation: (~a) & (~b) => ~(a | b)
• f4ca41a: 8322816: RISC-V: Incorrect guarantee in patch_vtype
• 376051a: 8320919: Clarify Locale related system properties
• a5071e0: 8322817: RISC-V: Eliminate -Wparentheses warnings in riscv code
• ... and 177 more: https://git.openjdk.org/jdk/compare/34351b7a7950a3b563748f40f2619374f62f9b16...master

Your commit was automatically rebased without conflicts.

[openjdk]

@lgxbslgx Pushed as commit 679f526.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.