Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8322279: Generational ZGC: Use ZFragmentationLimit and ZYoungCompactionLimit as percentage instead of multiples #17139

Closed
wants to merge 1 commit into from

Conversation

lgxbslgx
Copy link
Member

@lgxbslgx lgxbslgx commented Dec 18, 2023

Hi all,

This patch fixes ZHeuristics::significant_heap_overhead and ZHeuristics::significant_young_overhead to use ZFragmentationLimit and ZYoungCompactionLimit as percentages instead of multiples.

Thanks for the review.

Best Regards,
-- Guoxiong


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8322279: Generational ZGC: Use ZFragmentationLimit and ZYoungCompactionLimit as percentage instead of multiples (Bug - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17139/head:pull/17139
$ git checkout pull/17139

Update a local copy of the PR:
$ git checkout pull/17139
$ git pull https://git.openjdk.org/jdk.git pull/17139/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17139

View PR using the GUI difftool:
$ git pr show -t 17139

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17139.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 18, 2023

👋 Welcome back gli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title JDK-8322279 8322279: Generational ZGC: Use ZFragmentationLimit and ZYoungCompactionLimit as percentage instead of multiples Dec 18, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 18, 2023
@openjdk
Copy link

openjdk bot commented Dec 18, 2023

@lgxbslgx The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Dec 18, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 18, 2023

Webrevs

@lgxbslgx
Copy link
Member Author

lgxbslgx commented Jan 1, 2024

Ping for review. This patch is related to #17138. I would like to integrate these two patches at the same time.

Copy link
Contributor

@fisk fisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Jan 2, 2024

@lgxbslgx This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322279: Generational ZGC: Use ZFragmentationLimit and ZYoungCompactionLimit as percentage instead of multiples

Reviewed-by: eosterlund

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 252 new commits pushed to the master branch:

  • 922f8e4: 8323693: Update some copyright announcements in the new files created in 8234502
  • 1515bd7: 8322077: Add Ideal transformation: (~a) | (~b) => ~(a & b)
  • bdee968: 4760025: sRGB conversions to and from CIE XYZ incorrect
  • 71d9a83: 8323243: JNI invocation of an abstract instance method corrupts the stack
  • d83ea92: 8301466: [AIX] Revisit CommittedVirtualMemoryTest
  • 5cf7947: 8323562: SaslInputStream.read() may return wrong value
  • dc7d3b1: 8321489: Update LCMS to 2.16
  • 84cf4cb: 8318563: GetClassFields should not use random access to field
  • 9e9c05f: 8322979: Add informative discussion to Modifier
  • c54bca6: 8323617: Add missing null checks to GetMousePositionWithPopup.java test
  • ... and 242 more: https://git.openjdk.org/jdk/compare/34351b7a7950a3b563748f40f2619374f62f9b16...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 2, 2024
@lgxbslgx
Copy link
Member Author

lgxbslgx commented Jan 5, 2024

Waiting for another review.

@mmyxym
Copy link

mmyxym commented Jan 15, 2024

/backport jdk21u-dev

@openjdk
Copy link

openjdk bot commented Jan 15, 2024

@mmyxym Backport for repo openjdk/jdk21u-dev on branch master was successfully enabled and will be performed once this pull request has been integrated. Further instructions will be provided at that time.

@fisk
Copy link
Contributor

fisk commented Jan 15, 2024

@lgxbslgx the change looks trivial; please feel free to integrate with only my review.

@lgxbslgx
Copy link
Member Author

@lgxbslgx the change looks trivial; please feel free to integrate with only my review.

Thanks for the review and guide. Integrating.

/integrate

@openjdk
Copy link

openjdk bot commented Jan 15, 2024

Going to push as commit bf813be.
Since your change was applied there have been 264 commits pushed to the master branch:

  • c84c0ab: 8323637: Capture hotspot replay files in GHA
  • f368a0c: 8320328: Restore interrupted flag in ImageIcon.loadImage
  • a45b5b4: 8323722: Serial: Remove unused no_gc_in_progress
  • 7e0a4ed: 8323101: C2: assert(n->in(0) == nullptr) failed: divisions with zero check should already have bailed out earlier in split-if
  • 34f85ee: 8323584: AArch64: Unnecessary ResourceMark in NativeCall::set_destination_mt_safe
  • 62fd26f: 8323700: Add fontconfig requirement to building.md for Alpine Linux
  • 8c238ed: 8318707: Remove the Java Management Extension (JMX) Management Applet (m-let) feature
  • cd0fe37: 8323641: Test compiler/loopopts/superword/TestAlignVectorFuzzer.java timed out
  • 45c65e6: 8323577: C2 SuperWord: remove AlignVector restrictions on IR tests added in JDK-8305055
  • 8643cc2: 8323610: G1: HeapRegion pin count should be size_t to avoid overflows
  • ... and 254 more: https://git.openjdk.org/jdk/compare/34351b7a7950a3b563748f40f2619374f62f9b16...master

Your commit was automatically rebased without conflicts.

@openjdk
Copy link

openjdk bot commented Jan 15, 2024

Creating backport for repo openjdk/jdk21u-dev on branch master

/backport openjdk/jdk21u-dev master

@openjdk openjdk bot added integrated Pull request has been integrated and removed backport=openjdk/jdk21u-dev:master labels Jan 15, 2024
@openjdk openjdk bot closed this Jan 15, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 15, 2024
@openjdk
Copy link

openjdk bot commented Jan 15, 2024

@lgxbslgx Pushed as commit bf813be.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk
Copy link

openjdk bot commented Jan 15, 2024

@openjdk[bot] @mmyxym the backport was successfully created on the branch backport-mmyxym-bf813be0 in my personal fork of openjdk/jdk21u-dev. To create a pull request with this backport targeting openjdk/jdk21u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit bf813be0 from the openjdk/jdk repository.

The commit being backported was authored by Guoxiong Li on 15 Jan 2024 and was reviewed by Erik Österlund.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21u-dev:

$ git fetch https://github.com/openjdk-bots/jdk21u-dev.git backport-mmyxym-bf813be0:backport-mmyxym-bf813be0
$ git checkout backport-mmyxym-bf813be0
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk21u-dev.git backport-mmyxym-bf813be0

@lgxbslgx lgxbslgx deleted the percentage branch January 15, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
3 participants