8322321: Add man page doc for -XX:+VerifySharedSpaces #17152

iklam · 2023-12-19T06:19:15Z

VerifySharedSpaces was disabled in JDK-8221478 by default. We should add an entry in the "java" man page about the intended use for this flag.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8322321: Add man page doc for -XX:+VerifySharedSpaces (Enhancement - P4)

Reviewers

David Holmes (@dholmes-ora - Reviewer)
Calvin Cheung (@calvinccheung - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17152/head:pull/17152
$ git checkout pull/17152

Update a local copy of the PR:
$ git checkout pull/17152
$ git pull https://git.openjdk.org/jdk.git pull/17152/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17152

View PR using the GUI difftool:
$ git pr show -t 17152

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17152.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2023-12-19T06:20:29Z

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2023-12-19T06:21:04Z

@iklam To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels

build
client
compiler
core-libs
graal
hotspot
hotspot-compiler
hotspot-gc
hotspot-jfr
hotspot-runtime
i18n
ide-support
javadoc
jdk
jmx
kulla
net
nio
security
serviceability
shenandoah

iklam · 2023-12-19T07:56:46Z

/label hotspot

openjdk · 2023-12-19T07:57:10Z

@iklam
The hotspot label was successfully added.

mlbridge · 2023-12-19T08:00:00Z

Webrevs

dholmes-ora

Text is generally fine. A couple of typos need fixing.

dholmes-ora · 2023-12-19T22:17:05Z

src/java.base/share/man/java.1

@@ -1579,6 +1579,15 @@ Specifies the path and name of the class data sharing (CDS) archive file
 See \f[B]Application Class Data Sharing\f[R].
 .RE
 .TP
+\f[V]-XX:+VerifySharedSpaces\f[R]
+If this option is specified, the JVM will load a CDS archive file only
+if it passes an integrity check based on CRC32 checkums.


typo: checkums

dholmes-ora · 2023-12-19T22:17:41Z

src/java.base/share/man/java.1

+\f[V]-XX:+VerifySharedSpaces\f[R]
+If this option is specified, the JVM will load a CDS archive file only
+if it passes an integrity check based on CRC32 checkums.
+The purpose of this flag is to check for unintentional damages of CDS


s/damages of/damage to/

dholmes-ora · 2023-12-19T23:34:46Z

src/java.base/share/man/java.1

+\f[V]-XX:+VerifySharedSpaces\f[R]
+If this option is specified, the JVM will load a CDS archive file only
+if it passes an integrity check based on CRC32 checksums.
+The purpose of this flag is to check for unintentional damages to CDS


s/damages/damage/

dholmes-ora

Looks good.

Only one review needed for this doc change.

Thanks.

openjdk · 2023-12-20T00:54:03Z

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322321: Add man page doc for -XX:+VerifySharedSpaces

Reviewed-by: dholmes, ccheung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

51be857: 8322166: Files.isReadable/isWritable/isExecutable expensive when file does not exist
0f8e4e0: 8311218: fatal error: stuck in JvmtiVTMSTransitionDisabler::VTMS_transition_disable
6313223: 8315856: RISC-V: Use Zacas extension for cmpxchg
3bc5679: 8322309: Fix an inconsistancy in spacing style in spec.gmk.template
be49dab: 8321619: Generational ZGC: ZColorStoreGoodOopClosure is only valid for young objects
ac968c3: 8319451: PhaseIdealLoop::conditional_move is too conservative
0ad6c9e: 8322255: Generational ZGC: ZPageSizeMedium should be set before MaxTenuringThreshold
fff2e58: 8322195: RISC-V: Minor improvement of MD5 instrinsic
7b4d62c: 8322300: Remove redundant arg in PSAdaptiveSizePolicy::adjust_promo_for_pause_time
76637c5: 8321648: Integral gather optimized mask computation.
... and 1 more: https://git.openjdk.org/jdk/compare/808a03927c153581cbece93a4f5a4f8242b61ef5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

iklam · 2023-12-20T05:49:56Z

Thanks @dholmes-ora @calvinccheung for the review
/integrate

openjdk · 2023-12-20T05:50:46Z

Going to push as commit f7dc257.
Since your change was applied there have been 12 commits pushed to the master branch:

97db670: 8321688: Build on linux with GCC 7.5.0 fails after 8319577
51be857: 8322166: Files.isReadable/isWritable/isExecutable expensive when file does not exist
0f8e4e0: 8311218: fatal error: stuck in JvmtiVTMSTransitionDisabler::VTMS_transition_disable
6313223: 8315856: RISC-V: Use Zacas extension for cmpxchg
3bc5679: 8322309: Fix an inconsistancy in spacing style in spec.gmk.template
be49dab: 8321619: Generational ZGC: ZColorStoreGoodOopClosure is only valid for young objects
ac968c3: 8319451: PhaseIdealLoop::conditional_move is too conservative
0ad6c9e: 8322255: Generational ZGC: ZPageSizeMedium should be set before MaxTenuringThreshold
fff2e58: 8322195: RISC-V: Minor improvement of MD5 instrinsic
7b4d62c: 8322300: Remove redundant arg in PSAdaptiveSizePolicy::adjust_promo_for_pause_time
... and 2 more: https://git.openjdk.org/jdk/compare/808a03927c153581cbece93a4f5a4f8242b61ef5...master

Your commit was automatically rebased without conflicts.

openjdk · 2023-12-20T05:50:52Z

@iklam Pushed as commit f7dc257.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8322321: Add man page doc for -XX:+VerifySharedSpaces

011a799

openjdk bot added the rfr Pull request is ready for review label Dec 19, 2023

openjdk bot added the hotspot hotspot-dev@openjdk.org label Dec 19, 2023

dholmes-ora suggested changes Dec 19, 2023

View reviewed changes

@dholmes-ora review - fixed typos

c5a0288

dholmes-ora reviewed Dec 19, 2023

View reviewed changes

@dholmes-ora review #2 - fixed typos

ca07c36

dholmes-ora approved these changes Dec 20, 2023

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Dec 20, 2023

calvinccheung approved these changes Dec 20, 2023

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label Dec 20, 2023

openjdk bot closed this Dec 20, 2023

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 20, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8322321: Add man page doc for -XX:+VerifySharedSpaces #17152

8322321: Add man page doc for -XX:+VerifySharedSpaces #17152

iklam commented Dec 19, 2023 •

edited by openjdk bot

Loading

bridgekeeper bot commented Dec 19, 2023

openjdk bot commented Dec 19, 2023

iklam commented Dec 19, 2023

openjdk bot commented Dec 19, 2023

mlbridge bot commented Dec 19, 2023 •

edited

Loading

dholmes-ora left a comment

dholmes-ora Dec 19, 2023

dholmes-ora Dec 19, 2023

dholmes-ora Dec 19, 2023

dholmes-ora left a comment

openjdk bot commented Dec 20, 2023 •

edited

Loading

iklam commented Dec 20, 2023

openjdk bot commented Dec 20, 2023

openjdk bot commented Dec 20, 2023

8322321: Add man page doc for -XX:+VerifySharedSpaces #17152

8322321: Add man page doc for -XX:+VerifySharedSpaces #17152

Conversation

iklam commented Dec 19, 2023 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

Webrev

bridgekeeper bot commented Dec 19, 2023

openjdk bot commented Dec 19, 2023

iklam commented Dec 19, 2023

openjdk bot commented Dec 19, 2023

mlbridge bot commented Dec 19, 2023 • edited Loading

Webrevs

dholmes-ora left a comment

Choose a reason for hiding this comment

dholmes-ora Dec 19, 2023

Choose a reason for hiding this comment

dholmes-ora Dec 19, 2023

Choose a reason for hiding this comment

dholmes-ora Dec 19, 2023

Choose a reason for hiding this comment

dholmes-ora left a comment

Choose a reason for hiding this comment

openjdk bot commented Dec 20, 2023 • edited Loading

iklam commented Dec 20, 2023

openjdk bot commented Dec 20, 2023

openjdk bot commented Dec 20, 2023

iklam commented Dec 19, 2023 •

edited by openjdk bot

Loading

mlbridge bot commented Dec 19, 2023 •

edited

Loading

openjdk bot commented Dec 20, 2023 •

edited

Loading