-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8322418: Problem list gc/TestAllocHumongousFragment.java subtests for 8298781 #17157
Conversation
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
@GoeLin To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we see a couple of failures as well in
gc/TestAllocHumongousFragment.java#static
should those be addressed too in this change ?
@GoeLin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 14 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
I had to change this once more. |
/integrate |
Going to push as commit 6de23bf.
Your commit was automatically rebased without conflicts. |
We see these in the 21u-dev CI about every fifth run.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17157/head:pull/17157
$ git checkout pull/17157
Update a local copy of the PR:
$ git checkout pull/17157
$ git pull https://git.openjdk.org/jdk.git pull/17157/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 17157
View PR using the GUI difftool:
$ git pr show -t 17157
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17157.diff