Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8322418: Problem list gc/TestAllocHumongousFragment.java subtests for 8298781 #17157

Closed
wants to merge 3 commits into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Dec 19, 2023

We see these in the 21u-dev CI about every fifth run.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8322418: Problem list gc/TestAllocHumongousFragment.java subtests for 8298781 (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17157/head:pull/17157
$ git checkout pull/17157

Update a local copy of the PR:
$ git checkout pull/17157
$ git pull https://git.openjdk.org/jdk.git pull/17157/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17157

View PR using the GUI difftool:
$ git pr show -t 17157

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17157.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 19, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 19, 2023
@openjdk
Copy link

openjdk bot commented Dec 19, 2023

@GoeLin To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

Copy link
Member

@MBaesken MBaesken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we see a couple of failures as well in
gc/TestAllocHumongousFragment.java#static
should those be addressed too in this change ?

@openjdk
Copy link

openjdk bot commented Dec 19, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322418: Problem list gc/TestAllocHumongousFragment.java subtests for 8298781

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

  • 2d60955: 8322141: SequenceInputStream.transferTo should not return as soon as Long.MAX_VALUE bytes have been transferred
  • e0bad51: 8322543: Parallel: Remove unused _major_pause_old_slope_counter
  • 424c58f: 8187634: keystore.getCertificateAlias(cert) returns original alias, inconsistent with fix of JDK-6483657
  • 14dab31: 8322377: Parallel: Remove unused arg in adjust_promo_for_pause_time and adjust_eden_for_pause_time
  • 5fcac7c: 8322364: Parallel: Remove unused SizePolicyTrueValues enum members
  • 2f917bf: 8322417: Console read line with zero out should zero out when throwing exception
  • 7db69e6: 8322513: Build failure with minimal
  • f7dc257: 8322321: Add man page doc for -XX:+VerifySharedSpaces
  • 97db670: 8321688: Build on linux with GCC 7.5.0 fails after 8319577
  • 51be857: 8322166: Files.isReadable/isWritable/isExecutable expensive when file does not exist
  • ... and 4 more: https://git.openjdk.org/jdk/compare/ac968c36d7cc2e13270d28c9310178f6b654d7dc...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 19, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Dec 20, 2023

I had to change this once more.
Just naming the file does not work ... I had assumed it would exclude all subtests.

@GoeLin
Copy link
Member Author

GoeLin commented Dec 21, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Dec 21, 2023

Going to push as commit 6de23bf.
Since your change was applied there have been 19 commits pushed to the master branch:

  • aff659a: 8322538: remove fatal from JVM_VirtualThread functions for !INCLUDE_JVMTI
  • 05745e3: 8319548: Unexpected internal name for Filler array klass causes error in VisualVM
  • e8768ae: 8321972: test runtime/Unsafe/InternalErrorTest.java timeout on linux-riscv64 platform
  • f6fe39f: 8322078: ZipSourceCache.testKeySourceMapping() test fails with The process cannot access the file because it is being used by another process
  • e204242: 8321017: Record in JFR that IEEE rounding mode was corrupted by loading a library
  • 2d60955: 8322141: SequenceInputStream.transferTo should not return as soon as Long.MAX_VALUE bytes have been transferred
  • e0bad51: 8322543: Parallel: Remove unused _major_pause_old_slope_counter
  • 424c58f: 8187634: keystore.getCertificateAlias(cert) returns original alias, inconsistent with fix of JDK-6483657
  • 14dab31: 8322377: Parallel: Remove unused arg in adjust_promo_for_pause_time and adjust_eden_for_pause_time
  • 5fcac7c: 8322364: Parallel: Remove unused SizePolicyTrueValues enum members
  • ... and 9 more: https://git.openjdk.org/jdk/compare/ac968c36d7cc2e13270d28c9310178f6b654d7dc...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 21, 2023
@openjdk openjdk bot closed this Dec 21, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 21, 2023
@openjdk
Copy link

openjdk bot commented Dec 21, 2023

@GoeLin Pushed as commit 6de23bf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_8322418 branch December 21, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants