8322513: Build failure with minimal

[xpbob]

Build failure with minimal

sh configure --with-jvm-variants=minimal 

=== Output from failing command(s) repeated here ===
* For target hotspot_variant-minimal_libjvm_objs_handshake.o:
/src/hotspot/share/runtime/handshake.cpp: In member function 'HandshakeOperation* HandshakeState::get_op_for_self(bool, bool)':
src/hotspot/share/runtime/handshake.cpp:490:37: error: 'class JavaThread' has no member named 'is_disable_suspend'; did you mean 'is_trace_suspend'?
   if (allow_suspend && _handshakee->is_disable_suspend()) {
                                     ^~~~~~~~~~~~~~~~~~
                                     is_trace_suspend

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8322513: Build failure with minimal (Bug - P4)

Reviewers

• David Holmes (@dholmes-ora - Reviewer)
• Robbin Ehn (@robehn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17164/head:pull/17164
$ git checkout pull/17164

Update a local copy of the PR:
$ git checkout pull/17164
$ git pull https://git.openjdk.org/jdk.git pull/17164/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17164

View PR using the GUI difftool:
$ git pr show -t 17164

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17164.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back xpbob! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@xpbob The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (11feb673)

[dholmes-ora]

Looks fine and trivial.

Thanks

[openjdk]

@xpbob This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322513: Build failure with minimal

Reviewed-by: dholmes, rehn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• f7dc257: 8322321: Add man page doc for -XX:+VerifySharedSpaces
• 97db670: 8321688: Build on linux with GCC 7.5.0 fails after 8319577

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dholmes-ora, @robehn) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[dholmes-ora]

But I think you will then run into further problems due to JDK-8311218 - there is a "fatal" in jvm.cpp that will be called when JVM TI is not available.

[robehn]

Thanks, yes please ship now under trivial.

I have the same fix locally it working fine.

[xpbob]

@dholmes-ora @robehn
Thanks for the review

[xpbob]

/integrate

[robehn]

@dholmes-ora, minimal is used when you cross-compile, you need to build a minimal native buildjdk.
This do not yet use "Loom", but if/when folks start using virtual thread in core libs, we can get into problems it seems like.

Talking about the other issue: 8311218

[openjdk]

@xpbob
Your change (at version 11feb67) is now ready to be sponsored by a Committer.

[DamonFool]

/sponsor

[openjdk]

Going to push as commit 7db69e6.
Since your change was applied there have been 2 commits pushed to the master branch:

• f7dc257: 8322321: Add man page doc for -XX:+VerifySharedSpaces
• 97db670: 8321688: Build on linux with GCC 7.5.0 fails after 8319577

Your commit was automatically rebased without conflicts.

[openjdk]

@DamonFool @xpbob Pushed as commit 7db69e6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[dholmes-ora]

@robehn I didn't realize Loom support was conditional. In any case the fatal is still wrong.

[robehn]

@robehn I didn't realize Loom support was conditional. In any case the fatal is still wrong.

Sorry, I just mean the bug you found in 8311218 would probably gone unnoticed for very long (at least for us).

[dholmes-ora]

/backport jdk22

[openjdk]

@dholmes-ora the backport was successfully created on the branch backport-dholmes-ora-7db69e6a in my personal fork of openjdk/jdk22. To create a pull request with this backport targeting openjdk/jdk22:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 7db69e6a from the openjdk/jdk repository.

The commit being backported was authored by bobpengxie on 20 Dec 2023 and was reviewed by David Holmes and Robbin Ehn.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk22:

$ git fetch https://github.com/openjdk-bots/jdk22.git backport-dholmes-ora-7db69e6a:backport-dholmes-ora-7db69e6a
$ git checkout backport-dholmes-ora-7db69e6a
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk22.git backport-dholmes-ora-7db69e6a