8257993: vmTestbase/nsk/jvmti/RedefineClasses/StressRedefine/TestDescription.java crash intermittently

[coleenp]

This change handles redefinition during method resolution, by returning the new method. It's not needed to reresolve the invocation. See the bug for more information.

Tested with tier1-3 and tier8 on linux-x64-debug and macos-x64-debug, and running the failing tests 100x without failure. Thank you to Serguei for confirming the testing.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8257993: vmTestbase/nsk/jvmti/RedefineClasses/StressRedefine/TestDescription.java crash intermittently

Reviewers

• Serguei Spitsyn (@sspitsyn - Reviewer)
• Harold Seigel (@hseigel - Reviewer)
• David Holmes (@dholmes-ora - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1717/head:pull/1717
$ git checkout pull/1717

[bridgekeeper]

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coleenp The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[coleenp]

/label add serviceability-dev

[openjdk]

@coleenp
The serviceability label was successfully added.

[mlbridge]

Webrevs

• 00: Full (77c0435)

[sspitsyn]

Hi Coleen,
I like this fix and looks good.
Thanks,
Serguei

[openjdk]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257993: vmTestbase/nsk/jvmti/RedefineClasses/StressRedefine/TestDescription.java crash intermittently

Reviewed-by: sspitsyn, hseigel, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 36 new commits pushed to the master branch:

• 46c9a86: 8245956: JavaCompiler still uses File API instead of Path API in a specific case
• baf4c1a: 8257917: [JVMCI] crash when materializing boxed values under -Xcomp
• fd5f6e2: 8257986: [JVMCI] ProblemList 2 reprofile JVMCI tests
• 30de320: 6882207: Convert javap to use diamond operator internally
• d33a689: 8256867: Classes with empty PermittedSubclasses attribute cannot be extended
• e6b4c4d: 8238781: [macos] jpackage tests failed due to "hdiutil: convert failed" in various ways
• b977a7b: 8257989: Error in gtest os_page_size_for_region_unaligned after 8257588
• 5f03341: 8052260: Reference.isEnqueued() spec does not match the long-standing behavior returning true iff it's in the ref queue
• 6dd06ad: 8254996: make jdk.net.UnixDomainPrincipal a record class
• bd22aa5: 8229862: NPE in jdk.compiler/com.sun.tools.javac.jvm.Code.emitop0(Code.java:570)
• ... and 26 more: https://git.openjdk.java.net/jdk/compare/d0c526513d7d82c2a4bb9ef72656cc35de8452e9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[coleenp]

Thanks Serguei for the fast review and discussion about this bug.

[hseigel]

The changes look good!

[coleenp]

Thank you Harold!

[dholmes-ora]

Looks good.
Thanks,
David

[coleenp]

Thanks David.

/integrate

[openjdk]

@coleenp Since your change was applied there have been 36 commits pushed to the master branch:

• 46c9a86: 8245956: JavaCompiler still uses File API instead of Path API in a specific case
• baf4c1a: 8257917: [JVMCI] crash when materializing boxed values under -Xcomp
• fd5f6e2: 8257986: [JVMCI] ProblemList 2 reprofile JVMCI tests
• 30de320: 6882207: Convert javap to use diamond operator internally
• d33a689: 8256867: Classes with empty PermittedSubclasses attribute cannot be extended
• e6b4c4d: 8238781: [macos] jpackage tests failed due to "hdiutil: convert failed" in various ways
• b977a7b: 8257989: Error in gtest os_page_size_for_region_unaligned after 8257588
• 5f03341: 8052260: Reference.isEnqueued() spec does not match the long-standing behavior returning true iff it's in the ref queue
• 6dd06ad: 8254996: make jdk.net.UnixDomainPrincipal a record class
• bd22aa5: 8229862: NPE in jdk.compiler/com.sun.tools.javac.jvm.Code.emitop0(Code.java:570)
• ... and 26 more: https://git.openjdk.java.net/jdk/compare/d0c526513d7d82c2a4bb9ef72656cc35de8452e9...master

Your commit was automatically rebased without conflicts.

Pushed as commit 0a3e446.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.