JDK-8322512 StringBuffer.repeat does not work correctly after toString() was called #17172

JimLaskey · 2023-12-20T20:25:07Z

The new repeat methods were not clearing the toStringCache.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8322512: StringBuffer.repeat does not work correctly after toString() was called (Bug - P3)

Reviewers

@mkarg (no known openjdk.org user name / role) ⚠️ Review applies to 33dd7973
Roger Riggs (@RogerRiggs - Reviewer) ⚠️ Review applies to 33dd7973
Jaikiran Pai (@jaikiran - Reviewer) ⚠️ Review applies to 33dd7973

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17172/head:pull/17172
$ git checkout pull/17172

Update a local copy of the PR:
$ git checkout pull/17172
$ git pull https://git.openjdk.org/jdk.git pull/17172/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17172

View PR using the GUI difftool:
$ git pr show -t 17172

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17172.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2023-12-20T20:26:43Z

👋 Welcome back jlaskey! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2023-12-20T20:27:22Z

@JimLaskey The following label will be automatically applied to this pull request:

core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2023-12-20T20:29:52Z

Webrevs

src/java.base/share/classes/java/lang/StringBuffer.java

mkarg

LGTM.

RogerRiggs

LGTM

openjdk · 2023-12-20T22:15:01Z

@JimLaskey This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322512: StringBuffer.repeat does not work correctly after toString() was called

Reviewed-by: rriggs, jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

jaikiran · 2023-12-21T07:55:50Z

test/jdk/java/lang/StringBuilder/StringBufferRepeat.java

+        sb.toString();
+        sb.repeat('*', 5);
+        expected = "*****";
+        assertEquals(expected, sb.toString());


Hello Jim, just a minor detail - in case of testng's Assert.assertEquals() the first param is the actual and the second is the expected. Some other existing usages of this method in this test also have the incorrect order.

jaikiran

The changes look good to me. I just have a minor comment about the assertEquals usage which I've added inline.

JimLaskey · 2024-01-04T12:45:39Z

/integrate

openjdk · 2024-01-04T12:46:33Z

Going to push as commit df22fb3.

openjdk · 2024-01-04T12:46:39Z

@JimLaskey Pushed as commit df22fb3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

JimLaskey · 2024-01-04T12:57:55Z

/backport jdk21

openjdk · 2024-01-04T12:58:18Z

@JimLaskey The target repository jdk21 is not a valid target for backports.
List of valid target repositories: openjdk/jdk, openjdk/jdk11u, openjdk/jdk11u-dev, openjdk/jdk17u, openjdk/jdk17u-dev, openjdk/jdk21u, openjdk/jdk21u-dev, openjdk/jdk22, openjdk/jdk22u, openjdk/jdk7u, openjdk/jdk8u, openjdk/jdk8u-dev, openjdk/jfx, openjdk/jfx21u, openjdk/lilliput-jdk17u, openjdk/lilliput-jdk21u, openjdk/shenandoah-jdk21u, openjdk/shenandoah-jdk8u.
Supplying the organization/group prefix is optional.

JimLaskey · 2024-01-04T13:01:38Z

/backport jdk21u

openjdk · 2024-01-04T13:03:44Z

@JimLaskey the backport was successfully created on the branch backport-JimLaskey-df22fb32 in my personal fork of openjdk/jdk21u. To create a pull request with this backport targeting openjdk/jdk21u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit df22fb32 from the openjdk/jdk repository.

The commit being backported was authored by Jim Laskey on 4 Jan 2024 and was reviewed by Roger Riggs and Jaikiran Pai.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21u:

$ git fetch https://github.com/openjdk-bots/jdk21u.git backport-JimLaskey-df22fb32:backport-JimLaskey-df22fb32
$ git checkout backport-JimLaskey-df22fb32
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk21u.git backport-JimLaskey-df22fb32

JimLaskey · 2024-01-04T16:15:07Z

/backport jdk22

openjdk · 2024-01-04T16:17:24Z

@JimLaskey the backport was successfully created on the branch backport-JimLaskey-df22fb32 in my personal fork of openjdk/jdk22. To create a pull request with this backport targeting openjdk/jdk22:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit df22fb32 from the openjdk/jdk repository.

The commit being backported was authored by Jim Laskey on 4 Jan 2024 and was reviewed by Roger Riggs and Jaikiran Pai.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk22:

$ git fetch https://github.com/openjdk-bots/jdk22.git backport-JimLaskey-df22fb32:backport-JimLaskey-df22fb32
$ git checkout backport-JimLaskey-df22fb32
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk22.git backport-JimLaskey-df22fb32

JimLaskey · 2024-01-08T13:38:46Z

/backport jdk22u

openjdk · 2024-01-08T13:40:47Z

@JimLaskey the backport was successfully created on the branch backport-JimLaskey-df22fb32 in my personal fork of openjdk/jdk22u. To create a pull request with this backport targeting openjdk/jdk22u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit df22fb32 from the openjdk/jdk repository.

The commit being backported was authored by Jim Laskey on 4 Jan 2024 and was reviewed by Roger Riggs and Jaikiran Pai.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk22u:

$ git fetch https://github.com/openjdk-bots/jdk22u.git backport-JimLaskey-df22fb32:backport-JimLaskey-df22fb32
$ git checkout backport-JimLaskey-df22fb32
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk22u.git backport-JimLaskey-df22fb32

Clear toStringCache when calling StringBuffer::repeat

82b7e34

openjdk bot added the rfr Pull request is ready for review label Dec 20, 2023

openjdk bot added the core-libs core-libs-dev@openjdk.org label Dec 20, 2023

RogerRiggs reviewed Dec 20, 2023

View reviewed changes

src/java.base/share/classes/java/lang/StringBuffer.java Show resolved Hide resolved

src/java.base/share/classes/java/lang/StringBuffer.java Show resolved Hide resolved

Clear sooner

66eb7f7

mkarg approved these changes Dec 20, 2023

View reviewed changes

RogerRiggs approved these changes Dec 20, 2023

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Dec 20, 2023

jaikiran reviewed Dec 21, 2023

View reviewed changes

jaikiran approved these changes Dec 21, 2023

View reviewed changes

JimLaskey added 2 commits January 4, 2024 08:24

Merge remote-tracking branch 'upstream/master' into 8322512

33dd797

Nit in test

ec72e77

openjdk bot added the integrated Pull request has been integrated label Jan 4, 2024

openjdk bot closed this Jan 4, 2024

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

JDK-8322512 StringBuffer.repeat does not work correctly after toString() was called #17172

JDK-8322512 StringBuffer.repeat does not work correctly after toString() was called #17172

JimLaskey commented Dec 20, 2023 •

edited by openjdk bot

Loading

bridgekeeper bot commented Dec 20, 2023

openjdk bot commented Dec 20, 2023

mlbridge bot commented Dec 20, 2023 •

edited

Loading

mkarg left a comment

RogerRiggs left a comment

openjdk bot commented Dec 20, 2023 •

edited

Loading

jaikiran Dec 21, 2023

JimLaskey Jan 4, 2024

jaikiran left a comment

JimLaskey commented Jan 4, 2024

openjdk bot commented Jan 4, 2024

openjdk bot commented Jan 4, 2024

JimLaskey commented Jan 4, 2024

openjdk bot commented Jan 4, 2024

JimLaskey commented Jan 4, 2024

openjdk bot commented Jan 4, 2024

JimLaskey commented Jan 4, 2024

openjdk bot commented Jan 4, 2024

JimLaskey commented Jan 8, 2024

openjdk bot commented Jan 8, 2024

JDK-8322512 StringBuffer.repeat does not work correctly after toString() was called #17172

JDK-8322512 StringBuffer.repeat does not work correctly after toString() was called #17172

Conversation

JimLaskey commented Dec 20, 2023 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

Webrev

bridgekeeper bot commented Dec 20, 2023

openjdk bot commented Dec 20, 2023

mlbridge bot commented Dec 20, 2023 • edited Loading

Webrevs

mkarg left a comment

Choose a reason for hiding this comment

RogerRiggs left a comment

Choose a reason for hiding this comment

openjdk bot commented Dec 20, 2023 • edited Loading

jaikiran Dec 21, 2023

Choose a reason for hiding this comment

JimLaskey Jan 4, 2024

Choose a reason for hiding this comment

jaikiran left a comment

Choose a reason for hiding this comment

JimLaskey commented Jan 4, 2024

openjdk bot commented Jan 4, 2024

openjdk bot commented Jan 4, 2024

JimLaskey commented Jan 4, 2024

openjdk bot commented Jan 4, 2024

JimLaskey commented Jan 4, 2024

openjdk bot commented Jan 4, 2024

JimLaskey commented Jan 4, 2024

openjdk bot commented Jan 4, 2024

JimLaskey commented Jan 8, 2024

openjdk bot commented Jan 8, 2024

JimLaskey commented Dec 20, 2023 •

edited by openjdk bot

Loading

mlbridge bot commented Dec 20, 2023 •

edited

Loading

openjdk bot commented Dec 20, 2023 •

edited

Loading