Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8322512 StringBuffer.repeat does not work correctly after toString() was called #17172

Closed
wants to merge 4 commits into from

Conversation

JimLaskey
Copy link
Member

@JimLaskey JimLaskey commented Dec 20, 2023

The new repeat methods were not clearing the toStringCache.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8322512: StringBuffer.repeat does not work correctly after toString() was called (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17172/head:pull/17172
$ git checkout pull/17172

Update a local copy of the PR:
$ git checkout pull/17172
$ git pull https://git.openjdk.org/jdk.git pull/17172/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17172

View PR using the GUI difftool:
$ git pr show -t 17172

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17172.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 20, 2023

👋 Welcome back jlaskey! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 20, 2023
@openjdk
Copy link

openjdk bot commented Dec 20, 2023

@JimLaskey The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Dec 20, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 20, 2023

Webrevs

Copy link
Contributor

@mkarg mkarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@RogerRiggs RogerRiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented Dec 20, 2023

@JimLaskey This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322512: StringBuffer.repeat does not work correctly after toString() was called

Reviewed-by: rriggs, jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 20, 2023
sb.toString();
sb.repeat('*', 5);
expected = "*****";
assertEquals(expected, sb.toString());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Jim, just a minor detail - in case of testng's Assert.assertEquals() the first param is the actual and the second is the expected. Some other existing usages of this method in this test also have the incorrect order.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

Copy link
Member

@jaikiran jaikiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. I just have a minor comment about the assertEquals usage which I've added inline.

@JimLaskey
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 4, 2024

Going to push as commit df22fb3.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 4, 2024
@openjdk openjdk bot closed this Jan 4, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 4, 2024
@openjdk
Copy link

openjdk bot commented Jan 4, 2024

@JimLaskey Pushed as commit df22fb3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@JimLaskey
Copy link
Member Author

/backport jdk21

@openjdk
Copy link

openjdk bot commented Jan 4, 2024

@JimLaskey The target repository jdk21 is not a valid target for backports.
List of valid target repositories: openjdk/jdk, openjdk/jdk11u, openjdk/jdk11u-dev, openjdk/jdk17u, openjdk/jdk17u-dev, openjdk/jdk21u, openjdk/jdk21u-dev, openjdk/jdk22, openjdk/jdk22u, openjdk/jdk7u, openjdk/jdk8u, openjdk/jdk8u-dev, openjdk/jfx, openjdk/jfx21u, openjdk/lilliput-jdk17u, openjdk/lilliput-jdk21u, openjdk/shenandoah-jdk21u, openjdk/shenandoah-jdk8u.
Supplying the organization/group prefix is optional.

@JimLaskey
Copy link
Member Author

/backport jdk21u

@openjdk
Copy link

openjdk bot commented Jan 4, 2024

@JimLaskey the backport was successfully created on the branch backport-JimLaskey-df22fb32 in my personal fork of openjdk/jdk21u. To create a pull request with this backport targeting openjdk/jdk21u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit df22fb32 from the openjdk/jdk repository.

The commit being backported was authored by Jim Laskey on 4 Jan 2024 and was reviewed by Roger Riggs and Jaikiran Pai.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21u:

$ git fetch https://github.com/openjdk-bots/jdk21u.git backport-JimLaskey-df22fb32:backport-JimLaskey-df22fb32
$ git checkout backport-JimLaskey-df22fb32
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk21u.git backport-JimLaskey-df22fb32

@JimLaskey
Copy link
Member Author

/backport jdk22

@openjdk
Copy link

openjdk bot commented Jan 4, 2024

@JimLaskey the backport was successfully created on the branch backport-JimLaskey-df22fb32 in my personal fork of openjdk/jdk22. To create a pull request with this backport targeting openjdk/jdk22:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit df22fb32 from the openjdk/jdk repository.

The commit being backported was authored by Jim Laskey on 4 Jan 2024 and was reviewed by Roger Riggs and Jaikiran Pai.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk22:

$ git fetch https://github.com/openjdk-bots/jdk22.git backport-JimLaskey-df22fb32:backport-JimLaskey-df22fb32
$ git checkout backport-JimLaskey-df22fb32
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk22.git backport-JimLaskey-df22fb32

@JimLaskey
Copy link
Member Author

/backport jdk22u

@openjdk
Copy link

openjdk bot commented Jan 8, 2024

@JimLaskey the backport was successfully created on the branch backport-JimLaskey-df22fb32 in my personal fork of openjdk/jdk22u. To create a pull request with this backport targeting openjdk/jdk22u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit df22fb32 from the openjdk/jdk repository.

The commit being backported was authored by Jim Laskey on 4 Jan 2024 and was reviewed by Roger Riggs and Jaikiran Pai.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk22u:

$ git fetch https://github.com/openjdk-bots/jdk22u.git backport-JimLaskey-df22fb32:backport-JimLaskey-df22fb32
$ git checkout backport-JimLaskey-df22fb32
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk22u.git backport-JimLaskey-df22fb32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
4 participants