JDK-8320113: [macos14] : ShapeNotSetSometimes.java fails intermittently on macOS 14 #17180

honkar-jdk · 2023-12-21T20:33:53Z

ShapeNotSetSometimes.java fails intermittently on macOS 14. Following is a test stabilization fix for macOS 14. With the added delays ShapeNotSetSometimes.java passes on older versions of macOS as well as on macOS 14.1, 14.2.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8320113: [macos14] : ShapeNotSetSometimes.java fails intermittently on macOS 14 (Bug - P4)

Reviewers

Damon Nguyen (@DamonGuy - Committer) ⚠️ Review applies to 9831cffd
Alexander Zvegintsev (@azvegint - Reviewer)
Alexander Zuev (@azuev-java - Reviewer) ⚠️ Review applies to 9831cffd

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17180/head:pull/17180
$ git checkout pull/17180

Update a local copy of the PR:
$ git checkout pull/17180
$ git pull https://git.openjdk.org/jdk.git pull/17180/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17180

View PR using the GUI difftool:
$ git pr show -t 17180

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17180.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2023-12-21T20:34:33Z

👋 Welcome back honkar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2023-12-21T20:36:22Z

@honkar-jdk The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2023-12-21T20:38:54Z

Webrevs

DamonGuy

I tested this locally on my macOS 14.1.2 device and the test DID intermittently fail without the fix at different attempt #'s. But, with the updated test, the test is passing every time. Ran the test 10x and still passes. Stability fix looks good to me

openjdk · 2023-12-22T08:17:56Z

@honkar-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8320113: [macos14] : ShapeNotSetSometimes.java fails intermittently on macOS 14

Reviewed-by: dnguyen, azvegint, kizune

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 287 new commits pushed to the master branch:

6997bfc: 8323154: C2: assert(cmp != nullptr && cmp->Opcode() == Op_Cmp(bt)) failed: no exit test
16be388: 8322383: G1: Only preserve marks on objects that are actually moved
0081d8c: 8324147: Serial: Remove generation::compute_new_size
5f71419: 8322366: Add IEEE rounding mode corruption check to JNI checks
0533022: 8222719: libperfstat on AIX - cleanup old API versions
05dad67: 8295804: javax/swing/JFileChooser/JFileChooserSetLocationTest.java failed with "setLocation() is not working properly"
9efdd24: 8324053: Use the blessed modifier order for sealed in java.base
81df265: 8320458: Improve structural navigation in API documentation
a6c0b10: 8323684: TypeMirror.{getAnnotationsByType, getAnnotation} return uninformative results
5c874c1: 8324161: validate-source fails after JDK-8275338
... and 277 more: https://git.openjdk.org/jdk/compare/84c23792856c5c2374963d78a7a734a467bbb79b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

azuev-java

Looks good

honkar-jdk · 2023-12-22T20:42:10Z

This test is failing intermittently on linux with the current fix. Running the test on all platforms with slightly different delay values.

honkar-jdk · 2024-01-12T20:18:16Z

This test is fails intermittently on linux with the current fix. Running the test on all platforms with slightly different delay values.

In this test colorCheck() is repeated for 50 iterations. In the rare event, color check fails at random attempt no. (and happens to pass on previous iterations (as shown below). To stabilize the test on various platforms and machines, the constraint that colorcheck() needs to pass for all the 50 iterations has been relaxed by allowing the test to continue until 3 failed attempts. The test throws RuntimeException after 3 failed attempts.

CI Testing with the stabilization fix looks good on all platforms including macOS 14.

Attempt 8
Checking 150, 130, java.awt.Color[r=255,g=255,b=255] should be java.awt.Color[r=255,g=255,b=255]
Checking 150, 20, java.awt.Color[r=0,g=255,b=0] should be java.awt.Color[r=0,g=255,b=0]
Checking 280, 120, java.awt.Color[r=0,g=255,b=0] should be java.awt.Color[r=0,g=255,b=0]
Checking 150, 250, java.awt.Color[r=0,g=255,b=0] should be java.awt.Color[r=0,g=255,b=0]
Checking 20, 120, java.awt.Color[r=0,g=255,b=0] should be java.awt.Color[r=0,g=255,b=0]
Checking 62, 62, java.awt.Color[r=0,g=244,b=0] should not be java.awt.Color[r=255,g=255,b=255]
Checking 240, 185, java.awt.Color[r=0,g=232,b=0] should not be java.awt.Color[r=255,g=255,b=255]

Attempt 9
Checking 150, 130, java.awt.Color[r=255,g=255,b=255] should be java.awt.Color[r=255,g=255,b=255]
Checking 150, 20, java.awt.Color[r=0,g=255,b=0] should be java.awt.Color[r=0,g=255,b=0]
Checking 280, 120, java.awt.Color[r=0,g=255,b=0] should be java.awt.Color[r=0,g=255,b=0]
Checking 150, 250, java.awt.Color[r=0,g=255,b=0] should be java.awt.Color[r=0,g=255,b=0]
Checking 20, 120, java.awt.Color[r=0,g=255,b=0] should be java.awt.Color[r=0,g=255,b=0]
Checking 62, 62, java.awt.Color[r=0,g=240,b=0] should not be java.awt.Color[r=255,g=255,b=255]
Checking 240, 185, java.awt.Color[r=0,g=228,b=0] should not be java.awt.Color[r=255,g=255,b=255]

Attempt 10
Checking 150, 130, java.awt.Color[r=0,g=255,b=0] should be java.awt.Color[r=255,g=255,b=255]
window.getX() = 220, window.getY() = 400 

Checking for transparency failed: point: 370, 530
actual java.awt.Color[r=0,g=255,b=0]
expected java.awt.Color[r=255,g=255,b=255]
java.lang.RuntimeException: Test failed. The shape has not been applied.
at ShapeNotSetSometimes.colorCheck(ShapeNotSetSometimes.java:185)

honkar-jdk · 2024-01-12T20:24:44Z

@azuev-java @azvegint @DamonGuy Please re-review the updated test stabilization fix.

turbanoff · 2024-01-15T07:57:58Z

test/jdk/java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java

@@ -124,8 +125,9 @@ public void paint(Graphics g) {
    public static void main(String[] args) throws Exception {
        robot = new Robot();

-        for(int i = 0; i < 50; i++) {
+        for(int i = 1; i <= 50; i++) {


Suggested change

for(int i = 1; i <= 50; i++) {

for (int i = 1; i <= 50; i++) {

bourgesl · 2024-01-15T08:22:07Z

Looks better, not an official reviewer

DamonGuy

Tested the updated test changes. Still working as expected with 0 fails. Can I get some insight for the numOfFailedAttempts count being more or less than 3? Why is 3 significant?

honkar-jdk · 2024-01-16T22:09:27Z

Tested the updated test changes. Still working as expected with 0 fails. Can I get some insight for the numOfFailedAttempts count being more or less than 3? Why is 3 significant?

As explained here earlier, I'm unable to reproduce the intermittent issue on CI testing (as before on linux with the earlier fix) but taking into account that this is an intermittent issue, I believe a 3/50 failed attempts is less strict and prevents the test to fail instantly due to glitches during any given attempt. A 5 or 10 failed attempts might be relaxing the constraint too much hence 3 was chosen.

azvegint · 2024-01-18T19:11:53Z

I found out from our offline discussion that it failed only on Linux and not on other platforms.

Since it's very intermittent failure, and the test hasn't been on the problem list since April, and there have been no reported incidents on Linux since then, I think we should not hide such failures behind additional attempts until we find out the cause.

I suggest adding some additional debugging information, such as saving a screenshot of what actually happened before the exception was thrown.

honkar-jdk · 2024-01-18T22:09:48Z

Test updated according to @azvegint suggestions.

azvegint

Test updated according to @azvegint suggestions.

Thank you!

honkar-jdk · 2024-01-19T21:42:00Z

/integrate

openjdk · 2024-01-19T21:42:35Z

Going to push as commit f1b7335.
Since your change was applied there have been 292 commits pushed to the master branch:

8700de6: 8322744: VirtualThread.notifyJvmtiDisableSuspend should be static
6c0bebc: 8159927: Add a test to verify JMOD files created in the images do not have debug symbols
437342b: 8323556: CDS archive space addresses should be randomized with ArchiveRelocationMode=1
39005e2: 8324041: ModuleOption.java failed with update release versioning scheme
2865afe: 8323685: PrintSystemDictionaryAtExit has mutex rank assert
6997bfc: 8323154: C2: assert(cmp != nullptr && cmp->Opcode() == Op_Cmp(bt)) failed: no exit test
16be388: 8322383: G1: Only preserve marks on objects that are actually moved
0081d8c: 8324147: Serial: Remove generation::compute_new_size
5f71419: 8322366: Add IEEE rounding mode corruption check to JNI checks
0533022: 8222719: libperfstat on AIX - cleanup old API versions
... and 282 more: https://git.openjdk.org/jdk/compare/84c23792856c5c2374963d78a7a734a467bbb79b...master

Your commit was automatically rebased without conflicts.

openjdk · 2024-01-19T21:42:42Z

@honkar-jdk Pushed as commit f1b7335.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Test stabilization fix for macOS 14

28289dd

copyright year updated

2f25e61

openjdk bot added the rfr Pull request is ready for review label Dec 21, 2023

openjdk bot added the client client-libs-dev@openjdk.org label Dec 21, 2023

DamonGuy approved these changes Dec 21, 2023

View reviewed changes

azvegint approved these changes Dec 22, 2023

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Dec 22, 2023

azuev-java approved these changes Dec 22, 2023

View reviewed changes

test stabilization fix

9831cff

turbanoff reviewed Jan 15, 2024

View reviewed changes

DamonGuy approved these changes Jan 16, 2024

View reviewed changes

azuev-java approved these changes Jan 18, 2024

View reviewed changes

added screenCapture

9970fbc

azvegint approved these changes Jan 19, 2024

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label Jan 19, 2024

openjdk bot closed this Jan 19, 2024

openjdk bot removed the ready Pull request is ready to be integrated label Jan 19, 2024

openjdk bot removed the rfr Pull request is ready for review label Jan 19, 2024

honkar-jdk deleted the Testfix_8320113 branch January 19, 2024 21:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

JDK-8320113: [macos14] : ShapeNotSetSometimes.java fails intermittently on macOS 14 #17180

JDK-8320113: [macos14] : ShapeNotSetSometimes.java fails intermittently on macOS 14 #17180

honkar-jdk commented Dec 21, 2023 •

edited by openjdk bot

Loading

bridgekeeper bot commented Dec 21, 2023

openjdk bot commented Dec 21, 2023

mlbridge bot commented Dec 21, 2023 •

edited

Loading

DamonGuy left a comment

openjdk bot commented Dec 22, 2023 •

edited

Loading

azuev-java left a comment

honkar-jdk commented Dec 22, 2023 •

edited

Loading

honkar-jdk commented Jan 12, 2024 •

edited

Loading

honkar-jdk commented Jan 12, 2024 •

edited

Loading

turbanoff Jan 15, 2024

bourgesl commented Jan 15, 2024

DamonGuy left a comment

honkar-jdk commented Jan 16, 2024 •

edited

Loading

azvegint commented Jan 18, 2024

honkar-jdk commented Jan 18, 2024

azvegint left a comment

honkar-jdk commented Jan 19, 2024

openjdk bot commented Jan 19, 2024

openjdk bot commented Jan 19, 2024

	for(int i = 1; i <= 50; i++) {
	for (int i = 1; i <= 50; i++) {

JDK-8320113: [macos14] : ShapeNotSetSometimes.java fails intermittently on macOS 14 #17180

JDK-8320113: [macos14] : ShapeNotSetSometimes.java fails intermittently on macOS 14 #17180

Conversation

honkar-jdk commented Dec 21, 2023 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

Webrev

bridgekeeper bot commented Dec 21, 2023

openjdk bot commented Dec 21, 2023

mlbridge bot commented Dec 21, 2023 • edited Loading

Webrevs

DamonGuy left a comment

Choose a reason for hiding this comment

openjdk bot commented Dec 22, 2023 • edited Loading

azuev-java left a comment

Choose a reason for hiding this comment

honkar-jdk commented Dec 22, 2023 • edited Loading

honkar-jdk commented Jan 12, 2024 • edited Loading

honkar-jdk commented Jan 12, 2024 • edited Loading

turbanoff Jan 15, 2024

Choose a reason for hiding this comment

bourgesl commented Jan 15, 2024

DamonGuy left a comment

Choose a reason for hiding this comment

honkar-jdk commented Jan 16, 2024 • edited Loading

azvegint commented Jan 18, 2024

honkar-jdk commented Jan 18, 2024

azvegint left a comment

Choose a reason for hiding this comment

honkar-jdk commented Jan 19, 2024

openjdk bot commented Jan 19, 2024

openjdk bot commented Jan 19, 2024

honkar-jdk commented Dec 21, 2023 •

edited by openjdk bot

Loading

mlbridge bot commented Dec 21, 2023 •

edited

Loading

openjdk bot commented Dec 22, 2023 •

edited

Loading

honkar-jdk commented Dec 22, 2023 •

edited

Loading

honkar-jdk commented Jan 12, 2024 •

edited

Loading

honkar-jdk commented Jan 12, 2024 •

edited

Loading

honkar-jdk commented Jan 16, 2024 •

edited

Loading