8068958: Timestamp.from(Instant) should throw when conversion is not possible

[eamonnmcmanus]

Multiplying with * never produces ArithmeticException, so the catch in the existing code is never triggered. Math.multiplyExact does produce ArithmeticException if the multiplication overflows. So we can use that, and rethrow IllegalArgumentException as the specification says.

There is a small compatibility risk, in that code may have been relying on the previous silent overflow, and will now get an exception. But an exception is surely better than the nonsense results that overflow produces.

Thanks to Kurt Kluever for the test cases.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8068958: Timestamp.from(Instant) should throw when conversion is not possible (Bug - P4)

Reviewers

• Raffaello Giulietti (@rgiulietti - Reviewer)
• Roger Riggs (@RogerRiggs - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17181/head:pull/17181
$ git checkout pull/17181

Update a local copy of the PR:
$ git checkout pull/17181
$ git pull https://git.openjdk.org/jdk.git pull/17181/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17181

View PR using the GUI difftool:
$ git pr show -t 17181

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17181.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back emcmanus! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@eamonnmcmanus The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (9f3cbf12)
• 01: Full - Incremental (8f2e929c)
• 00: Full (32b3de53)

[rgiulietti]

Please update the copyright years in both the files.

[rgiulietti]

Don't forget to update the copyright years in both files, please ;-)

[eamonnmcmanus]

Don't forget to update the copyright years in both files, please ;-)

Done. (I'm a bit surprised there isn't some sort of automated check if this is a requirement.)

[openjdk]

@eamonnmcmanus This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8068958: Timestamp.from(Instant) should throw when conversion is not possible

Reviewed-by: rgiulietti, rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

• 28c82bf: 8322661: Build broken due to missing jvmtiExport.hpp after JDK-8320139
• 7263e25: 8322490: cleanup CastNode construction
• f695ca5: 8321151: JDK-8294427 breaks Windows L&F on all older Windows versions
• 93fedc1: 8321802: (zipfs) Add validation of incorrect LOC signature in ZipFileSystem
• 1230853: 8322163: runtime/Unsafe/InternalErrorTest.java fails on Alpine after JDK-8320886
• dce7a57: 8321683: Tests fail with AssertionError in RangeWithPageSize
• c53f845: 8322539: Parallel: Remove duplicated methods in PSAdaptiveSizePolicy
• 84c2379: 8320139: [JVMCI] VmObjectAlloc is not generated by intrinsics methods which allocate objects
• 3b908c4: 8319795: Static huge pages are not used for CodeCache

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[eamonnmcmanus]

/integrate

[openjdk]

Going to push as commit 4fc6b0f.
Since your change was applied there have been 9 commits pushed to the master branch:

• 28c82bf: 8322661: Build broken due to missing jvmtiExport.hpp after JDK-8320139
• 7263e25: 8322490: cleanup CastNode construction
• f695ca5: 8321151: JDK-8294427 breaks Windows L&F on all older Windows versions
• 93fedc1: 8321802: (zipfs) Add validation of incorrect LOC signature in ZipFileSystem
• 1230853: 8322163: runtime/Unsafe/InternalErrorTest.java fails on Alpine after JDK-8320886
• dce7a57: 8321683: Tests fail with AssertionError in RangeWithPageSize
• c53f845: 8322539: Parallel: Remove duplicated methods in PSAdaptiveSizePolicy
• 84c2379: 8320139: [JVMCI] VmObjectAlloc is not generated by intrinsics methods which allocate objects
• 3b908c4: 8319795: Static huge pages are not used for CodeCache

Your commit was automatically rebased without conflicts.

[openjdk]

@eamonnmcmanus Pushed as commit 4fc6b0f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.