Skip to content

Conversation

@DamonFool
Copy link
Member

@DamonFool DamonFool commented Dec 22, 2023

Add jvmtiExport.hpp in jvmciCompilerToVMInit.cpp to fix the build failure.
Thanks.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8322661: Build broken due to missing jvmtiExport.hpp after JDK-8320139 (Bug - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17182/head:pull/17182
$ git checkout pull/17182

Update a local copy of the PR:
$ git checkout pull/17182
$ git pull https://git.openjdk.org/jdk.git pull/17182/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17182

View PR using the GUI difftool:
$ git pr show -t 17182

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17182.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 22, 2023

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 22, 2023
@openjdk
Copy link

openjdk bot commented Dec 22, 2023

@DamonFool The following labels will be automatically applied to this pull request:

  • graal
  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added graal graal-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org labels Dec 22, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 22, 2023

Webrevs

@DamonFool DamonFool changed the title 8322661: Missing jvmtiExport.hpp after JDK-8320139 8322661: Build broken due to missing jvmtiExport.hpp after JDK-8320139 Dec 22, 2023
Copy link
Member

@chhagedorn chhagedorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Dec 22, 2023

@DamonFool This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322661: Build broken due to missing jvmtiExport.hpp after JDK-8320139

Reviewed-by: chagedorn, never

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 93fedc1: 8321802: (zipfs) Add validation of incorrect LOC signature in ZipFileSystem
  • 1230853: 8322163: runtime/Unsafe/InternalErrorTest.java fails on Alpine after JDK-8320886
  • dce7a57: 8321683: Tests fail with AssertionError in RangeWithPageSize
  • c53f845: 8322539: Parallel: Remove duplicated methods in PSAdaptiveSizePolicy

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 22, 2023
Copy link
Contributor

@tkrodriguez tkrodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thanks for fixing it.

@DamonFool
Copy link
Member Author

Thanks @chhagedorn and @tkrodriguez for the review.
/integrate

@openjdk
Copy link

openjdk bot commented Dec 22, 2023

Going to push as commit 28c82bf.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 7263e25: 8322490: cleanup CastNode construction
  • f695ca5: 8321151: JDK-8294427 breaks Windows L&F on all older Windows versions
  • 93fedc1: 8321802: (zipfs) Add validation of incorrect LOC signature in ZipFileSystem
  • 1230853: 8322163: runtime/Unsafe/InternalErrorTest.java fails on Alpine after JDK-8320886
  • dce7a57: 8321683: Tests fail with AssertionError in RangeWithPageSize
  • c53f845: 8322539: Parallel: Remove duplicated methods in PSAdaptiveSizePolicy

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 22, 2023
@openjdk openjdk bot closed this Dec 22, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 22, 2023
@openjdk
Copy link

openjdk bot commented Dec 22, 2023

@DamonFool Pushed as commit 28c82bf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@DamonFool DamonFool deleted the JDK-8322661 branch December 22, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

graal graal-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants