Skip to content

8322636: [JVMCI] HotSpotSpeculationLog can be inconsistent across a single compile #17183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

8322636: [JVMCI] HotSpotSpeculationLog can be inconsistent across a single compile #17183

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
810e42a
8322636: [JVMCI] HotSpotSpeculationLog can be inconsistent across a s…
davleopo Dec 22, 2023
ef02626
8322636: [JVMCI] HotSpotSpeculationLog add javadoc to maySpeculate
davleopo Jan 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/hotspot/HotSpotSpeculationLog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,12 @@ byte[] getFlattenedSpeculations(boolean validate) {
return result;
}

/**
* @return {@code true} if the given speculation can be performed, i.e., it never failed so far, otherwise
* return {@code false}. Note, that this method returns consistent results for any given speculation for the
* entire lifetime of the enclosing SpeculationLog object. This means that speculations failed during a
* compilation will not be updated.
*/
@Override
public boolean maySpeculate(SpeculationReason reason) {
if (failedSpeculations != null && failedSpeculations.length != 0) {
Expand Down