Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8252518: cache result of CompilerToVM.getComponentType #172

Closed
wants to merge 1 commit into from

Conversation

dougxc
Copy link
Member

@dougxc dougxc commented Sep 15, 2020

Linux perf profiles of CompileTheWorld with libgraal show that CompilerToVM.getComponentType is the most expensive JVMCI VM entry point with almost 2% of total execution time:

+ 1.87% 0.04% [.] c2v_getComponentType
+ 0.54% 0.00% [.] c2v_installCode
     0.39% 0.00% [.] c2v_getResolvedJavaType0
     0.04% 0.00% [.] c2v_resolvePossiblyCachedConstantInPool
     0.03% 0.00% [.] c2v_interpreterFrameSize
     0.03% 0.01% [.] c2v_isAssignableFrom
     0.02% 0.00% [.] c2v_translate
     0.01% 0.00% [.] c2v_getIdentityHashCode

It's worth caching the result of this call.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8252518: [JVMCI] cache the result of CompilerToVM.getComponentType ⚠️ Title mismatch between PR and JBS.

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/172/head:pull/172
$ git checkout pull/172

@dougxc dougxc marked this pull request as ready for review Sep 15, 2020
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 15, 2020

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 15, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2020

@dougxc The following label will be automatically applied to this pull request: hotspot-compiler.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the hotspot-compiler label Sep 15, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 15, 2020

Webrevs

@vnkozlov
Copy link
Contributor

@vnkozlov vnkozlov commented Sep 22, 2020

Good.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 22, 2020

@dougxc This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8252518: cache result of CompilerToVM.getComponentType

Reviewed-by: kvn, never
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 102 commits pushed to the master branch:

  • c1df13b: 8253208: Move CDS related code to a separate class
  • 24e12b3: 8247251: Assert (_pcs_length == 0 || last_pc()->pc_offset() < pc_offs…
  • 3d5fea1: 8253434: Shenandoah: Cleanup ShenandoahRootScanner
  • 8c02bdb: 8252921: NMT overwrite memory type for region assert when building dynamic archive
  • 0c287de: 8253421: Initialize JFR trace-IDs with zero
  • aa38624: 8248352: [TEST_BUG] Test test/jdk/java/awt/font/TextLayout/ArabicDiacriticTest.java can leave frame open
  • ae20dd6: 8251496: Fix doclint warnings in jdk.net.httpserver
  • b9729cb: 8253284: Zero OrderAccess barrier mappings are incorrect
  • 284bbf0: 8253079: DeterministicDump.java fails due to garbage in structure padding
  • a4affd5: 8253412: Unsupported GC options passed in JAVA_TOOL_OPTIONS are silently ignored
  • ... and 92 more: https://git.openjdk.java.net/jdk/compare/9ea43a9213e560f5a2b9c762677e8ad94a44a1d7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate c1df13b855984dc2197c0561f7a50c7a5a731dd9.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 22, 2020
@dougxc
Copy link
Member Author

@dougxc dougxc commented Sep 22, 2020

/integrate

@openjdk openjdk bot closed this Sep 22, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 22, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 22, 2020

@dougxc Since your change was applied there have been 102 commits pushed to the master branch:

  • c1df13b: 8253208: Move CDS related code to a separate class
  • 24e12b3: 8247251: Assert (_pcs_length == 0 || last_pc()->pc_offset() < pc_offs…
  • 3d5fea1: 8253434: Shenandoah: Cleanup ShenandoahRootScanner
  • 8c02bdb: 8252921: NMT overwrite memory type for region assert when building dynamic archive
  • 0c287de: 8253421: Initialize JFR trace-IDs with zero
  • aa38624: 8248352: [TEST_BUG] Test test/jdk/java/awt/font/TextLayout/ArabicDiacriticTest.java can leave frame open
  • ae20dd6: 8251496: Fix doclint warnings in jdk.net.httpserver
  • b9729cb: 8253284: Zero OrderAccess barrier mappings are incorrect
  • 284bbf0: 8253079: DeterministicDump.java fails due to garbage in structure padding
  • a4affd5: 8253412: Unsupported GC options passed in JAVA_TOOL_OPTIONS are silently ignored
  • ... and 92 more: https://git.openjdk.java.net/jdk/compare/9ea43a9213e560f5a2b9c762677e8ad94a44a1d7...master

Your commit was automatically rebased without conflicts.

Pushed as commit 0f26ab1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dougxc dougxc deleted the JDK-8252518 branch Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler integrated
3 participants