Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8322801: RISC-V: The riscv path of the debian sysroot had been changed #17208

Closed
wants to merge 2 commits into from

Conversation

lgxbslgx
Copy link
Member

@lgxbslgx lgxbslgx commented Jan 1, 2024

Hi all,

This trivial patch removes the information about the path debian-ports because the riscv related packages had been moved to the path debian at 2024-01-01. Now the arm and riscv use the same url https://httpredir.debian.org/debian/.

Thanks for your review.

Best Regards,
-- Guoxiong


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8322801: RISC-V: The riscv path of the debian sysroot had been changed (Enhancement - P5)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17208/head:pull/17208
$ git checkout pull/17208

Update a local copy of the PR:
$ git checkout pull/17208
$ git pull https://git.openjdk.org/jdk.git pull/17208/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17208

View PR using the GUI difftool:
$ git pr show -t 17208

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17208.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 1, 2024

👋 Welcome back gli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title JDK-8322801 8322801: RISC-V: The riscv path of the debian sysroot had been changed Jan 1, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 1, 2024
@openjdk
Copy link

openjdk bot commented Jan 1, 2024

@lgxbslgx The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Jan 1, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 1, 2024

Webrevs

Copy link
Contributor

@robehn robehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@openjdk
Copy link

openjdk bot commented Jan 2, 2024

@lgxbslgx This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322801: RISC-V: The riscv path of the debian sysroot had been changed

Reviewed-by: rehn, erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 9481d06: 8320343: Generate GIF images for AbstractButton/5049549/bug5049549.java
  • a5cf421: 8320360: ClassFile.parse: Some defect class files cause unexpected exceptions to be thrown
  • f9aec02: 8321540: ClassSignature.parseFrom() throws StringIndexOutOfBoundsException for invalid signatures
  • 7455b1b: 8322159: ThisEscapeAnalyzer crashes for erroneous code
  • d4fb308: 8317846: Typo in API documentation of classes IdentityHashMap
  • d786c49: 8322751: ZGC: Fix comments about marking roots
  • 5852f3e: 8322027: One XMLStreamException constructor fails to initialize cause
  • be0e1c7: 8297573: Parallel: Rename do_oop_nv to do_oop_work in subclasses of OopClosure
  • 7c1d481: 8322765: Eliminate -Wparentheses warnings in runtime code

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 2, 2024
@erikj79
Copy link
Member

erikj79 commented Jan 2, 2024

The html file also needs to be regenerated. Let me know if you need help with that.

@lgxbslgx
Copy link
Member Author

lgxbslgx commented Jan 2, 2024

The html file also needs to be regenerated. Let me know if you need help with that.

Yes indeed. Thanks.

@erikj79
Copy link
Member

erikj79 commented Jan 2, 2024

The html file also needs to be regenerated. Let me know if you need help with that.

Yes indeed. Thanks.

Pushed regenerated html here: erikj79@693c314

@lgxbslgx
Copy link
Member Author

lgxbslgx commented Jan 2, 2024

I merged your changement just now.

@lgxbslgx
Copy link
Member Author

lgxbslgx commented Jan 3, 2024

@robehn @erikj79 Thanks for your reviews. Integrating.

/integrate

@openjdk
Copy link

openjdk bot commented Jan 3, 2024

Going to push as commit 18cdc90.
Since your change was applied there have been 18 commits pushed to the master branch:

  • fcf8368: 8322248: Fix inconsistent wording in ElementFilter.typesIn
  • a678416: 8322805: Eliminate -Wparentheses warnings in x86 code
  • 122bc77: 8322758: Eliminate -Wparentheses warnings in C2 code
  • e9e694f: 8320275: assert(_chunk->bitmap().at(index)) failed: Bit not set at index
  • da1091e: 8322807: Eliminate -Wparentheses warnings in gc code
  • c2477a5: 8322868: java/io/BufferedInputStream/TransferToTrusted.java has bad copyright header
  • 2cf5f01: 8322802: Add testing for ZipFile.getEntry respecting the 'Language encoding' flag
  • 38042ad: 8320971: Use BufferedInputStream.buf directly when param of implTransferTo() is trusted
  • 51238c4: 8322503: Shenandoah: Clarify gc state usage
  • 9481d06: 8320343: Generate GIF images for AbstractButton/5049549/bug5049549.java
  • ... and 8 more: https://git.openjdk.org/jdk/compare/518ec9711411e6825668f72503a2e96824cd37ba...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 3, 2024
@openjdk openjdk bot closed this Jan 3, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 3, 2024
@openjdk
Copy link

openjdk bot commented Jan 3, 2024

@lgxbslgx Pushed as commit 18cdc90.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@lgxbslgx lgxbslgx deleted the JDK-8322801 branch January 3, 2024 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants