8322806: Eliminate -Wparentheses warnings in aarch64 code

[kimbarrett]

Please review this change to eliminate some -Wparentheses warnings. This
involved simply adding a few parentheses to make some implicit operator
precedence explicit.

Testing: mach5 tier1

Also ran mach5 tier1 with these changes in conjunction enabling -Wparentheses
and other changes needed to make that work.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8322806: Eliminate -Wparentheses warnings in aarch64 code (Enhancement - P4)

Reviewers

• Stefan Karlsson (@stefank - Reviewer) ⚠️ Review applies to 82e75c86
• David Holmes (@dholmes-ora - Reviewer) ⚠️ Review applies to 82e75c86

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17210/head:pull/17210
$ git checkout pull/17210

Update a local copy of the PR:
$ git checkout pull/17210
$ git pull https://git.openjdk.org/jdk.git pull/17210/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17210

View PR using the GUI difftool:
$ git pr show -t 17210

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17210.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@kimbarrett The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (63ce2307)
• 00: Full (82e75c86)

[stefank]

Seems fine. FWIW, the second usage of ret looks redundant.

[openjdk]

@kimbarrett This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322806: Eliminate -Wparentheses warnings in aarch64 code

Reviewed-by: stefank, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dholmes-ora]

LGTM. Thanks

[shipilev]

Well... Since || is short-cutting, then on the right side of ||, we can be sure that !ret was false (shortcut not taken), which means ret was true, which means ret && is redundant?

[stefank]

I agree:
#17210 (review)

[kimbarrett]

Agreed, and updated.

[kimbarrett]

Thanks for reviews @dholmes-ora , @stefank , and comment from @shipilev .

[kimbarrett]

/integrate

[openjdk]

Going to push as commit d75d876.

[openjdk]

@kimbarrett Pushed as commit d75d876.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.