-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8322805: Eliminate -Wparentheses warnings in x86 code #17211
Conversation
👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into |
@kimbarrett The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, and again trivial IMO.
Thanks
@kimbarrett This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good.
Thanks for reviews @dholmes-ora and @vnkozlov . |
/integrate |
Going to push as commit a678416. |
@kimbarrett Pushed as commit a678416. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review this change to eliminate some -Wparentheses warnings. This
involved simply adding a few parentheses to make some implicit operator
precedence explicit.
Testing: mach5 tier1
Also ran mach5 tier1 with these changes in conjunction enabling -Wparentheses
and other changes needed to make that work.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17211/head:pull/17211
$ git checkout pull/17211
Update a local copy of the PR:
$ git checkout pull/17211
$ git pull https://git.openjdk.org/jdk.git pull/17211/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 17211
View PR using the GUI difftool:
$ git pr show -t 17211
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17211.diff
Webrev
Link to Webrev Comment