8322815: Eliminate -Wparentheses warnings in shenandoah code

[kimbarrett]

8322815: Eliminate -Wparentheses warnings in shenandoah code

Please review this change to eliminate some -Wparentheses warnings. This
involved simply adding a few parentheses to make some implicit operator
precedence explicit.

Testing: local (linux-x64) build with shenandoah included and ran
hotspot:tier1 with -XX:+UseShenandoahGC.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8322815: Eliminate -Wparentheses warnings in shenandoah code (Enhancement - P4)

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer) ⚠️ Review applies to b0d9d50d
• Zhengyu Gu (@zhengyu123 - Reviewer) ⚠️ Review applies to b0d9d50d

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17214/head:pull/17214
$ git checkout pull/17214

Update a local copy of the PR:
$ git checkout pull/17214
$ git pull https://git.openjdk.org/jdk.git pull/17214/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17214

View PR using the GUI difftool:
$ git pr show -t 17214

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17214.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@kimbarrett The following labels will be automatically applied to this pull request:

• hotspot-gc
• shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full (e5ed2806)
• 00: Full (b0d9d50d)

[shipilev]

The change for this PR seems fine, but the whole assert looks weird, and lacks richer diagnostics Shenandoah asserts do. I believe the forwardee is explicitly marked, given it is a new copy after TAMS. So the whole thing might be just:

  shenandoah_assert_not_in_cset_except(p, resolved, _heap->cancelled_gc());

Right, @zhengyu123? We should do that in separate PR.

[shipilev]

Doing this in #17245. @kimbarrett, feel free to drop this hunk from the patch, that PR is going to rewrite the assert

[kimbarrett]

Thanks. Removed as part of merge conflict resolution.

[openjdk]

@kimbarrett This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322815: Eliminate -Wparentheses warnings in shenandoah code

Reviewed-by: shade, zgu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[zhengyu123]

LGTM

[kimbarrett]

Thanks for reviews @shipilev and @zhengyu123 .

[kimbarrett]

/integrate

[openjdk]

Going to push as commit 3560e68.

[openjdk]

@kimbarrett Pushed as commit 3560e68.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.