JDK-8322783: prioritize /etc/os-release over /etc/SuSE-release in hs_err/info output

[MBaesken]

Currently, /etc/SuSE-release is prioritized over /etc/os-release in the hs_info/hs_err file output .
But this leads on SUSE 12 distros to output like this :

# This file is deprecated and will be removed in a future service pack or release.
# Please check /etc/os-release for details about this release.

So we probably better prioritize /etc/os-release over /etc/SuSE-release.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8322783: prioritize /etc/os-release over /etc/SuSE-release in hs_err/info output (Enhancement - P4)

Reviewers

• David Holmes (@dholmes-ora - Reviewer) ⚠️ Review applies to 364a2b9a
• Martin Doerr (@TheRealMDoerr - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17222/head:pull/17222
$ git checkout pull/17222

Update a local copy of the PR:
$ git checkout pull/17222
$ git pull https://git.openjdk.org/jdk.git pull/17222/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17222

View PR using the GUI difftool:
$ git pr show -t 17222

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17222.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@MBaesken The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (0a398b59)
• 00: Full (364a2b9a)

[dholmes-ora]

As long as older versions we care about are guaranteed to have a valid os-release file then this seems fine.

One suggested comment below.

Thanks

[dholmes-ora]

Suggestion:

"/etc/SuSE-release",    // Deprecated in favor of os-release since SuSE 12

[openjdk]

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322783: prioritize /etc/os-release over /etc/SuSE-release in hs_err/info output

Reviewed-by: dholmes, mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

• cbe329b: 8321713: Harmonize executeTestJvm with create[Limited]TestJavaProcessBuilder
• 06dd735: 8322766: Micro bench SSLHandshake should use default algorithms
• 9ab29f8: 8321718: ProcessTools.executeProcess calls waitFor before logging
• ba426d6: 8322841: Parallel: Remove unused using-declaration in MutableNUMASpace
• 18cdc90: 8322801: RISC-V: The riscv path of the debian sysroot had been changed
• fcf8368: 8322248: Fix inconsistent wording in ElementFilter.typesIn
• a678416: 8322805: Eliminate -Wparentheses warnings in x86 code
• 122bc77: 8322758: Eliminate -Wparentheses warnings in C2 code
• e9e694f: 8320275: assert(_chunk->bitmap().at(index)) failed: Bit not set at index
• da1091e: 8322807: Eliminate -Wparentheses warnings in gc code
• ... and 5 more: https://git.openjdk.org/jdk/compare/a5cf4210cd9c293a9e9bce60dc6d0f08fd838c77...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[MBaesken]

Thanks David ! I added the comment you suggested.

[TheRealMDoerr]

LGTM.

[MBaesken]

Hi David and Martin, thanks for the reviews !

/integrate

[openjdk]

Going to push as commit a8e4229.
Since your change was applied there have been 15 commits pushed to the master branch:

• cbe329b: 8321713: Harmonize executeTestJvm with create[Limited]TestJavaProcessBuilder
• 06dd735: 8322766: Micro bench SSLHandshake should use default algorithms
• 9ab29f8: 8321718: ProcessTools.executeProcess calls waitFor before logging
• ba426d6: 8322841: Parallel: Remove unused using-declaration in MutableNUMASpace
• 18cdc90: 8322801: RISC-V: The riscv path of the debian sysroot had been changed
• fcf8368: 8322248: Fix inconsistent wording in ElementFilter.typesIn
• a678416: 8322805: Eliminate -Wparentheses warnings in x86 code
• 122bc77: 8322758: Eliminate -Wparentheses warnings in C2 code
• e9e694f: 8320275: assert(_chunk->bitmap().at(index)) failed: Bit not set at index
• da1091e: 8322807: Eliminate -Wparentheses warnings in gc code
• ... and 5 more: https://git.openjdk.org/jdk/compare/a5cf4210cd9c293a9e9bce60dc6d0f08fd838c77...master

Your commit was automatically rebased without conflicts.

[openjdk]

@MBaesken Pushed as commit a8e4229.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.