Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8322888: Parallel: Remove unused variables in PSPromotionManager #17238

Closed
wants to merge 1 commit into from

Conversation

albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Jan 3, 2024

Trivial removing dead code.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8322888: Parallel: Remove unused variables in PSPromotionManager (New Feature - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17238/head:pull/17238
$ git checkout pull/17238

Update a local copy of the PR:
$ git checkout pull/17238
$ git pull https://git.openjdk.org/jdk.git pull/17238/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17238

View PR using the GUI difftool:
$ git pr show -t 17238

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17238.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 3, 2024

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8322888 8322888: Parallel: Remove unused variables in PSPromotionManager Jan 3, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 3, 2024
@openjdk
Copy link

openjdk bot commented Jan 3, 2024

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Jan 3, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 3, 2024

Webrevs

Copy link

@kimbarrett kimbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and trivial.

@openjdk
Copy link

openjdk bot commented Jan 3, 2024

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322888: Parallel: Remove unused variables in PSPromotionManager

Reviewed-by: kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • cc9ab5f: 8322963: ProblemList java/io/BufferedInputStream/TransferTo.java
  • 1551928: 8322142: JFR: Periodic tasks aren't orphaned between recordings
  • b67b71c: 8320707: Virtual thread test updates
  • 7eb25ec: 8322853: Should use ConditionalMutexLocker in NativeHeapTrimmerThread::print_state
  • 539da24: 8322779: C1: Remove the unused counter 'totalInstructionNodes'
  • a8e4229: 8322783: prioritize /etc/os-release over /etc/SuSE-release in hs_err/info output
  • cbe329b: 8321713: Harmonize executeTestJvm with create[Limited]TestJavaProcessBuilder
  • 06dd735: 8322766: Micro bench SSLHandshake should use default algorithms
  • 9ab29f8: 8321718: ProcessTools.executeProcess calls waitFor before logging

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 3, 2024
@albertnetymk
Copy link
Member Author

Thanks for the review.

/integrate

@openjdk
Copy link

openjdk bot commented Jan 4, 2024

Going to push as commit 83564ea.
Since your change was applied there have been 21 commits pushed to the master branch:

  • bbe0079: 8322298: Obsolete unused AdaptiveSizePolicyCollectionCostMargin
  • 7306636: 8322945: Problemlist runtime/CompressedOops/CompressedClassPointers.java on AIX
  • 1369c54: 8322782: Clean up usages of unnecessary fully qualified class name "java.util.Arrays"
  • 4db7a1c: 8322818: Thread::getStackTrace can fail with InternalError if virtual thread is timed-parked when pinned
  • 755722c: 8322214: Return value of XMLInputFactory.getProperty() changed from boolean to String in JDK 22 early access builds
  • 1cf9335: 8321404: Limit the number of heap dumps triggered by HeapDumpBeforeFullGC/AfterFullGC
  • 13c1148: 8321599: Data loss in AVX3 Base64 decoding
  • 028ec7e: 8319948: jcmd man page needs to be updated
  • 54b3cee: 8322877: java/io/BufferedInputStream/TransferTo.java failed with IndexOutOfBoundsException
  • 30a0c61: 8322879: Eliminate -Wparentheses warnings in x86-32 code
  • ... and 11 more: https://git.openjdk.org/jdk/compare/ba426d6887bc2d7e2b39f1b19cc1d8d8f14cfb45...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 4, 2024
@openjdk openjdk bot closed this Jan 4, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 4, 2024
@openjdk
Copy link

openjdk bot commented Jan 4, 2024

@albertnetymk Pushed as commit 83564ea.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the trivial branch January 4, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants