Skip to content

Conversation

@LizBing
Copy link
Contributor

@LizBing LizBing commented Jan 3, 2024

Description:
One can directly return MinMaxPLABSizeBounds("OldPLABSize", value, verbose) without introducing a local variable.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8322890: Directly return in OldPLABSizeConstraintFunc (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17246/head:pull/17246
$ git checkout pull/17246

Update a local copy of the PR:
$ git checkout pull/17246
$ git pull https://git.openjdk.org/jdk.git pull/17246/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17246

View PR using the GUI difftool:
$ git pr show -t 17246

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17246.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 3, 2024

👋 Welcome back LizBing! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8322890 8322890: Directly return in OldPLABSizeConstraintFunc Jan 3, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 3, 2024
@openjdk
Copy link

openjdk bot commented Jan 3, 2024

@LizBing The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Jan 3, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 3, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 3, 2024

@LizBing This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322890: Directly return in OldPLABSizeConstraintFunc

Reviewed-by: ayang, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 121 new commits pushed to the master branch:

  • 438ab7c: 8323284: Remove unused FilteringClosure declaration
  • 52c7ff1: 8322330: JavadocHelperTest.java OOMEs with Parallel GC and ZGC
  • ff499ef: 8233443: G1 DetailedUsage class names overly generic for global namespace
  • 37a6172: 8322936: Update blessed-modifier-order.sh for default, sealed, and non-sealed
  • 7d42aa1: 8310277: jdk/javadoc/doclet/testMethodCommentAlgorithm/TestMethodCommentsAlgorithm.java fails with IllegalStateException
  • 6e9671a: 8323264: Serial: Remove unused GenerationBlockSizeClosure
  • 52a6c37: 8322858: compiler/c2/aarch64/TestFarJump.java fails on AArch64 due to unexpected PrintAssembly output
  • 075fed9: 8323241: jcmd manpage should use lists for argument lists
  • 30f93a2: 8320069: RISC-V: Add Zcb instructions
  • 4cf131a: 8319716: RISC-V: Add SHA-2
  • ... and 111 more: https://git.openjdk.org/jdk/compare/84c23792856c5c2374963d78a7a734a467bbb79b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@albertnetymk, @tschatzl) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 3, 2024
Copy link
Contributor

@tschatzl tschatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@LizBing
Copy link
Contributor Author

LizBing commented Jan 9, 2024

thanks for the review

@LizBing
Copy link
Contributor Author

LizBing commented Jan 9, 2024

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 9, 2024
@openjdk
Copy link

openjdk bot commented Jan 9, 2024

@LizBing
Your change (at version 70899a1) is now ready to be sponsored by a Committer.

@albertnetymk
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 9, 2024

Going to push as commit 886386c.
Since your change was applied there have been 121 commits pushed to the master branch:

  • 438ab7c: 8323284: Remove unused FilteringClosure declaration
  • 52c7ff1: 8322330: JavadocHelperTest.java OOMEs with Parallel GC and ZGC
  • ff499ef: 8233443: G1 DetailedUsage class names overly generic for global namespace
  • 37a6172: 8322936: Update blessed-modifier-order.sh for default, sealed, and non-sealed
  • 7d42aa1: 8310277: jdk/javadoc/doclet/testMethodCommentAlgorithm/TestMethodCommentsAlgorithm.java fails with IllegalStateException
  • 6e9671a: 8323264: Serial: Remove unused GenerationBlockSizeClosure
  • 52a6c37: 8322858: compiler/c2/aarch64/TestFarJump.java fails on AArch64 due to unexpected PrintAssembly output
  • 075fed9: 8323241: jcmd manpage should use lists for argument lists
  • 30f93a2: 8320069: RISC-V: Add Zcb instructions
  • 4cf131a: 8319716: RISC-V: Add SHA-2
  • ... and 111 more: https://git.openjdk.org/jdk/compare/84c23792856c5c2374963d78a7a734a467bbb79b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 9, 2024
@openjdk openjdk bot closed this Jan 9, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 9, 2024
@openjdk
Copy link

openjdk bot commented Jan 9, 2024

@albertnetymk @LizBing Pushed as commit 886386c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@LizBing LizBing deleted the JDK-8322890 branch January 9, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants