Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8257802: LogCompilation throws couldn't find bytecode on JDK 8 log #1725

Closed
wants to merge 1 commit into from

Conversation

@ericcaspole
Copy link

@ericcaspole ericcaspole commented Dec 9, 2020

JBS: https://bugs.openjdk.java.net/browse/JDK-8257802

The problem is that there is a call/inline_fail sequence in the optimizer phase after the parse phase. It looks like this has never been handled well the tool. My solution here is to skip these in the optimizer phase because there is not enough context to know the call site.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8257802: LogCompilation throws couldn't find bytecode on JDK 8 log

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1725/head:pull/1725
$ git checkout pull/1725

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 9, 2020

👋 Welcome back ecaspole! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Dec 9, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 9, 2020

@ericcaspole The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 9, 2020

Webrevs

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Good.

@openjdk
Copy link

@openjdk openjdk bot commented Dec 9, 2020

@ericcaspole This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257802: LogCompilation throws couldn't find bytecode on JDK 8 log

Reviewed-by: kvn, redestad

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 74 new commits pushed to the master branch:

  • a372be4: 8258244: Shenandoah: Not expecting forwarded object in roots during mark after JDK-8240868
  • 568dc29: 8185734: [Windows] Structured Exception Catcher missing around gtest execution
  • 3ab1dfe: 8257828: SafeFetch may crash if invoked in non-JavaThreads
  • 381021a: Merge
  • afc4441: 8258094: AIX build fails after 8257602
  • 164c8a6: 8258092: Link to early access platform documentation in TestHtmlTableTags.java
  • 43dc3f7: 8254350: CompletableFuture.get may swallow InterruptedException
  • 6d79ec8: 8258111: Problemlist compiler/blackhole tests for -Xcomp until JDK-8258101 is fixed
  • 2001da3: 8257596: Clarify trusted final fields for record classes
  • b1afed7: 8257919: [JVMCI] profiling info didn't change after reprofile
  • ... and 64 more: https://git.openjdk.java.net/jdk/compare/cf62b0ad869979b0ce307d625794dcd05cbec6ec...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 9, 2020
cl4es
cl4es approved these changes Dec 15, 2020
@ericcaspole
Copy link
Author

@ericcaspole ericcaspole commented Dec 15, 2020

/integrate

@openjdk openjdk bot closed this Dec 15, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 15, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 15, 2020

@ericcaspole Since your change was applied there have been 74 commits pushed to the master branch:

  • a372be4: 8258244: Shenandoah: Not expecting forwarded object in roots during mark after JDK-8240868
  • 568dc29: 8185734: [Windows] Structured Exception Catcher missing around gtest execution
  • 3ab1dfe: 8257828: SafeFetch may crash if invoked in non-JavaThreads
  • 381021a: Merge
  • afc4441: 8258094: AIX build fails after 8257602
  • 164c8a6: 8258092: Link to early access platform documentation in TestHtmlTableTags.java
  • 43dc3f7: 8254350: CompletableFuture.get may swallow InterruptedException
  • 6d79ec8: 8258111: Problemlist compiler/blackhole tests for -Xcomp until JDK-8258101 is fixed
  • 2001da3: 8257596: Clarify trusted final fields for record classes
  • b1afed7: 8257919: [JVMCI] profiling info didn't change after reprofile
  • ... and 64 more: https://git.openjdk.java.net/jdk/compare/cf62b0ad869979b0ce307d625794dcd05cbec6ec...master

Your commit was automatically rebased without conflicts.

Pushed as commit 65756ab.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@ericcaspole ericcaspole deleted the JDK-8257802 branch Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants