8322877: java/io/BufferedInputStream/TransferTo.java failed with IndexOutOfBoundsException

[bplb]

The final position instead of the number of bytes to write was being passed to ByteArrayOuputStream.write(byte[],int,int).

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8322877: java/io/BufferedInputStream/TransferTo.java failed with IndexOutOfBoundsException (Bug - P4)

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)
• Sergey Tsypanov (@stsypanov - Author)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17250/head:pull/17250
$ git checkout pull/17250

Update a local copy of the PR:
$ git checkout pull/17250
$ git pull https://git.openjdk.org/jdk.git pull/17250/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17250

View PR using the GUI difftool:
$ git pr show -t 17250

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17250.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[bplb]

Everyone was apparently caught off guard as previously Arrays.copyOfRange(byte[],int,int) had been used here, and its third parameter is the to position, not the number of bytes to copy.

[openjdk]

@bplb The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (fe347e32)

[openjdk]

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322877: java/io/BufferedInputStream/TransferTo.java failed with IndexOutOfBoundsException

Reviewed-by: alanb, stsypanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• 296c5b6: 8322873: Duplicate -ljava -ljvm options for libinstrument

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[bplb]

/integrate

[openjdk]

Going to push as commit 54b3cee.
Since your change was applied there have been 3 commits pushed to the master branch:

• 30a0c61: 8322879: Eliminate -Wparentheses warnings in x86-32 code
• 409a39e: 8320276: Improve class initialization barrier in TemplateTable::_new
• 296c5b6: 8322873: Duplicate -ljava -ljvm options for libinstrument

Your commit was automatically rebased without conflicts.

[openjdk]

@bplb Pushed as commit 54b3cee.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[mkarg]

@bplb Shouldn't it be avail here, too?

[bplb]

No: the third param of Arrays.copyOfRange is to, not len.

[mkarg]

Ah, this explains why it did not fail originally, but only after adding the "isTrusted" case! 🙏

[bplb]

See #17250 (comment) above.