Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8322214: Return value of XMLInputFactory.getProperty() changed from boolean to String in JDK 22 early access builds #17252

Closed
wants to merge 1 commit into from

Conversation

JoeWang-Java
Copy link
Member

@JoeWang-Java JoeWang-Java commented Jan 3, 2024

Fix the get (return) operation by using the same method as that used for checking the values of the DTD features during the resolution process.

Note: this patch also addresses the issue reported in https://bugs.openjdk.org/browse/JDK-8322216

Test: new test added covers DTD properties for SAX/DOM/StAX.
Existing tests passed.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8322214: Return value of XMLInputFactory.getProperty() changed from boolean to String in JDK 22 early access builds (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17252/head:pull/17252
$ git checkout pull/17252

Update a local copy of the PR:
$ git checkout pull/17252
$ git pull https://git.openjdk.org/jdk.git pull/17252/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17252

View PR using the GUI difftool:
$ git pr show -t 17252

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17252.diff

Webrev

Link to Webrev Comment

…oolean to String in JDK 22 early access builds
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 3, 2024

👋 Welcome back joehw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 3, 2024
@openjdk
Copy link

openjdk bot commented Jan 3, 2024

@JoeWang-Java The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jan 3, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 3, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 3, 2024

@JoeWang-Java This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322214: Return value of XMLInputFactory.getProperty() changed from boolean to String in JDK 22 early access builds

Reviewed-by: lancea

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

  • 54b3cee: 8322877: java/io/BufferedInputStream/TransferTo.java failed with IndexOutOfBoundsException
  • 30a0c61: 8322879: Eliminate -Wparentheses warnings in x86-32 code
  • 409a39e: 8320276: Improve class initialization barrier in TemplateTable::_new
  • 296c5b6: 8322873: Duplicate -ljava -ljvm options for libinstrument
  • cc9ab5f: 8322963: ProblemList java/io/BufferedInputStream/TransferTo.java
  • 1551928: 8322142: JFR: Periodic tasks aren't orphaned between recordings
  • b67b71c: 8320707: Virtual thread test updates
  • 7eb25ec: 8322853: Should use ConditionalMutexLocker in NativeHeapTrimmerThread::print_state
  • 539da24: 8322779: C1: Remove the unused counter 'totalInstructionNodes'
  • a8e4229: 8322783: prioritize /etc/os-release over /etc/SuSE-release in hs_err/info output
  • ... and 5 more: https://git.openjdk.org/jdk/compare/fcf8368eb1945c440df8f38969849621b4fffc50...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 3, 2024
@JoeWang-Java
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 4, 2024

Going to push as commit 755722c.
Since your change was applied there have been 18 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 4, 2024
@openjdk openjdk bot closed this Jan 4, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 4, 2024
@openjdk
Copy link

openjdk bot commented Jan 4, 2024

@JoeWang-Java Pushed as commit 755722c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants