8322981: Fix 2 locations in JDI that throw IOException without using the "Caused by" exception

[plummercj]

Use "cause" argument when rethrowing an exception. See CR for details on how this helps.

Tested with all of tier1, and also ran tier2 and tier4 svc tests.

I'd like to push this as a trivial change.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8322981: Fix 2 locations in JDI that throw IOException without using the "Caused by" exception (Enhancement - P4)

Reviewers

• David Holmes (@dholmes-ora - Reviewer)
• Leonid Mesnik (@lmesnik - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17258/head:pull/17258
$ git checkout pull/17258

Update a local copy of the PR:
$ git checkout pull/17258
$ git pull https://git.openjdk.org/jdk.git pull/17258/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17258

View PR using the GUI difftool:
$ git pr show -t 17258

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17258.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@plummercj The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (3c143f1d)

[dholmes-ora]

Setting the cause is good, but do you not also want an informative message?

[plummercj]

Setting the cause is good, but do you not also want an informative message?

Not necessary.

public class Test {
    public static void main(String[] args) {
        try {
            try {
                throw new Throwable("hello");
            } catch (Throwable t) {
                throw new Throwable(t);
            }
        } catch (Throwable t) {
            t.printStackTrace(System.out);
        }
    }
}

produces:

java.lang.Throwable: java.lang.Throwable: hello
	at Test.main(Test.java:7)
Caused by: java.lang.Throwable: hello
	at Test.main(Test.java:5)

If I change the second throw to:

throw new Throwable(t,"goodbye");

You get:

java.lang.Throwable: goodbye
	at Test.main(Test.java:7)
Caused by: java.lang.Throwable: hello
	at Test.main(Test.java:5)

So it appears that for the first line of the prinstStackTrace() output, it prints the exception name and then the message if there is one. If there is no message then it instead prints the cause exception name, and its message if it has one.

[dholmes-ora]

Okay - thanks. Change is trivial.

[openjdk]

@plummercj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322981: Fix 2 locations in JDI that throw IOException without using the "Caused by" exception

Reviewed-by: dholmes, lmesnik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

• 5235cc9: 8322583: RISC-V: Enable fast class initialization checks
• 3b1e56a: 8322322: Support archived full module graph when -Xbootclasspath/a is used
• 3fbccb0: 8322978: Remove debug agent debugMonitorTimedWait() function. It is no longer used.
• ad31ec5: 8322647: Short name for the Europe/Lisbon time zone is incorrect
• 15cf8f8: 8319626: Override toString() for ZipFile
• ade4074: 8322976: Remove reference to transform_no_reclaim
• ea19e9c: 8323011: ProblemList serviceability/HeapDump/FullGCHeapDumpLimitTest.java
• d33dfe5: 8323002: test/jdk/java/lang/Thread/virtual/stress/GetStackTraceALotWhenPinned.java times out on macosx-x64
• 27d5f5c: 8322781: C1: Debug build crash in GraphBuilder::vmap() when print stats
• df22fb3: 8322512: StringBuffer.repeat does not work correctly after toString() was called
• ... and 11 more: https://git.openjdk.org/jdk/compare/54b3ceeca27b67f4270d8b700b072f46959dba65...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[plummercj]

Thanks for the reviews David and Leonid!

/integrate

[openjdk]

Going to push as commit 46965a0.
Since your change was applied there have been 32 commits pushed to the master branch:

• 700c25f: 8322954: Shenandoah: Convert evac-update closures asserts to rich asserts
• 631a9f6: 8323073: ProblemList gc/g1/TestSkipRebuildRemsetPhase.java on linux-aarch64
• ed9f324: 8322985: [BACKOUT] 8318562: Computational test more than 2x slower when AVX instructions are used
• ade21a9: 8310844: [AArch64] C1 compilation fails because monitor offset in OSR buffer is too large for immediate
• f0cfd36: 8322532: JShell : Unnamed variable issue
• 78623c9: 8323012: C2 fails with fatal error: no reachable node should have no use
• f0e2e43: 8323021: Shenandoah: Encountered reference count always attributed to first worker thread
• 3dc4bd8: 8322989: New test serviceability/HeapDump/FullGCHeapDumpLimitTest.java fails
• 1d1cd32: 8321812: Update GC tests to use execute[Limited]TestJava
• 868f874: 8322920: Some ProcessTools.execute* functions are declared to throw Throwable
• ... and 22 more: https://git.openjdk.org/jdk/compare/54b3ceeca27b67f4270d8b700b072f46959dba65...master

Your commit was automatically rebased without conflicts.

[openjdk]

@plummercj Pushed as commit 46965a0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.