Skip to content

8322978: Remove debug agent debugMonitorTimedWait() function. It is no longer used.#17260

Closed
plummercj wants to merge 1 commit intoopenjdk:masterfrom
plummercj:8322978_waitremove
Closed

8322978: Remove debug agent debugMonitorTimedWait() function. It is no longer used.#17260
plummercj wants to merge 1 commit intoopenjdk:masterfrom
plummercj:8322978_waitremove

Conversation

@plummercj
Copy link
Contributor

@plummercj plummercj commented Jan 4, 2024

Remove unused debugMonitorTimedWait() function.

Tested with all of tier1, and also ran tier2 and tier4 svc tests.

I'd like to push this as a trivial change.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8322978: Remove debug agent debugMonitorTimedWait() function. It is no longer used. (Bug - P5)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17260/head:pull/17260
$ git checkout pull/17260

Update a local copy of the PR:
$ git checkout pull/17260
$ git pull https://git.openjdk.org/jdk.git pull/17260/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17260

View PR using the GUI difftool:
$ git pr show -t 17260

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17260.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 4, 2024

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8322978 8322978: Remove debug agent debugMonitorTimedWait() function. It is no longer used. Jan 4, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 4, 2024
@openjdk
Copy link

openjdk bot commented Jan 4, 2024

@plummercj The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Jan 4, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 4, 2024

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine and trivial.

@openjdk
Copy link

openjdk bot commented Jan 4, 2024

@plummercj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322978: Remove debug agent debugMonitorTimedWait() function. It is no longer used.

Reviewed-by: dholmes, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • c3cd1f1: 8323000: Parallel: Remove unused class declarations in psScavenge
  • dd517c6: 8237842: Separate definitions for default cache line and padding sizes
  • 83564ea: 8322888: Parallel: Remove unused variables in PSPromotionManager
  • bbe0079: 8322298: Obsolete unused AdaptiveSizePolicyCollectionCostMargin
  • 7306636: 8322945: Problemlist runtime/CompressedOops/CompressedClassPointers.java on AIX
  • 1369c54: 8322782: Clean up usages of unnecessary fully qualified class name "java.util.Arrays"
  • 4db7a1c: 8322818: Thread::getStackTrace can fail with InternalError if virtual thread is timed-parked when pinned
  • 755722c: 8322214: Return value of XMLInputFactory.getProperty() changed from boolean to String in JDK 22 early access builds
  • 1cf9335: 8321404: Limit the number of heap dumps triggered by HeapDumpBeforeFullGC/AfterFullGC
  • 13c1148: 8321599: Data loss in AVX3 Base64 decoding
  • ... and 1 more: https://git.openjdk.org/jdk/compare/54b3ceeca27b67f4270d8b700b072f46959dba65...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 4, 2024
Copy link
Contributor

@sspitsyn sspitsyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay.

@plummercj
Copy link
Contributor Author

Thanks for the reviews David and Serguei.

/integrate

@openjdk
Copy link

openjdk bot commented Jan 4, 2024

Going to push as commit 3fbccb0.
Since your change was applied there have been 18 commits pushed to the master branch:

  • ad31ec5: 8322647: Short name for the Europe/Lisbon time zone is incorrect
  • 15cf8f8: 8319626: Override toString() for ZipFile
  • ade4074: 8322976: Remove reference to transform_no_reclaim
  • ea19e9c: 8323011: ProblemList serviceability/HeapDump/FullGCHeapDumpLimitTest.java
  • d33dfe5: 8323002: test/jdk/java/lang/Thread/virtual/stress/GetStackTraceALotWhenPinned.java times out on macosx-x64
  • 27d5f5c: 8322781: C1: Debug build crash in GraphBuilder::vmap() when print stats
  • df22fb3: 8322512: StringBuffer.repeat does not work correctly after toString() was called
  • c3cd1f1: 8323000: Parallel: Remove unused class declarations in psScavenge
  • dd517c6: 8237842: Separate definitions for default cache line and padding sizes
  • 83564ea: 8322888: Parallel: Remove unused variables in PSPromotionManager
  • ... and 8 more: https://git.openjdk.org/jdk/compare/54b3ceeca27b67f4270d8b700b072f46959dba65...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 4, 2024
@openjdk openjdk bot closed this Jan 4, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 4, 2024
@openjdk
Copy link

openjdk bot commented Jan 4, 2024

@plummercj Pushed as commit 3fbccb0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

3 participants