8322754: click JComboBox when dialog about to close causes IllegalComponentStateException

[prsadhuk]

Clicking to open a JComboBox popup during AWT event processing at the end of which the dialog will be closed causes an IllegalComponentStateException.
Fix is made to check if combobox is showing before showing the popup to prevent the exception.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8322754: click JComboBox when dialog about to close causes IllegalComponentStateException (Bug - P3)

Reviewers

• Abhishek Kumar (@kumarabhi006 - Committer)
• Sergey Bylokhov (@mrserb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17262/head:pull/17262
$ git checkout pull/17262

Update a local copy of the PR:
$ git checkout pull/17262
$ git pull https://git.openjdk.org/jdk.git pull/17262/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17262

View PR using the GUI difftool:
$ git pr show -t 17262

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17262.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

⚠️ @prsadhuk This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

[openjdk]

@prsadhuk The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (b50f63c8)

[kumarabhi006]

Verified the test.

[openjdk]

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322754: click JComboBox when dialog about to close causes IllegalComponentStateException

Reviewed-by: abhiscxk, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 49 new commits pushed to the master branch:

• 35a1b77: 8322636: [JVMCI] HotSpotSpeculationLog can be inconsistent across a single compile
• 46965a0: 8322981: Fix 2 locations in JDI that throw IOException without using the "Caused by" exception
• 700c25f: 8322954: Shenandoah: Convert evac-update closures asserts to rich asserts
• 631a9f6: 8323073: ProblemList gc/g1/TestSkipRebuildRemsetPhase.java on linux-aarch64
• ed9f324: 8322985: [BACKOUT] 8318562: Computational test more than 2x slower when AVX instructions are used
• ade21a9: 8310844: [AArch64] C1 compilation fails because monitor offset in OSR buffer is too large for immediate
• f0cfd36: 8322532: JShell : Unnamed variable issue
• 78623c9: 8323012: C2 fails with fatal error: no reachable node should have no use
• f0e2e43: 8323021: Shenandoah: Encountered reference count always attributed to first worker thread
• 3dc4bd8: 8322989: New test serviceability/HeapDump/FullGCHeapDumpLimitTest.java fails
• ... and 39 more: https://git.openjdk.org/jdk/compare/fcf8368eb1945c440df8f38969849621b4fffc50...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[prsadhuk]

/integrate

[openjdk]

Going to push as commit e442769.
Since your change was applied there have been 53 commits pushed to the master branch:

• 3560e68: 8322815: Eliminate -Wparentheses warnings in shenandoah code
• faa9c69: 8322846: Running with -Djdk.tracePinnedThreads set can hang
• ace010b: 8319757: java/nio/channels/DatagramChannel/InterruptibleOrNot.java failed: wrong exception thrown
• be4614e: 8323016: Improve reporting for bad options
• 35a1b77: 8322636: [JVMCI] HotSpotSpeculationLog can be inconsistent across a single compile
• 46965a0: 8322981: Fix 2 locations in JDI that throw IOException without using the "Caused by" exception
• 700c25f: 8322954: Shenandoah: Convert evac-update closures asserts to rich asserts
• 631a9f6: 8323073: ProblemList gc/g1/TestSkipRebuildRemsetPhase.java on linux-aarch64
• ed9f324: 8322985: [BACKOUT] 8318562: Computational test more than 2x slower when AVX instructions are used
• ade21a9: 8310844: [AArch64] C1 compilation fails because monitor offset in OSR buffer is too large for immediate
• ... and 43 more: https://git.openjdk.org/jdk/compare/fcf8368eb1945c440df8f38969849621b4fffc50...master

Your commit was automatically rebased without conflicts.

[openjdk]

@prsadhuk Pushed as commit e442769.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.