7057369: (fs spec) FileStore getUsableSpace and getUnallocatedSpace could be clearer

[bplb]

Attempt to clarify when the values returned for a FileStores usable and unallocated space are initialized and likely to be valid.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires CSR request JDK-8323084 to be approved

Issues

• JDK-7057369: (fs spec) FileStore getUsableSpace and getUnallocatedSpace could be clearer (Bug - P4)
• JDK-8323084: (fs spec) FileStore getUsableSpace and getUnallocatedSpace could be clearer (CSR)

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17271/head:pull/17271
$ git checkout pull/17271

Update a local copy of the PR:
$ git checkout pull/17271
$ git pull https://git.openjdk.org/jdk.git pull/17271/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17271

View PR using the GUI difftool:
$ git pr show -t 17271

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17271.diff

Webrev

Link to Webrev Comment

[bplb]

/csr

[bridgekeeper]

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@bplb has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@bplb please create a CSR request for issue JDK-7057369 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

[openjdk]

@bplb The following label will be automatically applied to this pull request:

• nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (0df648db)
• 00: Full (7d10b049)

[AlanBateman]

It might be simpler to just say "the current number of usable bytes".

[AlanBateman]

I think the original paragraph is okay. The change to the second paragraph looks good.

[openjdk]

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7057369: (fs spec) FileStore getUsableSpace and getUnallocatedSpace could be clearer

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 66 new commits pushed to the master branch:

• a5071e0: 8322817: RISC-V: Eliminate -Wparentheses warnings in riscv code
• 28d8149: 8323115: x86-32: Incorrect predicates for cmov instruct transforms with UseSSE
• e9f7db3: 8322880: Eliminate -Wparentheses warnings in arm32 code
• aba1933: 8323210: Update the usage of cmsFLAGS_COPY_ALPHA
• f3be138: 8322809: SystemModulesMap::classNames and moduleNames arrays do not match the order
• bc05893: 8323318: Remove unused Space::is_free_block
• dd8ae61: 8322237: Heap dump contains duplicate thread records for mounted virtual threads
• ee98d26: 8323066: gc/g1/TestSkipRebuildRemsetPhase.java fails with 'Skipping Remembered Set Rebuild.' missing
• 886386c: 8322890: Directly return in OldPLABSizeConstraintFunc
• 438ab7c: 8323284: Remove unused FilteringClosure declaration
• ... and 56 more: https://git.openjdk.org/jdk/compare/3fbccb01dcffe9eb48a08d99aab0e9aa311a18cf...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[bplb]

/integrate

[openjdk]

Going to push as commit 475306b.
Since your change was applied there have been 83 commits pushed to the master branch:

• f016934: 8323518: Parallel: Remove unused methods in psParallelCompact.hpp
• 2174f66: 8323005: Parallel: Refactor PSPromotionManager::claim_or_forward_depth
• 1617067: 8323331: fix typo hpage_pdm_size
• 2806ade: 8321685: Missing ResourceMark in code called from JvmtiEnvBase::get_vthread_jvf
• ec38505: 8323508: Remove TestGCLockerWithShenandoah.java line from TEST.groups
• d2d58dd: 8322324: java/foreign/TestStubAllocFailure.java times out while waiting for forked process
• b2a39c5: 8316241: Test jdk/jdk/jfr/jvm/TestChunkIntegrity.java failed
• 679f526: 8322278: Generational ZGC: Adjust the comment of ZHeuristics::use_per_cpu_shared_small_pages
• 2e472fe: 8322294: Cleanup NativePostCallNop
• 88dafe5: 8314629: Generational ZGC: Clearing All SoftReferences log line lacks GCId
• ... and 73 more: https://git.openjdk.org/jdk/compare/3fbccb01dcffe9eb48a08d99aab0e9aa311a18cf...master

Your commit was automatically rebased without conflicts.

[openjdk]

@bplb Pushed as commit 475306b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.