Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8323021: Shenandoah: Encountered reference count always attributed to first worker thread #17273

Conversation

earthling-amzn
Copy link
Contributor

@earthling-amzn earthling-amzn commented Jan 4, 2024

Simple fix, code was using array base pointer instead of indexing by worker id as intended.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8323021: Shenandoah: Encountered reference count always attributed to first worker thread (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17273/head:pull/17273
$ git checkout pull/17273

Update a local copy of the PR:
$ git checkout pull/17273
$ git pull https://git.openjdk.org/jdk.git pull/17273/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17273

View PR using the GUI difftool:
$ git pr show -t 17273

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17273.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 4, 2024

👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 4, 2024
@openjdk
Copy link

openjdk bot commented Jan 4, 2024

@earthling-amzn The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-gc hotspot-gc-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org labels Jan 4, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 4, 2024

Webrevs

Copy link
Contributor

@kdnilsen kdnilsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@earthling-amzn
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 5, 2024

@earthling-amzn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8323021: Shenandoah: Encountered reference count always attributed to first worker thread

Reviewed-by: kdnilsen, ysr, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

  • 3dc4bd8: 8322989: New test serviceability/HeapDump/FullGCHeapDumpLimitTest.java fails
  • 1d1cd32: 8321812: Update GC tests to use execute[Limited]TestJava
  • 868f874: 8322920: Some ProcessTools.execute* functions are declared to throw Throwable
  • 2a9c358: 8322725: (tz) Update Timezone Data to 2023d
  • 5235cc9: 8322583: RISC-V: Enable fast class initialization checks
  • 3b1e56a: 8322322: Support archived full module graph when -Xbootclasspath/a is used
  • 3fbccb0: 8322978: Remove debug agent debugMonitorTimedWait() function. It is no longer used.
  • ad31ec5: 8322647: Short name for the Europe/Lisbon time zone is incorrect
  • 15cf8f8: 8319626: Override toString() for ZipFile
  • ade4074: 8322976: Remove reference to transform_no_reclaim
  • ... and 13 more: https://git.openjdk.org/jdk/compare/13c11487f7126a370d9ce8e62f661ea83eedefe6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@ysramakrishna, @shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated sponsor Pull request is ready to be sponsored labels Jan 5, 2024
@openjdk
Copy link

openjdk bot commented Jan 5, 2024

@earthling-amzn
Your change (at version 7a48c6b) is now ready to be sponsored by a Committer.

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, gotta love C(++), huh.

@shipilev
Copy link
Member

shipilev commented Jan 5, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 5, 2024

Going to push as commit f0e2e43.
Since your change was applied there have been 23 commits pushed to the master branch:

  • 3dc4bd8: 8322989: New test serviceability/HeapDump/FullGCHeapDumpLimitTest.java fails
  • 1d1cd32: 8321812: Update GC tests to use execute[Limited]TestJava
  • 868f874: 8322920: Some ProcessTools.execute* functions are declared to throw Throwable
  • 2a9c358: 8322725: (tz) Update Timezone Data to 2023d
  • 5235cc9: 8322583: RISC-V: Enable fast class initialization checks
  • 3b1e56a: 8322322: Support archived full module graph when -Xbootclasspath/a is used
  • 3fbccb0: 8322978: Remove debug agent debugMonitorTimedWait() function. It is no longer used.
  • ad31ec5: 8322647: Short name for the Europe/Lisbon time zone is incorrect
  • 15cf8f8: 8319626: Override toString() for ZipFile
  • ade4074: 8322976: Remove reference to transform_no_reclaim
  • ... and 13 more: https://git.openjdk.org/jdk/compare/13c11487f7126a370d9ce8e62f661ea83eedefe6...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 5, 2024
@openjdk openjdk bot closed this Jan 5, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 5, 2024
@openjdk
Copy link

openjdk bot commented Jan 5, 2024

@shipilev @earthling-amzn Pushed as commit f0e2e43.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated shenandoah shenandoah-dev@openjdk.org
4 participants