Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8258018: Remove arrayOop.inline.hpp #1728

Closed

Conversation

iklam
Copy link
Member

@iklam iklam commented Dec 10, 2020

Please review this trivial change. arrayOop.inline.hpp is not needed and its contents can be safely moved into arrayOop.hpp.

Testing with mach5 tier1,builds-tier2,builds-tier3,builds-tier4,builds-tier5


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1728/head:pull/1728
$ git checkout pull/1728

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 10, 2020

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Dec 10, 2020

@iklam The following labels will be automatically applied to this pull request:

  • hotspot
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added serviceability hotspot labels Dec 10, 2020
@iklam
Copy link
Member Author

@iklam iklam commented Dec 10, 2020

/label remove serviceability

@openjdk openjdk bot removed the serviceability label Dec 10, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 10, 2020

@iklam
The serviceability label was successfully removed.

@iklam iklam marked this pull request as ready for review Dec 10, 2020
@openjdk openjdk bot added the rfr label Dec 10, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 10, 2020

Webrevs

Copy link
Member

@stefank stefank left a comment

Thanks for cleaning this up!

@openjdk
Copy link

@openjdk openjdk bot commented Dec 10, 2020

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258018: Remove arrayOop.inline.hpp

Reviewed-by: stefank, kbarrett, coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 502a524: 8257602: Introduce JFR Event Throttling and new jdk.ObjectAllocationSample event (enabled by default)
  • 026b09c: 8257483: C2: Split immediate vector rotate from RotateLeftV and RotateRightV nodes
  • 0a0691e: 8257901: ZGC: Take virtual memory usage into account when sizing heap
  • 29ffffa: 8257997: sun/security/ssl/SSLSocketImpl/SSLSocketLeak.java again reports leaks after JDK-8257884
  • db5da96: 8257876: Avoid Reference.isEnqueued in tests
  • 4a839e9: 8256459: java/net/httpclient/ManyRequests.java and java/net/httpclient/LineBodyHandlerTest.java fail infrequently with java.net.ConnectException: Connection timed out: no further information
  • d93293f: 8256730: Code that uses Object.checkIndex() range checks doesn't optimize well

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 10, 2020
@@ -90,7 +90,9 @@ class arrayOopDesc : public oopDesc {

// Returns the address of the first element. The elements in the array will not
// relocate from this address until a subsequent thread transition.
inline void* base(BasicType type) const;
inline void* base(BasicType type) const {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop the unnecessary "inline".

Copy link
Contributor

@coleenp coleenp left a comment

LGTM.

@iklam
Copy link
Member Author

@iklam iklam commented Dec 10, 2020

Thanks @stefank @coleenp @kimbarrett for the review. Mach5 tests passed for tier1,builds-tier2,builds-tier3,builds-tier4,builds-tier5
/integrate

@openjdk openjdk bot closed this Dec 10, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 10, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 10, 2020

@iklam Since your change was applied there have been 13 commits pushed to the master branch:

  • 6693611: 8253797: [cgroups v2] Account for the fact that swap accounting is disabled on some systems
  • 6be1f56: 8257450: Start of release updates for JDK 17
  • d163c6f: 8258015: [JVMCI] JVMCI_lock shouldn't be held while initializing box classes
  • b35401d: 8257966: Instrument test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/StateTestService.java
  • 37043b0: 8257837: Performance regression in heap byte buffer views
  • 0890620: 8258005: JDK build fails with incorrect fixpath script
  • 502a524: 8257602: Introduce JFR Event Throttling and new jdk.ObjectAllocationSample event (enabled by default)
  • 026b09c: 8257483: C2: Split immediate vector rotate from RotateLeftV and RotateRightV nodes
  • 0a0691e: 8257901: ZGC: Take virtual memory usage into account when sizing heap
  • 29ffffa: 8257997: sun/security/ssl/SSLSocketImpl/SSLSocketLeak.java again reports leaks after JDK-8257884
  • ... and 3 more: https://git.openjdk.java.net/jdk/compare/869dcb6f5030e74f0ea70292d4eedc9dceb00f3e...master

Your commit was automatically rebased without conflicts.

Pushed as commit 1e5e790.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot integrated
4 participants