8323065: Unneccesary CodeBlob lookup in CompiledIC::internal_set_ic_destination

[shipilev]

I was looking at hotpath for IC stub cleaning (happens at safepoint), and one obvious thing is that we look-up CodeBlob from call->instruction_address() only to assert that is compiled one. It used to be protected by #ifdef ASSERT before JDK-8212681, and pulled from it to be used in Mutex in JDK 12: https://hg.openjdk.org/jdk/jdk/rev/d6dc479bcdd3#l15.62 And the Mutex was shortly gone after JDK-8214257. So we are exposing this code to product binaries since JDK 12.

This fix reinstates the ASSERT block again. There are small improvements (~1..10us) for safepoint cleanup on small ad-hoc tests in release builds on my Mac. But since this whole thing involves looking up things in code cache, it may cost quite a lot.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8323065: Unneccesary CodeBlob lookup in CompiledIC::internal_set_ic_destination (Enhancement - P4)

Reviewers

• Dean Long (@dean-long - Reviewer)
• Tobias Hartmann (@TobiHartmann - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17281/head:pull/17281
$ git checkout pull/17281

Update a local copy of the PR:
$ git checkout pull/17281
$ git pull https://git.openjdk.org/jdk.git pull/17281/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17281

View PR using the GUI difftool:
$ git pr show -t 17281

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17281.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (3e8e26cc)

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8323065: Unneccesary CodeBlob lookup in CompiledIC::internal_set_ic_destination

Reviewed-by: dlong, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 31 new commits pushed to the master branch:

• a40d397: 8323110: Eliminate -Wparentheses warnings in ppc code
• 7edd10e: 8321786: SegmentAllocator:allocateFrom(ValueLayout, MemorySegment,ValueLayout,long,long) spec mismatch in exception scenario
• d75d876: 8322806: Eliminate -Wparentheses warnings in aarch64 code
• e442769: 8322754: click JComboBox when dialog about to close causes IllegalComponentStateException
• 3560e68: 8322815: Eliminate -Wparentheses warnings in shenandoah code
• faa9c69: 8322846: Running with -Djdk.tracePinnedThreads set can hang
• ace010b: 8319757: java/nio/channels/DatagramChannel/InterruptibleOrNot.java failed: wrong exception thrown
• be4614e: 8323016: Improve reporting for bad options
• 35a1b77: 8322636: [JVMCI] HotSpotSpeculationLog can be inconsistent across a single compile
• 46965a0: 8322981: Fix 2 locations in JDI that throw IOException without using the "Caused by" exception
• ... and 21 more: https://git.openjdk.org/jdk/compare/c3cd1f1814c1561c99caec58a2a61d069f6cd181...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[TobiHartmann]

Looks good to me too.

[shipilev]

Thanks! I am going to integrate it then.

/integrate

[openjdk]

Going to push as commit eb9e754.
Since your change was applied there have been 31 commits pushed to the master branch:

• a40d397: 8323110: Eliminate -Wparentheses warnings in ppc code
• 7edd10e: 8321786: SegmentAllocator:allocateFrom(ValueLayout, MemorySegment,ValueLayout,long,long) spec mismatch in exception scenario
• d75d876: 8322806: Eliminate -Wparentheses warnings in aarch64 code
• e442769: 8322754: click JComboBox when dialog about to close causes IllegalComponentStateException
• 3560e68: 8322815: Eliminate -Wparentheses warnings in shenandoah code
• faa9c69: 8322846: Running with -Djdk.tracePinnedThreads set can hang
• ace010b: 8319757: java/nio/channels/DatagramChannel/InterruptibleOrNot.java failed: wrong exception thrown
• be4614e: 8323016: Improve reporting for bad options
• 35a1b77: 8322636: [JVMCI] HotSpotSpeculationLog can be inconsistent across a single compile
• 46965a0: 8322981: Fix 2 locations in JDI that throw IOException without using the "Caused by" exception
• ... and 21 more: https://git.openjdk.org/jdk/compare/c3cd1f1814c1561c99caec58a2a61d069f6cd181...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit eb9e754.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.