Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8323032: OptimizedModuleHandlingTest failed in dynamic CDS archive mode #17288

Conversation

calvinccheung
Copy link
Member

@calvinccheung calvinccheung commented Jan 5, 2024

Please review this simple test fix for excluding a test scenario when it is run with dynamic CDS archive mode (-Dtest.dynamic.cds.archive=true).

Passed tier1 and tier4 testing.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8323032: OptimizedModuleHandlingTest failed in dynamic CDS archive mode (Bug - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17288/head:pull/17288
$ git checkout pull/17288

Update a local copy of the PR:
$ git checkout pull/17288
$ git pull https://git.openjdk.org/jdk.git pull/17288/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17288

View PR using the GUI difftool:
$ git pr show -t 17288

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17288.diff

Webrev

Link to Webrev Comment

@calvinccheung
Copy link
Member Author

/label add hotspot-runtime

@calvinccheung calvinccheung marked this pull request as ready for review January 5, 2024 23:03
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 5, 2024

👋 Welcome back ccheung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added rfr Pull request is ready for review hotspot-runtime hotspot-runtime-dev@openjdk.org labels Jan 5, 2024
@openjdk
Copy link

openjdk bot commented Jan 5, 2024

@calvinccheung
The hotspot-runtime label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Jan 5, 2024

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable for test purpose.

Is there any intent to support empty -cp with a classlist?

Thanks

@openjdk
Copy link

openjdk bot commented Jan 8, 2024

@calvinccheung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8323032: OptimizedModuleHandlingTest failed in dynamic CDS archive mode

Reviewed-by: dholmes, matsaave

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 29 new commits pushed to the master branch:

  • ca9635d: 8322759: Eliminate -Wparentheses warnings in compiler code
  • 8a4dc79: 8274300: Address dsymutil warning by excluding platform specific files
  • d78e8da: 8322545: Declare newInsets as static in ThemeReader.cpp
  • 24823ba: 8323095: Expand TraceOptoParse block output abbreviations
  • d47393b: 8320128: Clean up Parse constructor for OSR
  • 387828a: 8322980: Debug agent's dumpThread() API should update thread's name before printing it
  • c4a83bd: 8323086: Shenandoah: Heap could be corrupted by oom during evacuation
  • 827c71d: 8310190: C2 SuperWord: AlignVector is broken, generates misaligned packs
  • 2acb5bd: 8322790: RISC-V: Tune costs for shuffles with no conversion
  • c8fa3e2: 8320310: CompiledMethod::has_monitors flag can be incorrect
  • ... and 19 more: https://git.openjdk.org/jdk/compare/631a9f60f30fe298791aa953fa573001127ff58a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 8, 2024
@calvinccheung
Copy link
Member Author

Is there any intent to support empty -cp with a classlist?

I think the test utility could be enhanced to support empty -cp with a classlist. In the context of dynamic CDS dump, it doesn't make sense to support a classlist because a classlist is never processed during dynamic dump.

Copy link
Contributor

@matias9927 matias9927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@calvinccheung
Copy link
Member Author

Thanks @dholmes-ora, @matias9927 for the reviews.

/integrate

@openjdk
Copy link

openjdk bot commented Jan 8, 2024

Going to push as commit 61ebe3b.
Since your change was applied there have been 29 commits pushed to the master branch:

  • ca9635d: 8322759: Eliminate -Wparentheses warnings in compiler code
  • 8a4dc79: 8274300: Address dsymutil warning by excluding platform specific files
  • d78e8da: 8322545: Declare newInsets as static in ThemeReader.cpp
  • 24823ba: 8323095: Expand TraceOptoParse block output abbreviations
  • d47393b: 8320128: Clean up Parse constructor for OSR
  • 387828a: 8322980: Debug agent's dumpThread() API should update thread's name before printing it
  • c4a83bd: 8323086: Shenandoah: Heap could be corrupted by oom during evacuation
  • 827c71d: 8310190: C2 SuperWord: AlignVector is broken, generates misaligned packs
  • 2acb5bd: 8322790: RISC-V: Tune costs for shuffles with no conversion
  • c8fa3e2: 8320310: CompiledMethod::has_monitors flag can be incorrect
  • ... and 19 more: https://git.openjdk.org/jdk/compare/631a9f60f30fe298791aa953fa573001127ff58a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 8, 2024
@openjdk openjdk bot closed this Jan 8, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 8, 2024
@openjdk
Copy link

openjdk bot commented Jan 8, 2024

@calvinccheung Pushed as commit 61ebe3b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@calvinccheung calvinccheung deleted the 8323032-OptimizedModuleHandlingTest branch January 8, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
3 participants