8322744: VirtualThread.notifyJvmtiDisableSuspend should be static

[sspitsyn]

The notification method VirtualThread.notifyJvmtiDisableSuspend should be static.
The method disables/enables suspend of the current virtual thread, a no-op if the current thread is a platform thread. It is confusing for this to be an instance method, it should be static to make it clearer that it doesn't change the target thread.
The notification method VirtualThread.notifyJvmtiHideFrames also has to be static as it does not use/need the virtual thread this argument.
One detail to underline is the intrinsic implementation needs to use the argument #0 instead of #1.

Testing:

• The mach5 tiers 1-6 show no regressions

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8322744: VirtualThread.notifyJvmtiDisableSuspend should be static (Bug - P4)

Reviewers

• Patricio Chilano Mateo (@pchilano - Reviewer)
• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17298/head:pull/17298
$ git checkout pull/17298

Update a local copy of the PR:
$ git checkout pull/17298
$ git pull https://git.openjdk.org/jdk.git pull/17298/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17298

View PR using the GUI difftool:
$ git pr show -t 17298

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17298.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back sspitsyn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sspitsyn The following labels will be automatically applied to this pull request:

• core-libs
• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (66bcce95)
• 00: Full (2b684607)

[sspitsyn]

PING! It would be nice to get this reviewed. :)

[pchilano]

Looks good to me. I'm confused about the description saying this method is a no-op if the current thread is a platform thread.

[openjdk]

@sspitsyn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322744: VirtualThread.notifyJvmtiDisableSuspend should be static

Reviewed-by: pchilanomate, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 121 new commits pushed to the master branch:

• 16be388: 8322383: G1: Only preserve marks on objects that are actually moved
• 0081d8c: 8324147: Serial: Remove generation::compute_new_size
• 5f71419: 8322366: Add IEEE rounding mode corruption check to JNI checks
• 0533022: 8222719: libperfstat on AIX - cleanup old API versions
• 05dad67: 8295804: javax/swing/JFileChooser/JFileChooserSetLocationTest.java failed with "setLocation() is not working properly"
• 9efdd24: 8324053: Use the blessed modifier order for sealed in java.base
• 81df265: 8320458: Improve structural navigation in API documentation
• a6c0b10: 8323684: TypeMirror.{getAnnotationsByType, getAnnotation} return uninformative results
• 5c874c1: 8324161: validate-source fails after JDK-8275338
• b6233c3: 8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist"
• ... and 111 more: https://git.openjdk.org/jdk/compare/e5aed6be7a184a86a32fa671d48e0781fab54183...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[sspitsyn]

Patricio and Alan, thank you a lot for review!

[sspitsyn]

/integrate

[openjdk]

Going to push as commit 8700de6.
Since your change was applied there have been 126 commits pushed to the master branch:

• 6c0bebc: 8159927: Add a test to verify JMOD files created in the images do not have debug symbols
• 437342b: 8323556: CDS archive space addresses should be randomized with ArchiveRelocationMode=1
• 39005e2: 8324041: ModuleOption.java failed with update release versioning scheme
• 2865afe: 8323685: PrintSystemDictionaryAtExit has mutex rank assert
• 6997bfc: 8323154: C2: assert(cmp != nullptr && cmp->Opcode() == Op_Cmp(bt)) failed: no exit test
• 16be388: 8322383: G1: Only preserve marks on objects that are actually moved
• 0081d8c: 8324147: Serial: Remove generation::compute_new_size
• 5f71419: 8322366: Add IEEE rounding mode corruption check to JNI checks
• 0533022: 8222719: libperfstat on AIX - cleanup old API versions
• 05dad67: 8295804: javax/swing/JFileChooser/JFileChooserSetLocationTest.java failed with "setLocation() is not working properly"
• ... and 116 more: https://git.openjdk.org/jdk/compare/e5aed6be7a184a86a32fa671d48e0781fab54183...master

Your commit was automatically rebased without conflicts.

[openjdk]

@sspitsyn Pushed as commit 8700de6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.