Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8318112: CSS percentage values are capped at 100% #17299

Closed
wants to merge 1 commit into from

Conversation

prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Jan 8, 2024

Java CSS where values can be displayed in percent are capped at 100% so "width: 200%" and "width: 100%" are equal, which is incorrect.
FIx is made to make sure parsing is not capped at 100%


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8318112: CSS percentage values are capped at 100% (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17299/head:pull/17299
$ git checkout pull/17299

Update a local copy of the PR:
$ git checkout pull/17299
$ git pull https://git.openjdk.org/jdk.git pull/17299/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17299

View PR using the GUI difftool:
$ git pr show -t 17299

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17299.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 8, 2024

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 8, 2024
@openjdk
Copy link

openjdk bot commented Jan 8, 2024

@prsadhuk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Jan 8, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 8, 2024

Webrevs

Copy link
Contributor

@TejeshR13 TejeshR13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@prsadhuk
Copy link
Contributor Author

@aivanov-jdk Can you please review?

Copy link
Contributor

@prrace prrace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope no one is relying on this bug.

@openjdk
Copy link

openjdk bot commented Jan 16, 2024

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318112: CSS percentage values are capped at 100%

Reviewed-by: tr, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 184 new commits pushed to the master branch:

  • 19c9388: 8323616: [JVMCI] TestInvalidJVMCIOption.java fails intermittently with NPE
  • b533272: 8299627: Fix/improve handling of "missing" element-list file
  • 1007618: 8323731: Unproblemlist gc/stress/TestStressG1Humongous.java
  • 790871e: 8323800: Serial: Fix include guard macro in generation.hpp
  • 0216f5d: 8323730: Tweak TestZAllocationStallEvent.java to allocate smaller objects
  • 21f6473: 8322675: JFR: Fail-fast mode when constants cannot be resolved
  • e2d6023: 8323631: JfrTypeSet::write_klass can enqueue a CLD klass that is unloading
  • 2fd775f: 8323651: compiler/c2/irTests/TestPrunedExHandler.java fails with -XX:+DeoptimizeALot
  • ee4d9aa: 8323659: LinkedTransferQueue add and put methods call overridable offer
  • 5045839: 8323635: Test gc/g1/TestHumongousAllocConcurrentStart.java fails with -XX:TieredStopAtLevel=3
  • ... and 174 more: https://git.openjdk.org/jdk/compare/dd517c64047705d706b095d15d9fd4e0703ab39b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 16, 2024
@prsadhuk
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 17, 2024

Going to push as commit f70667e.
Since your change was applied there have been 195 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 17, 2024
@openjdk openjdk bot closed this Jan 17, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 17, 2024
@openjdk
Copy link

openjdk bot commented Jan 17, 2024

@prsadhuk Pushed as commit f70667e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prsadhuk prsadhuk deleted the JDK-8318112 branch January 17, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants