Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8232856: jshell crashes when pressing up arrow after /! #173

Closed
wants to merge 2 commits into from

Conversation

lahodaj
Copy link
Contributor

@lahodaj lahodaj commented Sep 15, 2020

When re-running snippets, we remove the last entry (which is e.g. '/!'), and then put the expanded code back. But, while adding the code back, it is detected the entry-to-be-added duplicates the previous entry and is not added. But an internal "index" value is not updated, and still has the value it had before the removal, leading to inconsistency in the history internal data, and eventually, to a crash. Calling resetIndex() should fix the internal data.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Linux x86 Windows x64 macOS x64
Build ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) (2/9 failed) (1/9 failed)

Failed test tasks

Issue

  • JDK-8232856: jshell crashes when pressing up arrow after /!

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/173/head:pull/173
$ git checkout pull/173

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 15, 2020

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 15, 2020
@openjdk
Copy link

openjdk bot commented Sep 15, 2020

@lahodaj The following label will be automatically applied to this pull request: kulla.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the kulla kulla-dev@openjdk.org label Sep 15, 2020
@mlbridge
Copy link

mlbridge bot commented Sep 15, 2020

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 13, 2020

@lahodaj This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@openjdk
Copy link

openjdk bot commented Nov 4, 2020

@lahodaj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8232856: jshell crashes when pressing up arrow after /!

Reviewed-by: psandoz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

  • 700447f: 8255909: Remove unused delayed_value methods
  • 397972e: 8255848: -Xlog:gc+heap+exit shows "used 0K"
  • eb85b8d: 8255665: C2 should aggressively remove temporary hook nodes
  • 18bc95b: 8250625: Compiler implementation of Pattern Matching for instanceof (Final)
  • 60e4aca: 8255890: Zero: remove unused methods from BytecodeInterpreter
  • 397bae2: 8255860: Clean up CDS logging related to lambda
  • 97a81ce: 8253385: annotation processors remove varargs information from record components
  • 166c728: 8255858: Add debug agent support for storing thread names
  • a0ade22: 8255900: x86: Reduce impact when VerifyOops is disabled
  • 29db1dc: 8255886: Shenandoah: Resolve cset address truncation and register clash in interpreter LRB
  • ... and 9 more: https://git.openjdk.java.net/jdk/compare/7f4d873dd9492c128e98737eb4651a29387269e8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 4, 2020
@lahodaj
Copy link
Contributor Author

lahodaj commented Nov 5, 2020

/integrate

@openjdk openjdk bot closed this Nov 5, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 5, 2020
@openjdk
Copy link

openjdk bot commented Nov 5, 2020

@lahodaj Since your change was applied there have been 19 commits pushed to the master branch:

  • 700447f: 8255909: Remove unused delayed_value methods
  • 397972e: 8255848: -Xlog:gc+heap+exit shows "used 0K"
  • eb85b8d: 8255665: C2 should aggressively remove temporary hook nodes
  • 18bc95b: 8250625: Compiler implementation of Pattern Matching for instanceof (Final)
  • 60e4aca: 8255890: Zero: remove unused methods from BytecodeInterpreter
  • 397bae2: 8255860: Clean up CDS logging related to lambda
  • 97a81ce: 8253385: annotation processors remove varargs information from record components
  • 166c728: 8255858: Add debug agent support for storing thread names
  • a0ade22: 8255900: x86: Reduce impact when VerifyOops is disabled
  • 29db1dc: 8255886: Shenandoah: Resolve cset address truncation and register clash in interpreter LRB
  • ... and 9 more: https://git.openjdk.java.net/jdk/compare/7f4d873dd9492c128e98737eb4651a29387269e8...master

Your commit was automatically rebased without conflicts.

Pushed as commit cdef186.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated kulla kulla-dev@openjdk.org
2 participants