Skip to content

8310995: missing @since tags in 36 jdk.dynalink classes #17305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

sundararajana
Copy link
Member

@sundararajana sundararajana commented Jan 8, 2024

Adding missing "@ since 9" in javadoc comment of the public classes, interfaces and packages of the jdk.dynalink module.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8310995: missing @since tags in 36 jdk.dynalink classes (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17305/head:pull/17305
$ git checkout pull/17305

Update a local copy of the PR:
$ git checkout pull/17305
$ git pull https://git.openjdk.org/jdk.git pull/17305/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17305

View PR using the GUI difftool:
$ git pr show -t 17305

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17305.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 8, 2024

👋 Welcome back sundar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 8, 2024
@openjdk
Copy link

openjdk bot commented Jan 8, 2024

@sundararajana To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

Copy link
Member

@JimLaskey JimLaskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sundararajana
Copy link
Member Author

/label core-libs

@openjdk
Copy link

openjdk bot commented Jan 8, 2024

@sundararajana This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8310995: missing @since tags in 36 jdk.dynalink classes

Reviewed-by: jlaskey, iris, attila

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

  • 8a4dc79: 8274300: Address dsymutil warning by excluding platform specific files
  • d78e8da: 8322545: Declare newInsets as static in ThemeReader.cpp
  • 24823ba: 8323095: Expand TraceOptoParse block output abbreviations
  • d47393b: 8320128: Clean up Parse constructor for OSR
  • 387828a: 8322980: Debug agent's dumpThread() API should update thread's name before printing it
  • c4a83bd: 8323086: Shenandoah: Heap could be corrupted by oom during evacuation
  • 827c71d: 8310190: C2 SuperWord: AlignVector is broken, generates misaligned packs
  • 2acb5bd: 8322790: RISC-V: Tune costs for shuffles with no conversion
  • c8fa3e2: 8320310: CompiledMethod::has_monitors flag can be incorrect
  • 57a65fe: 8322003: JShell - Incorrect type inference in lists of records implementing interfaces
  • ... and 10 more: https://git.openjdk.org/jdk/compare/e44276989fc6358065412be7567d0141c84f1282...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated core-libs core-libs-dev@openjdk.org labels Jan 8, 2024
@openjdk
Copy link

openjdk bot commented Jan 8, 2024

@sundararajana
The core-libs label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Jan 8, 2024

Webrevs

@sundararajana
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 9, 2024

Going to push as commit 176606d.
Since your change was applied there have been 24 commits pushed to the master branch:

  • 8ae309e: 8318971: Better Error Handling for Jar Tool When Processing Non-existent Files
  • 841ab48: 8322657: CDS filemap fastdebug assert while loading Graal CE Polyglot in isolated classloader
  • 61ebe3b: 8323032: OptimizedModuleHandlingTest failed in dynamic CDS archive mode
  • ca9635d: 8322759: Eliminate -Wparentheses warnings in compiler code
  • 8a4dc79: 8274300: Address dsymutil warning by excluding platform specific files
  • d78e8da: 8322545: Declare newInsets as static in ThemeReader.cpp
  • 24823ba: 8323095: Expand TraceOptoParse block output abbreviations
  • d47393b: 8320128: Clean up Parse constructor for OSR
  • 387828a: 8322980: Debug agent's dumpThread() API should update thread's name before printing it
  • c4a83bd: 8323086: Shenandoah: Heap could be corrupted by oom during evacuation
  • ... and 14 more: https://git.openjdk.org/jdk/compare/e44276989fc6358065412be7567d0141c84f1282...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 9, 2024
@openjdk openjdk bot closed this Jan 9, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 9, 2024
@openjdk
Copy link

openjdk bot commented Jan 9, 2024

@sundararajana Pushed as commit 176606d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sundararajana
Copy link
Member Author

/backport

@openjdk
Copy link

openjdk bot commented Jan 10, 2024

@sundararajana Usage: /backport <repository> [<branch>]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants