Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8323210: Update the usage of cmsFLAGS_COPY_ALPHA #17320

Closed
wants to merge 2 commits into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Jan 9, 2024

Implementation of cmsFLAGS_COPY_ALPHA in littlecms 2.16 is changed to throw an exception:

  • if the number of extra channels in src and dst are different.
  • If dst does not have an alpha but src has
  • If src does not have an alpha but dst has

Exception does not occurred if the number of extra channels are the same(even if both are zero)


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8323210: Update the usage of cmsFLAGS_COPY_ALPHA (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17320/head:pull/17320
$ git checkout pull/17320

Update a local copy of the PR:
$ git checkout pull/17320
$ git pull https://git.openjdk.org/jdk.git pull/17320/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17320

View PR using the GUI difftool:
$ git pr show -t 17320

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17320.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 9, 2024

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 9, 2024

@mrserb The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Jan 9, 2024
@mrserb mrserb marked this pull request as ready for review January 9, 2024 08:54
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 9, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 9, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 9, 2024

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8323210: Update the usage of cmsFLAGS_COPY_ALPHA

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

  • bc05893: 8323318: Remove unused Space::is_free_block
  • dd8ae61: 8322237: Heap dump contains duplicate thread records for mounted virtual threads
  • ee98d26: 8323066: gc/g1/TestSkipRebuildRemsetPhase.java fails with 'Skipping Remembered Set Rebuild.' missing
  • 886386c: 8322890: Directly return in OldPLABSizeConstraintFunc
  • 438ab7c: 8323284: Remove unused FilteringClosure declaration
  • 52c7ff1: 8322330: JavadocHelperTest.java OOMEs with Parallel GC and ZGC
  • ff499ef: 8233443: G1 DetailedUsage class names overly generic for global namespace
  • 37a6172: 8322936: Update blessed-modifier-order.sh for default, sealed, and non-sealed
  • 7d42aa1: 8310277: jdk/javadoc/doclet/testMethodCommentAlgorithm/TestMethodCommentsAlgorithm.java fails with IllegalStateException
  • 6e9671a: 8323264: Serial: Remove unused GenerationBlockSizeClosure
  • ... and 11 more: https://git.openjdk.org/jdk/compare/8a4dc79e1a40e7115e2971af81623b6b0368f41c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 9, 2024
@mrserb
Copy link
Member Author

mrserb commented Jan 9, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Jan 9, 2024

Going to push as commit aba1933.
Since your change was applied there have been 22 commits pushed to the master branch:

  • f3be138: 8322809: SystemModulesMap::classNames and moduleNames arrays do not match the order
  • bc05893: 8323318: Remove unused Space::is_free_block
  • dd8ae61: 8322237: Heap dump contains duplicate thread records for mounted virtual threads
  • ee98d26: 8323066: gc/g1/TestSkipRebuildRemsetPhase.java fails with 'Skipping Remembered Set Rebuild.' missing
  • 886386c: 8322890: Directly return in OldPLABSizeConstraintFunc
  • 438ab7c: 8323284: Remove unused FilteringClosure declaration
  • 52c7ff1: 8322330: JavadocHelperTest.java OOMEs with Parallel GC and ZGC
  • ff499ef: 8233443: G1 DetailedUsage class names overly generic for global namespace
  • 37a6172: 8322936: Update blessed-modifier-order.sh for default, sealed, and non-sealed
  • 7d42aa1: 8310277: jdk/javadoc/doclet/testMethodCommentAlgorithm/TestMethodCommentsAlgorithm.java fails with IllegalStateException
  • ... and 12 more: https://git.openjdk.org/jdk/compare/8a4dc79e1a40e7115e2971af81623b6b0368f41c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 9, 2024
@openjdk openjdk bot closed this Jan 9, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 9, 2024
@openjdk
Copy link

openjdk bot commented Jan 9, 2024

@mrserb Pushed as commit aba1933.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the JDK-8323210 branch January 9, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants